Skip to content

Commit 73efa27

Browse files
committed
Force limit of v1 Safes for owner endpoint
- v2 paginated version is available already. - This endpoint can take a long time and use a lot of resources for owners with a lot of Safes. - Instead of deprecating it, a sane limit will only affect a small percentage of users, but will prevent issues on the service.
1 parent b642091 commit 73efa27

File tree

1 file changed

+3
-1
lines changed
  • safe_transaction_service/history

1 file changed

+3
-1
lines changed

safe_transaction_service/history/views.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1197,7 +1197,9 @@ def get(self, request, address, *args, **kwargs):
11971197
},
11981198
)
11991199

1200-
safes_for_owner = SafeLastStatus.objects.addresses_for_owner(address)
1200+
safes_for_owner = SafeLastStatus.objects.addresses_for_owner(address)[
1201+
: pagination.DefaultPagination.max_limit
1202+
]
12011203
serializer = self.get_serializer(data={"safes": safes_for_owner})
12021204
assert serializer.is_valid()
12031205
return Response(status=status.HTTP_200_OK, data=serializer.data)

0 commit comments

Comments
 (0)