fix: skip office sidecar writes during dry-run

detect() now accepts write_sidecars=False; when disabled, office files
are counted directly without calling convert_office_file() or touching
graphify-out/converted/. The dry-run CLI branch passes this flag so the
no-write promise holds even for .docx/.xlsx corpora.

Adds test_dry_run_office_no_sidecar_written to assert convert_office_file
is never called during dry-run.

Author: nuthalapativarun

graphify/__main__.py

@@ -797,7 +797,7 @@ def main() -> None:
             print(f"error: path not found: {root}", file=sys.stderr)
             sys.exit(1)
         from graphify.detect import detect as _detect
-        result = _detect(root)
+        result = _detect(root, write_sidecars=False)
         files = result["files"]
         total_files = result["total_files"]
         total_words = result["total_words"]

graphify/detect.py

@@ -299,7 +299,7 @@ def _is_ignored(path: Path, root: Path, patterns: list[str]) -> bool:
     return False
 
 
-def detect(root: Path, *, follow_symlinks: bool = False) -> dict:
+def detect(root: Path, *, follow_symlinks: bool = False, write_sidecars: bool = True) -> dict:
     files: dict[FileType, list[str]] = {
         FileType.CODE: [],
         FileType.DOCUMENT: [],
@@ -366,13 +366,18 @@ def detect(root: Path, *, follow_symlinks: bool = False) -> dict:
         if ftype:
             # Office files: convert to markdown sidecar so subagents can read them
             if p.suffix.lower() in OFFICE_EXTENSIONS:
-                md_path = convert_office_file(p, converted_dir)
-                if md_path:
-                    files[ftype].append(str(md_path))
-                    total_words += count_words(md_path)
+                if write_sidecars:
+                    md_path = convert_office_file(p, converted_dir)
+                    if md_path:
+                        files[ftype].append(str(md_path))
+                        total_words += count_words(md_path)
+                    else:
+                        # Conversion failed (library not installed) - skip with note
+                        skipped_sensitive.append(str(p) + " [office conversion failed - pip install graphifyy[office]]")
                 else:
-                    # Conversion failed (library not installed) - skip with note
-                    skipped_sensitive.append(str(p) + " [office conversion failed - pip install graphifyy[office]]")
+                    # dry-run: count words directly without writing any files
+                    files[ftype].append(str(p))
+                    total_words += count_words(p)
                 continue
             files[ftype].append(str(p))
             total_words += count_words(p)

tests/test_dry_run.py

@@ -60,3 +60,16 @@ def test_dry_run_no_graphify_out_written(tmp_path):
     (tmp_path / "a.py").write_text("a = 1\n")
     out, _ = _run_main(["graphify", "dry-run", str(tmp_path)])
     assert "No files were written" in out
+
+
+def test_dry_run_office_no_sidecar_written(tmp_path):
+    """dry-run must not write office sidecars even when .docx/.xlsx files are present."""
+    from unittest.mock import MagicMock, patch as mpatch
+
+    # Create a fake .docx so detect sees it as an office file
+    (tmp_path / "report.docx").write_bytes(b"PK\x03\x04")  # minimal docx magic bytes
+
+    with mpatch("graphify.detect.convert_office_file") as mock_convert:
+        _run_main(["graphify", "dry-run", str(tmp_path)])
+
+    mock_convert.assert_not_called()