Merge pull request #126 from fchapoton/exp_test3

using subprocess in exp. tests

Author: fchapoton

tests/experimental/test_graphparsing.py

@@ -1,10 +1,8 @@
 """Test that output from dotparsing and dot is the same"""
 
-import re
 import os
-import shutil
 import glob
-import sys
+import subprocess
 import time
 
 from PIL import ImageChops, Image
@@ -83,26 +81,26 @@ def get_testfiles():
             origpngfilename = join(PNG_DIR, basefilenamenoext + '.png')
             newpngfilename = join(PNG_DIR, basefilenamenoext + '.new.png')
             # create PNG from original dot file
-            syscmd = 'dot -Tpng %s > %s' % (dotfile, origpngfilename)
+            syscmd = ['dot', '-Tpng', '%s > %s' % (dotfile, origpngfilename)]
             log.debug("Run %s", syscmd)
-            err = os.system(syscmd)
-            if err:
+            result = subprocess.run(syscmd, text=True, capture_output=True)
+            if result.returncode:
                 log.warning("Failed to create original %s", origpngfilename)
                 failedfiles.append(basefilename)
                 continue
             # create PNG from dot file generated by dotparsing
-            syscmd = 'dot -Tpng %s > %s' % (newfilename, newpngfilename)
+            syscmd = ['dot', '-Tpng',  '%s > %s' % (newfilename, newpngfilename)]
             log.debug("Run %s", syscmd)
-            err = os.system(syscmd)
-            if err:
+            result = subprocess.run(syscmd, text=True, capture_output=True)
+            if result.returncode:
                 log.warning("Failed to create new %s", origpngfilename)
                 failedfiles.append(basefilename)
                 continue
             # load and compare images
             try:
                 imorig = Image.open(origpngfilename)
                 imnew = Image.open(newpngfilename)
-            except:
+            except OSError:
                 log.exception('Could not load %s images', basefilename)
                 continue
             if equal(imorig, imnew):