Skip to content

Commit a37ea17

Browse files
committed
Fix contribution descriptions
1 parent efc59e9 commit a37ea17

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

scripts/geocode.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ def writeToDevmap():
170170
if name:
171171
all_names.append(name)
172172

173-
descr = changelog_contributions(all_names) + [d.strip() for d in descr.split(r';')]
173+
descr = changelog_contributions(all_names) + [d.strip() for d in descr.split(r';') if d]
174174

175175
for d in descr:
176176
# since there are tags in the string, we parse it
@@ -183,17 +183,19 @@ def writeToDevmap():
183183
github = convert_trac_username(main_trac)
184184

185185
if github:
186+
span = devmap.createElement("span")
186187
a = devmap.createElement("a")
187188
a.setAttribute("href", f'https://github.com/sagemath/sage/issues?q={github}')
188189
a.setAttribute("class", "github")
189190
a.appendChild(devmap.createTextNode(f"issues"))
190-
td.appendChild(a)
191-
td.appendChild(devmap.createTextNode(", "))
191+
span.appendChild(a)
192+
span.appendChild(devmap.createTextNode(", "))
192193
a = devmap.createElement("a")
193194
a.setAttribute("href", f'https://github.com/sagemath/sage/commits?author={github}')
194195
a.setAttribute("class", "github")
195196
a.appendChild(devmap.createTextNode(f"commits (github: {github})"))
196-
td.appendChild(a)
197+
span.appendChild(a)
198+
td.appendChild(span)
197199

198200
td.setAttribute("class", "description")
199201
tr.appendChild(td)

0 commit comments

Comments
 (0)