conat → core-stream → getAllFromPersist: unreachable changes branch

[haraldschilly]

In packages/conat/sync/core-stream.ts, getAllFromPersist initializes changes but never assigns to it, so the branch is never taken. Is this dead code or a missing update path?

Code (from packages/conat/sync/core-stream.ts):

let messages: StoredMessage[] = [];
let changes: (SetOperation | DeleteOperation | StoredMessage)[] = [];
// ...
this.processPersistentMessages(messages, {
  noEmit,
  noSeqCheck: true,
});
if (changes.length > 0) {
  this.processPersistentMessages(changes, {
    noEmit,
    noSeqCheck: false,
  });
}