more tests

Author: sagiegurari

README.md

@@ -108,7 +108,7 @@ See [contributing guide](.github/CONTRIBUTING.md)
 
 | Date        | Version | Description |
 | ----------- | ------- | ----------- |
-| 2017-03-09  | v1.2.8  | Maintenance |
+| 2017-03-09  | v1.2.9  | Maintenance |
 | 2017-01-22  | v1.2.0  | Split the internal web notification API into a new project: simple-web-notification |
 | 2017-01-13  | v1.0.26 | Maintenance |
 | 2016-11-23  | v1.0.19 | Use forked version of html5-desktop-notifications in order to resolve few issues |

angular-web-notification.js

@@ -67,7 +67,6 @@
          */
         var showNotification = webNotificationAPI.showNotification;
 
-        /*istanbul ignore else*/
         if (showNotification) {
             return webNotificationAPI;
         }

bower.json

@@ -1,6 +1,6 @@
 {
   "name": "angular-web-notification",
-  "version": "1.2.8",
+  "version": "1.2.9",
   "description": "AngularJS service for displaying web notifications.",
   "authors": [
     "Sagie Gur-Ari <[email protected]>"

docs/CHANGELOG.md

@@ -1,6 +1,6 @@
 | Date        | Version | Description |
 | ----------- | ------- | ----------- |
-| 2017-03-09  | v1.2.8  | Maintenance |
+| 2017-03-09  | v1.2.9  | Maintenance |
 | 2017-01-22  | v1.2.0  | Split the internal web notification API into a new project: simple-web-notification |
 | 2017-01-13  | v1.0.26 | Maintenance |
 | 2016-11-23  | v1.0.19 | Use forked version of html5-desktop-notifications in order to resolve few issues |

package.json

@@ -1,6 +1,6 @@
 {
   "name": "angular-web-notification",
-  "version": "1.2.8",
+  "version": "1.2.9",
   "description": "AngularJS service for displaying web notifications.",
   "author": {
     "name": "Sagie Gur-Ari",

test/spec/angular-web-notification-spec.js

@@ -22,8 +22,21 @@ describe('angular-web-notification', function () {
 
     beforeEach(window.angular.mock.module('angular-web-notification'));
 
-    beforeEach(inject(function (webNotification) {
-        webNotification.allowRequest = true;
+    it('library not defined test', inject(function ($injector) {
+        var showNotification = window.webNotification.showNotification;
+        delete window.webNotification.showNotification;
+
+        var errorDetected = false;
+        try {
+            $injector.get('webNotification').$get();
+        } catch (error) {
+            assert.isDefined(error);
+            errorDetected = true;
+        }
+
+        window.webNotification.showNotification = showNotification;
+
+        assert.isTrue(errorDetected);
     }));
 
     it('init test', inject(function (webNotification) {
@@ -36,7 +49,9 @@ describe('angular-web-notification', function () {
         describe('allowed', function () {
             it('valid', function (done) {
                 inject(function (webNotification) {
+                    webNotification.allowRequest = true;
                     assert.isTrue(webNotification.lib.MOCK_NOTIFY);
+
                     window.Notification.setAllowed(function (title, options) {
                         assert.equal(title, 'Example Notification');
                         assert.deepEqual(options, {
@@ -56,7 +71,9 @@ describe('angular-web-notification', function () {
 
             it('auto close', function (done) {
                 inject(function (webNotification) {
+                    webNotification.allowRequest = true;
                     assert.isTrue(webNotification.lib.MOCK_NOTIFY);
+
                     window.Notification.setAllowed(function (title, options) {
                         assert.equal(title, 'Example Notification');
                         assert.deepEqual(options, {
@@ -78,7 +95,9 @@ describe('angular-web-notification', function () {
 
             it('first time permissions', function (done) {
                 inject(function (webNotification) {
+                    webNotification.allowRequest = true;
                     assert.isTrue(webNotification.lib.MOCK_NOTIFY);
+
                     window.Notification.setNotAllowed(function (title, options) {
                         assert.equal(title, 'first time');
                         assert.deepEqual(options, {
@@ -105,7 +124,9 @@ describe('angular-web-notification', function () {
         describe('not allowed', function () {
             it('not allowed', function (done) {
                 inject(function (webNotification) {
+                    webNotification.allowRequest = true;
                     assert.isTrue(webNotification.lib.MOCK_NOTIFY);
+
                     window.Notification.setNotAllowed();
 
                     webNotification.showNotification('not allowed', {}, function onShow(error, hide) {
@@ -117,6 +138,7 @@ describe('angular-web-notification', function () {
             it('not allowed and not allowed to ask permissions', function (done) {
                 inject(function (webNotification) {
                     assert.isTrue(webNotification.lib.MOCK_NOTIFY);
+
                     window.Notification.setNotAllowed();
                     webNotification.allowRequest = false;