Commit 6cebd1c
Remove arithmetic transforms from InSampleUniform registration (facebook#5117)
Summary:
Pull Request resolved: facebook#5117
`InSampleUniformGenerator` selects existing arms for LILO labeling -- it does not generate new points and therefore does not need parameter normalization.
The `Cont_X_trans` transform chain includes `Log`, `Logit`, and `UnitX`, which perform arithmetic whose forward/reverse round-trip introduces ~1e-15 IEEE 754 rounding. This can produce arms with slightly different parameter values and signatures ("ghost arms"), preventing the experiment from reusing existing `Arm` objects. Downstream, LILO source resolution fails because no arm matches by signature.
This diff registers `InSampleUniform` with only the structural/type transforms (`RemoveFixed`, `OrderedChoiceToIntegerRange`, `OneHot`, `IntToFloat`) needed for categorical, ordered-choice, integer, and fixed parameter compatibility. The arithmetic transforms (`Log`, `Logit`, `UnitX`) are removed since they serve no purpose for in-sample selection and introduce precision loss.
Note: for experiments with `digits` set on `RangeParameter`, the auto-added `Cast` transform also rounds parameter values. In properly configured new experiments this is consistent (Cast untransform re-rounds on the reverse path), but historical experiments may have arms stored with un-rounded values from before Cast handled this correctly. This diff addresses the UnitX/Log/Logit source of precision loss; historical data inconsistencies are a separate concern.
Reviewed By: andycylmeta
Differential Revision: D98970704
fbshipit-source-id: e3baeb66156393f81492bd02208bcaac3f7b9aa21 parent efd72a6 commit 6cebd1c
1 file changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
219 | 226 | | |
220 | 227 | | |
221 | 228 | | |
222 | | - | |
| 229 | + | |
223 | 230 | | |
224 | 231 | | |
225 | 232 | | |
| |||
0 commit comments