Skip to content

Commit e7305d9

Browse files
committed
Run lerna as a dev on changes since origin/master.
1 parent 62c0d9e commit e7305d9

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

webcomponents/tool/src/main/frontend/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"analyze-bundle": "esbuild \"bundle-entry-points/*.js\" --preserve-symlinks --splitting --bundle --metafile=meta.json --format=esm --outdir=bundles --minify",
1313
"analyze": "lit-analyzer --strict --quiet --rules.no-complex-attribute-binding=warning --rules.no-incompatible-type-binding=off \"packages/**/src/*.js\"",
1414
"test": "playwright install chromium && wtr",
15-
"test:dev": "playwright install chromium && lerna run test --concurrency 1 --stream --since HEAD"
15+
"test:dev": "playwright install chromium && lerna run test --concurrency 1 --stream --since origin/master"
1616
},
1717
"keywords": [],
1818
"author": "",

webcomponents/tool/src/main/frontend/packages/sakai-editor/src/SakaiEditor.js

+2
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ export class SakaiEditor extends SakaiElement {
5050

5151
this.content = text;
5252

53+
this.ears = "wax";
54+
5355
if (this.textarea) {
5456
this.querySelector("textarea").value = this.content;
5557
} else {

webcomponents/tool/src/main/frontend/packages/sakai-permissions/src/SakaiPermissions.js

+13
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ export class SakaiPermissions extends SakaiElement {
127127
</sakai-group-picker>
128128
</div>
129129
` : nothing }
130+
130131
<div class="mb-1 pt-3">
131132
<button class="btn btn-secondary"
132133
aria-label="${this._i18n["per.lis.restoredef"]}"
@@ -136,14 +137,19 @@ export class SakaiPermissions extends SakaiElement {
136137
</div>
137138
138139
<div id="permissions-container" class="container mt-4">
140+
141+
<!-- START HEADER -->
139142
<div id="permission-header" class="row flex-nowrap">
143+
<!-- Add the button which toggles all the permissions -->
140144
<div class="col-md-6 p-3">
141145
<button class="btn btn-transparent"
142146
title="${this._i18n["per.lis.head.title"]}"
143147
@click=${this._handlePermissionClick}>
144148
${this._i18n["per.lis.head"]}
145149
</button>
146150
</div>
151+
152+
<!-- Now add all the role headers -->
147153
${this.roles.map(role => html`
148154
<div class="col-sm role d-none d-md-block p-3 text-center"
149155
data-role="${role}"
@@ -158,8 +164,13 @@ export class SakaiPermissions extends SakaiElement {
158164
</div>
159165
`)}
160166
</div>
167+
<!-- END HEADER -->
168+
169+
<!-- For each available permission, add a row -->
161170
${this.available.map(perm => html`
162171
<div class="row permission-row">
172+
173+
<!-- Add the permission title. Clicking this will toggle this permission for each role -->
163174
<div class="col-md-6 p-3 fw-bolder fw-md-normal">
164175
<button class="btn btn-transparent fw-bolder fw-md-normal text-start"
165176
title="${this._i18n["per.lis.perm.title"]}"
@@ -168,6 +179,8 @@ export class SakaiPermissions extends SakaiElement {
168179
${this._i18n[perm]}
169180
</button>
170181
</div>
182+
183+
<!-- Add a checkbox for each role. If this perm is in the this.on object, it is checked -->
171184
${this.roles.map(role => html`
172185
<div class="col-md ${role.replace(" ", "_")}-checkbox-cell text-start text-md-center p-3 permission-cell border-left-1">
173186
<label for="${role}:${perm}" class="sr-only">

0 commit comments

Comments
 (0)