Phase 3 — fixture and pipeline hygiene (#10)

Closes C-2, L-1, L-2, L-3, L-5 from FINAL_CLEANUP.md. Verifies M-7 is
already complete from Phase 2.

- C-2 (pipeline/mod.rs): replace the four opaque FAR_FIELD_* ECI
  Cartesian constants in the far-field test fixture with a Keplerian
  derivation — iss_like_elements() + 50 km SMA offset + 0.2 rad mean
  anomaly offset. δa/a ≈ 7.4e-3 crosses the default roe_threshold of
  5e-3, classifying the pair as FarField. δλ is deliberately excluded
  from dimensionless_norm per Koenig Sec. V, so a pure in-track offset
  would always classify as Proximity regardless of separation — the SMA
  bump is the lightest physical component that crosses the threshold.
  Mirrors the existing proximity_input() idiom.

- L-1 (validation/trajectory.rs:249): pre-size eclipse_samples to
  chief_results.len() when earth_frame.is_some(); leave it as
  Vec::new() when eclipse validation is disabled so the disabled
  path stays zero-allocation.

- L-2 (validation/trajectory.rs:1071): flip
  f64::from(u32::try_from(5 + j).unwrap()) to
  f64::from(5_u32 + u32::try_from(j).unwrap()) so the arithmetic stays
  in u32 rather than casting a usize sum.

- L-3 (validation/statistics.rs): drop four narrative comments that
  restated what the code does — mechanical "compare candidates" at the
  binary search, a three-line test-value table, two "leg excluded" /
  "no input" test narrations. Keep the load-bearing comments (time-
  sorted input invariant, sum/sum-sq recovery math, +0.0 bit-pattern
  empty-input contract, all-zero summaries contract).

- L-5 (validation/trajectory.rs:1833, 1945): normalize two #[ignore]
  strings from capital-R "Requires MetaAlmanac" to lowercase-r
  "requires MetaAlmanac" so all 25 MetaAlmanac ignore sites use the
  same canonical string. SPICE-kernel-specific strings in
  nyx_bridge/almanac.rs describe a different prerequisite and are
  intentionally left alone.

- M-7: verified as already complete — Phase 2 named both 709.0 call
  sites as const MID_COAST_BURN_ELAPSED_S.

Verification: 586 passed / 0 failed / 0 ignored across the workspace
with --include-ignored (unchanged from Phase 2 baseline). Clippy,
docs, and wasm-pack build all clean. rpo-cli mission/validate/mc
JSON outputs are byte-identical to the pre-Phase-3 baseline (modulo
non-deterministic elapsed_wall_s in MC).

Author: sakobu

rpo-nyx/src/pipeline/mod.rs

@@ -213,40 +213,39 @@ mod tests {
     /// cascade will exceed it.
     const CASCADE_DV_CHANGE_TOL_KM_S: f64 = 1e-10;
 
-    // --- Far-field test fixture state vectors (ECI) -----------------------
-    // ISS-like orbit, chief and deputy separated by ~1600 km so the
-    // classification path exits the proximity regime and exercises the
-    // full Lambert solve + propagation pipeline.
-
-    /// Far-field fixture: chief position in ECI (km).
-    const FAR_FIELD_CHIEF_POSITION_ECI_KM: [f64; 3] = [5876.261, 3392.661, 0.0];
-
-    /// Far-field fixture: chief velocity in ECI (km/s).
-    const FAR_FIELD_CHIEF_VELOCITY_ECI_KM_S: [f64; 3] = [-2.380_512, 4.123_167, 6.006_917];
-
-    /// Far-field fixture: deputy position in ECI (km).
-    const FAR_FIELD_DEPUTY_POSITION_ECI_KM: [f64; 3] =
-        [5_199.839_421, 4_281.648_523, 1_398.070_066];
-
-    /// Far-field fixture: deputy velocity in ECI (km/s).
-    const FAR_FIELD_DEPUTY_VELOCITY_ECI_KM_S: [f64; 3] = [-3.993_103, 2.970_313, 5.764_540];
-
     /// Build a minimal `PipelineInput` from the standard far-field test scenario.
+    ///
+    /// Chief is an ISS-like orbit; deputy is offset by `FAR_FIELD_SMA_OFFSET_KM`
+    /// in semi-major axis and `FAR_FIELD_PHASE_OFFSET_RAD` in mean anomaly so
+    /// that `dimensionless_norm(roe) = δa/a ≈ 7.4e-3` crosses the default
+    /// `ProximityConfig::roe_threshold` of 5e-3, classifying the pair as
+    /// `FarField` and exercising the full Lambert solve + propagation pipeline.
+    ///
+    /// Note: δλ (along-track phase) is deliberately excluded from
+    /// `dimensionless_norm` per Koenig Sec. V, so a pure in-track offset would
+    /// always classify as Proximity no matter how large. δa is the lightest
+    /// component that crosses the threshold with a physically sensible value.
     fn far_field_input() -> PipelineInput {
         use hifitime::Epoch;
-        use nalgebra::Vector3;
+        use rpo_core::elements::keplerian_conversions::keplerian_to_state;
+        use rpo_core::test_helpers::iss_like_elements;
 
-        let chief = StateVector {
-            epoch: Epoch::from_gregorian_str("2024-01-01T00:00:00 UTC").unwrap(),
-            position_eci_km: Vector3::from(FAR_FIELD_CHIEF_POSITION_ECI_KM),
-            velocity_eci_km_s: Vector3::from(FAR_FIELD_CHIEF_VELOCITY_ECI_KM_S),
-        };
+        // Altitude offset producing δa ≈ 7.4e-3 for an ISS-like chief (a ≈ 6778 km).
+        // Comfortably above the default 5e-3 FarField threshold without entering
+        // a regime where Lambert needs multi-rev handling.
+        const FAR_FIELD_SMA_OFFSET_KM: f64 = 50.0;
+        // In-track phase shift giving the deputy a physically interpretable
+        // separation from the chief at t = 0. ~0.2 rad ≈ 1.4 Mm along-track.
+        const FAR_FIELD_PHASE_OFFSET_RAD: f64 = 0.2;
 
-        let deputy = StateVector {
-            epoch: Epoch::from_gregorian_str("2024-01-01T00:00:00 UTC").unwrap(),
-            position_eci_km: Vector3::from(FAR_FIELD_DEPUTY_POSITION_ECI_KM),
-            velocity_eci_km_s: Vector3::from(FAR_FIELD_DEPUTY_VELOCITY_ECI_KM_S),
-        };
+        let epoch = Epoch::from_gregorian_str("2024-01-01T00:00:00 UTC").unwrap();
+        let chief_ke = iss_like_elements();
+        let mut deputy_ke = chief_ke;
+        deputy_ke.a_km += FAR_FIELD_SMA_OFFSET_KM;
+        deputy_ke.mean_anomaly_rad += FAR_FIELD_PHASE_OFFSET_RAD;
+
+        let chief = keplerian_to_state(&chief_ke, epoch).unwrap();
+        let deputy = keplerian_to_state(&deputy_ke, epoch).unwrap();
 
         PipelineInput {
             chief,

rpo-nyx/src/validation/statistics.rs

@@ -24,7 +24,6 @@ pub(super) fn find_closest_analytical_ric(trajectory: &[PropagatedState], elapse
     // Trajectory is time-sorted by construction; binary search for insertion point
     let idx = trajectory.partition_point(|s| s.elapsed_s < elapsed_s);
 
-    // Compare the two candidates bracketing the insertion point
     let best = if idx == 0 {
         &trajectory[0]
     } else if idx >= trajectory.len() {
@@ -249,10 +248,6 @@ mod tests {
     }
 
     /// Verify `compute_leg_summaries` with mixed pre/post-COLA points across legs.
-    ///
-    /// Leg 0: errors [1.0, 3.0, 2.0], no post-COLA → max=3.0, mean=2.0, rms=sqrt(14/3)
-    /// Leg 1: errors [1.0(pre), 2.0(pre), 10.0(post)] → max=2.0, mean=1.5, 1 excluded
-    /// Leg 2: all post-COLA → `num_points=0`, 2 excluded
     #[test]
     fn leg_summaries_mixed_cola() {
         let make = |pos_err: f64, vel_err: f64, post_cola: bool| ValidationPoint {
@@ -297,7 +292,6 @@ mod tests {
         assert_eq!(summaries[1].num_points, 2);
         assert_eq!(summaries[1].num_post_cola_excluded, 1);
 
-        // Leg 2: all excluded — max starts at +0.0 and never updates.
         assert_eq!(summaries[2].max_position_error_km.to_bits(), 0_u64);
         assert_eq!(summaries[2].num_points, 0);
         assert_eq!(summaries[2].num_post_cola_excluded, 2);
@@ -317,7 +311,6 @@ mod tests {
         assert_eq!(summaries.len(), 1);
         assert_eq!(summaries[0].num_points, 0);
         assert_eq!(summaries[0].num_post_cola_excluded, 0);
-        // No input means no update to `max_position_error_km`; stays at +0.0.
         assert_eq!(summaries[0].max_position_error_km.to_bits(), 0_u64);
     }
 }

rpo-nyx/src/validation/trajectory.rs

@@ -246,7 +246,11 @@ fn build_leg_comparison_points(
 ) -> Result<LegComparisonOutput, ValidationError> {
     let mut points = Vec::with_capacity(chief_results.len());
     let mut safety_pairs = Vec::with_capacity(chief_results.len());
-    let mut eclipse_samples = Vec::new();
+    let mut eclipse_samples = if earth_frame.is_some() {
+        Vec::with_capacity(chief_results.len())
+    } else {
+        Vec::new()
+    };
 
     for (idx, (chief_sample, deputy_sample)) in
         chief_results.iter().zip(deputy_results.iter()).enumerate()
@@ -1068,7 +1072,7 @@ mod tests {
         let post_cola_distances = [3.0, 1.5, 0.8, 2.0, 4.0];
         for (j, &d) in post_cola_distances.iter().enumerate() {
             deputy.push(make_timed_state(
-                f64::from(u32::try_from(5 + j).unwrap()) * 100.0,
+                f64::from(5_u32 + u32::try_from(j).unwrap()) * 100.0,
                 Vector3::new(d, 0.0, 0.0),
             ));
         }
@@ -1826,7 +1830,7 @@ mod tests {
     /// guarantees pre-COLA and post-COLA paths see the same sampling grid and
     /// the same physical trajectory in the pre-burn window.
     #[test]
-    #[ignore = "Requires MetaAlmanac (network on first run)"]
+    #[ignore = "requires MetaAlmanac (network on first run)"]
     fn propagate_leg_segment_1_is_impulse_independent() {
         use test_scenario::{
             iss_formation_roe, leg_propagation_ctx_from_scenario,
@@ -1938,7 +1942,7 @@ mod tests {
     /// the sampling artifact where post-COLA looked worse than pre-COLA in
     /// the validate.md Safety Comparison table.
     #[test]
-    #[ignore = "Requires MetaAlmanac (network on first run)"]
+    #[ignore = "requires MetaAlmanac (network on first run)"]
     fn pre_cola_and_post_cola_pre_burn_window_match_within_sampling_tolerance() {
         use rpo_core::mission::config::MissionConfig;
         use rpo_core::mission::types::Waypoint;