make union

Author: lkostrowski

src/types.ts

@@ -236,57 +236,69 @@ export type SyncWebhookEventType =
   | "PAYMENT_METHOD_INITIALIZE_TOKENIZATION_SESSION"
   | "PAYMENT_METHOD_PROCESS_TOKENIZATION_SESSION";
 
-export interface AppExtension {
+interface BaseAppExtension {
   /** Name which will be displayed in the dashboard */
   label: string;
   /** the place where the extension will be mounted */
   mount: AppExtensionMount;
   /** Method of presenting the interface
-    `POPUP` will present the interface in a modal overlay
-    `APP_PAGE` will navigate to the application page
-    @default `POPUP`
-  */
-  target: AppExtensionTarget;
+   `POPUP` will present the interface in a modal overlay
+   `APP_PAGE` will navigate to the application page
+   @default `POPUP`
+   */
   permissions: AppPermission[];
   /** URL of the view to display;
-    you can skip the domain and protocol when target is set to `APP_PAGE`, or when your manifest defines an `appUrl`.
+   you can skip the domain and protocol when target is set to `APP_PAGE`, or when your manifest defines an `appUrl`.
 
-    When target is set to `POPUP`, the url will be used to render an `<iframe>`.
+   When target is set to `POPUP`, the url will be used to render an `<iframe>`.
    */
   url: string;
-  /**
-   * Additional parameters for extensions
-   *
-   * Only specific target options should be used
-   *
-   * TODO: Make it discriminated union
-   */
+}
+
+type PopupExtensionWidget = BaseAppExtension & {
+  target: "POPUP";
+};
+
+type AppPageExtensionWidget = BaseAppExtension & {
+  target: "APP_PAGE";
+};
+
+type AppExtensionWidget = BaseAppExtension & {
+  target: "WIDGET";
   options?: {
-    /**
-     * Only when target is NEW_TAB.
-     */
-    newTabTarget?: {
+    widgetTarget?: {
       /**
        * Controls how dashboard will open the new tab
        * - GET -> open URL in the new window
-       * - POST -> submit internal <form> using POST method. Passes token and additional parameters into body
-       * Default is GET
-       *
+       * - POST -> submit internal <form> using POST method. Passes token and additional parameters into body*
        */
       method?: "GET" | "POST";
     };
-    widgetTarget?: {
+  };
+};
+
+type AppExtensionNewTab = BaseAppExtension & {
+  target: "NEW_TAB";
+  options?: {
+    /**
+     * Only when target is NEW_TAB.
+     */
+    newTabTarget?: {
       /**
        * Controls how dashboard will open the new tab
        * - GET -> open URL in the new window
-       * - POST -> submit internal <form> using POST method. Passes token and additional parameters into body
-       * Default is GET
-       *
+       * - POST -> submit internal <form> using POST method. Passes token and additional parameters into body*
        */
       method?: "GET" | "POST";
     };
   };
-}
+};
+
+export type AppExtension =
+  | AppPageExtensionWidget
+  | AppExtensionNewTab
+  | AppExtensionWidget
+  | PopupExtensionWidget;
 
 export interface WebhookManifest {
   name: string;
@@ -321,18 +333,18 @@ export interface AppManifest {
   /** App website rendered in the dashboard */
   appUrl: string;
   /** Address to the app configuration page, which is rendered in the dashboard
-    @deprecated in Saleor 3.5, use appUrl instead
-  */
+   @deprecated in Saleor 3.5, use appUrl instead
+   */
   configurationUrl?: string;
   /** Endpoint used during process of app installation
 
-    @see [Installing an app](https://docs.saleor.io/docs/3.x/developer/extending/apps/installing-apps#installing-an-app) 
-  */
+   @see [Installing an app](https://docs.saleor.io/docs/3.x/developer/extending/apps/installing-apps#installing-an-app)
+   */
   tokenTargetUrl: string;
   /** Short description of privacy policy displayed in the dashboard
 
-    @deprecated in Saleor 3.5, use dataPrivacyUrl instead
-  */
+   @deprecated in Saleor 3.5, use dataPrivacyUrl instead
+   */
   dataPrivacy?: string;
   /** URL to the full privacy policy */
   dataPrivacyUrl?: string;
@@ -342,17 +354,17 @@ export interface AppManifest {
   supportUrl?: string;
   /** List of extensions that will be mounted in Saleor's dashboard
 
-  @see For details, please see the [extension section](https://docs.saleor.io/docs/3.x/developer/extending/apps/extending-dashboard-with-apps#key-concepts)
-  */
+   @see For details, please see the [extension section](https://docs.saleor.io/docs/3.x/developer/extending/apps/extending-dashboard-with-apps#key-concepts)
+   */
   extensions?: AppExtension[];
   /** List of webhooks that will be set.
-  
-  @see For details, please look at [asynchronous webhooks](https://docs.saleor.io/docs/3.x/developer/extending/apps/asynchronous-webhooks),
-  [synchronous-webhooks](https://docs.saleor.io/docs/3.x/developer/extending/apps/synchronous-webhooks/key-concepts)
-  and [webhooks' subscription](https://docs.saleor.io/docs/3.x/developer/extending/apps/subscription-webhook-payloads)
 
-  Be aware that subscription queries are required in manifest sections
-  */
+   @see For details, please look at [asynchronous webhooks](https://docs.saleor.io/docs/3.x/developer/extending/apps/asynchronous-webhooks),
+    [synchronous-webhooks](https://docs.saleor.io/docs/3.x/developer/extending/apps/synchronous-webhooks/key-concepts)
+    and [webhooks' subscription](https://docs.saleor.io/docs/3.x/developer/extending/apps/subscription-webhook-payloads)
+
+    Be aware that subscription queries are required in manifest sections
+   */
   webhooks?: WebhookManifest[];
   /**
    * Allows app installation for specific Saleor versions, using semver.