Skip to content

Commit c69f0ff

Browse files
authored
Fix webhook response builder params for transaction events to align with Saleor documentation (#429)
1 parent abe1b50 commit c69f0ff

File tree

2 files changed

+30
-15
lines changed

2 files changed

+30
-15
lines changed

.changeset/shy-pigs-appear.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@saleor/app-sdk": patch
3+
---
4+
5+
Fixed `TRANSACTION_CHARGE_REQUESTED`, `TRANSACTION_REFUND_REQUESTED`, `TRANSACTION_CANCELATION_REQUESTED`, `TRANSACTION_INITIALIZE_SESSION` and `TRANSACTION_PROCESS_SESSION` webhook response builder params. After this change `buildSyncWebhookResponsePayload` for those events should be the same as in Saleor docs.

src/handlers/shared/sync-webhook-response-builder.ts

Lines changed: 25 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -29,66 +29,76 @@ export type SyncWebhookResponsesMap = {
2929
*/
3030
maximum_delivery_days?: number;
3131
}>;
32+
// https://docs.saleor.io/developer/extending/webhooks/synchronous-events/transaction#response
3233
TRANSACTION_CHARGE_REQUESTED: {
33-
pspReference: string;
34-
result?: "CHARGE_SUCCESS" | "CHARGE_FAILURE";
35-
amount?: number;
34+
result: "CHARGE_SUCCESS" | "CHARGE_FAILURE";
35+
amount: number;
36+
pspReference?: string;
3637
time?: string;
3738
externalUrl?: string;
3839
message?: string;
40+
actions?: Array<"CHARGE" | "REFUND" | "CANCEL">;
3941
};
42+
// https://docs.saleor.io/developer/extending/webhooks/synchronous-events/transaction#sync-flow-2
4043
TRANSACTION_REFUND_REQUESTED: {
41-
pspReference: string;
42-
result?: "REFUND_SUCCESS" | "REFUND_FAILURE";
43-
amount?: number;
44+
result: "REFUND_SUCCESS" | "REFUND_FAILURE";
45+
amount: number;
46+
pspReference?: string;
4447
time?: string;
4548
externalUrl?: string;
4649
message?: string;
50+
actions?: Array<"CHARGE" | "REFUND" | "CANCEL">;
4751
};
52+
// https://docs.saleor.io/developer/extending/webhooks/synchronous-events/transaction#response-1
4853
TRANSACTION_CANCELATION_REQUESTED: {
49-
pspReference: string;
50-
result?: "CANCEL_SUCCESS" | "CANCEL_FAILURE";
51-
amount?: number;
54+
result: "CANCEL_SUCCESS" | "CANCEL_FAILURE";
55+
amount: number;
56+
pspReference?: string;
5257
time?: string;
5358
externalUrl?: string;
5459
message?: string;
60+
actions?: Array<"CHARGE" | "REFUND" | "CANCEL">;
5561
};
5662
PAYMENT_GATEWAY_INITIALIZE_SESSION: {
5763
data: unknown;
5864
};
65+
// https://docs.saleor.io/developer/extending/webhooks/synchronous-events/transaction#response-4
5966
TRANSACTION_INITIALIZE_SESSION: {
60-
pspReference?: string;
61-
data?: unknown;
6267
result:
6368
| "CHARGE_SUCCESS"
6469
| "CHARGE_FAILURE"
6570
| "CHARGE_REQUEST"
6671
| "CHARGE_ACTION_REQUIRED"
6772
| "AUTHORIZATION_SUCCESS"
6873
| "AUTHORIZATION_FAILURE"
69-
| "AUTHORIZATION_REQUESTED"
74+
| "AUTHORIZATION_REQUEST"
7075
| "AUTHORIZATION_ACTION_REQUIRED";
7176
amount: number;
77+
pspReference?: string;
78+
data?: unknown;
7279
time?: string;
7380
externalUrl?: string;
7481
message?: string;
82+
actions?: Array<"CHARGE" | "REFUND" | "CANCEL">;
7583
};
84+
// https://docs.saleor.io/developer/extending/webhooks/synchronous-events/transaction#response-5
7685
TRANSACTION_PROCESS_SESSION: {
77-
pspReference?: string;
78-
data?: unknown;
7986
result:
8087
| "CHARGE_SUCCESS"
8188
| "CHARGE_FAILURE"
8289
| "CHARGE_REQUEST"
8390
| "CHARGE_ACTION_REQUIRED"
8491
| "AUTHORIZATION_SUCCESS"
8592
| "AUTHORIZATION_FAILURE"
86-
| "AUTHORIZATION_REQUESTED"
93+
| "AUTHORIZATION_REQUEST"
8794
| "AUTHORIZATION_ACTION_REQUIRED";
8895
amount: number;
96+
pspReference?: string;
97+
data?: unknown;
8998
time?: string;
9099
externalUrl?: string;
91100
message?: string;
101+
actions?: Array<"CHARGE" | "REFUND" | "CANCEL">;
92102
};
93103
PAYMENT_METHOD_PROCESS_TOKENIZATION_SESSION:
94104
| {

0 commit comments

Comments
 (0)