Skip to content

Commit 0c540ab

Browse files
committed
wip
1 parent a3c5c5d commit 0c540ab

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

src/extensions/domain/app-extension-manifest.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ export const appExtensionManifest = z
1212
url: z.string().min(1),
1313
mount: ALL_APP_EXTENSION_MOUNTS,
1414
target: AppExtensionManifestTarget.default("POPUP"),
15-
// todo add permissions check
1615
permissions: z.array(z.string()).optional().default([]),
1716
options: appExtensionManifestOptionsSchema.optional(),
1817
})

src/extensions/extension-manifest-validator.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { AppManifest, appManifestSchema } from "@dashboard/extensions/domain/app-manifest";
22
import { ZodIssue } from "zod";
33

4+
//todo test
45
export class ExtensionManifestValidator {
56
validateAppManifest(manifestJson: unknown): AppManifest | { issues: ZodIssue[] } {
67
const result = appManifestSchema.safeParse(manifestJson);

0 commit comments

Comments
 (0)