fixes after CR

Author: kzuraw

.changeset/slimy-bikes-wink.md

@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+Add missing logic for handling product variant metadata when accessed from order line modal (on order details page).

locale/defaultMessages.json

@@ -312,10 +312,6 @@
     "context": "channels alphabetically title",
     "string": "Channels from A to Z"
   },
-  "/mwSjm": {
-    "context": "modal subheader, read-only product variant metadata",
-    "string": "This is a metadata of the variant that is being used in this ordered item"
-  },
   "/n+NRO": {
     "string": "Note id"
   },
@@ -4328,10 +4324,6 @@
   "PFtMy9": {
     "string": "Canceled"
   },
-  "PH4R7g": {
-    "context": "modal header, read-only product variant metadata",
-    "string": "Product variant metadata"
-  },
   "PHT8z1": {
     "context": "extension form permissions section header",
     "string": "Permissions"
@@ -7219,6 +7211,10 @@
   "hPB89Y": {
     "string": "No invoices to be shown"
   },
+  "hQDWIw": {
+    "context": "modal header, editable product variant metadata",
+    "string": "Product variant metadata"
+  },
   "hS+ZjH": {
     "context": "delete webhook",
     "string": "Are you sure you want to delete this webhook?"
@@ -9125,6 +9121,10 @@
     "context": "button",
     "string": "Set end date"
   },
+  "tquei9": {
+    "context": "modal subheader, editable product variant metadata",
+    "string": "This is a metadata of the variant that is being used in this ordered item"
+  },
   "tsL3IW": {
     "context": "gift card history message",
     "string": "Gift card was sent to customer"

src/orders/components/OrderMetadataDialog/useHandleSubmit.ts

@@ -37,13 +37,17 @@ export const useHandleOrderLineMetadataSubmit = ({
 
     return createMetadataUpdateHandler(
       initialData,
+      // Placeholder to keep backward compatibility - we now use react-hook-form for form state management
       () => Promise.resolve([]),
       variables => updateMetadata({ variables }),
       variables => updatePrivateMetadata({ variables }),
     );
   }, [initialData, updateMetadata, updatePrivateMetadata]);
 
   const variantSubmitHandler = useMemo(() => {
+    // Fallback handler: If there is no variant data to submit,
+    // return a promise resolving to an empty error array.
+    // This is appropriate because no submission occurs, so no errors are possible.
     if (!initialData?.variant) {
       return () => Promise.resolve([]);
     }