Skip to content

Commit b980da7

Browse files
committed
fix types
1 parent 54b40fa commit b980da7

2 files changed

Lines changed: 43 additions & 114 deletions

File tree

src/channels/views/ChannelDetails/ChannelDetails.tsx

Lines changed: 30 additions & 88 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,13 @@ import {
88
type ChannelDeleteMutation,
99
type ChannelErrorFragment,
1010
type ChannelUpdateMutation,
11-
isMainSchema,
12-
isStagingSchema,
1311
useChannelActivateMutation,
1412
useChannelDeactivateMutation,
1513
useChannelDeleteMutation,
1614
useChannelQuery,
1715
useChannelsQuery,
1816
useChannelUpdateMutation,
1917
} from "@dashboard/graphql";
20-
import {
21-
useChannelQuery as useChannelQueryStaging,
22-
useChannelsQuery as useChannelsQueryStaging,
23-
useChannelUpdateMutation as useChannelUpdateMutationStaging,
24-
} from "@dashboard/graphql/staging";
2518
import { getSearchFetchMoreProps } from "@dashboard/hooks/makeTopLevelSearch/utils";
2619
import useNavigator from "@dashboard/hooks/useNavigator";
2720
import { useNotifier } from "@dashboard/hooks/useNotifier";
@@ -53,47 +46,25 @@ const ChannelDetails = ({ id, params }: ChannelDetailsProps) => {
5346
const notify = useNotifier();
5447
const intl = useIntl();
5548
const shop = useShop();
56-
const channelsListDataMain = useChannelsQuery({
57-
displayLoader: true,
58-
skip: isStagingSchema(),
59-
});
60-
const channelsListDataStaging = useChannelsQueryStaging({
49+
const channelsListData = useChannelsQuery({
6150
displayLoader: true,
62-
skip: isMainSchema(),
6351
});
64-
const channelsListData = channelsListDataStaging ?? channelsListDataMain;
6552

6653
const [openModal, closeModal] = createDialogActionHandlers<
6754
ChannelUrlDialog,
6855
ChannelUrlQueryParams
6956
>(navigate, params => channelUrl(id, params), params);
7057

71-
const [updateChannelMain, updateChannelOptsMain] = useChannelUpdateMutation({
72-
onCompleted: ({ channelUpdate: { errors } }: ChannelUpdateMutation) =>
73-
notify(getDefaultNotifierSuccessErrorData(errors, intl)),
74-
});
75-
76-
const [updateChannelStaging, updateChannelOptsStaging] = useChannelUpdateMutationStaging({
58+
const [updateChannel, updateChannelOpts] = useChannelUpdateMutation({
7759
onCompleted: ({ channelUpdate: { errors } }: ChannelUpdateMutation) =>
7860
notify(getDefaultNotifierSuccessErrorData(errors, intl)),
7961
});
8062

81-
const { data: dataMain, loading: loadingMain } = useChannelQuery({
63+
const { data, loading } = useChannelQuery({
8264
displayLoader: true,
8365
variables: { id },
84-
skip: isStagingSchema(),
8566
});
8667

87-
const { data: dataStaging, loading: loadingStaging } = useChannelQueryStaging({
88-
displayLoader: true,
89-
variables: { id },
90-
skip: isMainSchema(),
91-
});
92-
93-
const data = dataStaging ?? dataMain;
94-
const loading = loadingMain ?? loadingStaging;
95-
const updateChannelOpts = isStagingSchema() ? updateChannelOptsStaging : updateChannelOptsMain;
96-
9768
const { reorderChannelWarehouses, reorderChannelWarehousesOpts } = useChannelWarehousesReorder();
9869

9970
const handleError = (error: ChannelErrorFragment) => {
@@ -175,64 +146,35 @@ const ChannelDetails = ({ id, params }: ChannelDetailsProps) => {
175146
automaticCompletionInput.cutOffDate = getCutOffDateTimeISO();
176147
}
177148

178-
const updateChannelMutation = isStagingSchema()
179-
? updateChannelStaging({
180-
variables: {
181-
id: data?.channel.id,
182-
input: {
183-
name,
184-
checkoutSettings: {
185-
automaticCompletion: automaticCompletionInput,
186-
allowLegacyGiftCardUse,
187-
},
188-
slug,
189-
defaultCountry,
190-
addShippingZones: shippingZonesIdsToAdd,
191-
removeShippingZones: shippingZonesIdsToRemove,
192-
addWarehouses: warehousesIdsToAdd,
193-
removeWarehouses: warehousesIdsToRemove,
194-
stockSettings: {
195-
allocationStrategy,
196-
},
197-
paymentSettings: {
198-
defaultTransactionFlowStrategy,
199-
},
200-
orderSettings: {
201-
markAsPaidStrategy,
202-
deleteExpiredOrdersAfter,
203-
allowUnpaidOrders,
204-
},
205-
},
149+
const updateChannelMutation = updateChannel({
150+
variables: {
151+
id: data?.channel.id,
152+
input: {
153+
name,
154+
checkoutSettings: {
155+
automaticCompletion: automaticCompletionInput,
156+
allowLegacyGiftCardUse,
206157
},
207-
})
208-
: updateChannelMain({
209-
variables: {
210-
id: data?.channel.id,
211-
input: {
212-
name,
213-
checkoutSettings: {
214-
automaticCompletion: automaticCompletionInput,
215-
},
216-
slug,
217-
defaultCountry,
218-
addShippingZones: shippingZonesIdsToAdd,
219-
removeShippingZones: shippingZonesIdsToRemove,
220-
addWarehouses: warehousesIdsToAdd,
221-
removeWarehouses: warehousesIdsToRemove,
222-
stockSettings: {
223-
allocationStrategy,
224-
},
225-
paymentSettings: {
226-
defaultTransactionFlowStrategy,
227-
},
228-
orderSettings: {
229-
markAsPaidStrategy,
230-
deleteExpiredOrdersAfter,
231-
allowUnpaidOrders,
232-
},
233-
},
158+
slug,
159+
defaultCountry,
160+
addShippingZones: shippingZonesIdsToAdd,
161+
removeShippingZones: shippingZonesIdsToRemove,
162+
addWarehouses: warehousesIdsToAdd,
163+
removeWarehouses: warehousesIdsToRemove,
164+
stockSettings: {
165+
allocationStrategy,
234166
},
235-
});
167+
paymentSettings: {
168+
defaultTransactionFlowStrategy,
169+
},
170+
orderSettings: {
171+
markAsPaidStrategy,
172+
deleteExpiredOrdersAfter,
173+
allowUnpaidOrders,
174+
},
175+
},
176+
},
177+
});
236178

237179
const resultChannel = await updateChannelMutation;
238180
const errors = await extractMutationErrors(updateChannelMutation);

src/siteSettings/components/SiteSettingsPage/SiteSettingsPage.tsx

Lines changed: 13 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,7 @@ const SiteSettingsPage = (props: SiteSettingsPageProps) => {
154154
onChange={change}
155155
/>
156156
</Box>
157-
158157
<Divider />
159-
160158
<Box
161159
display="grid"
162160
__gridTemplateColumns="1fr 3fr"
@@ -182,9 +180,7 @@ const SiteSettingsPage = (props: SiteSettingsPageProps) => {
182180
onCountryChange={handleCountrySelect}
183181
/>
184182
</Box>
185-
186183
<Divider />
187-
188184
<Box
189185
display="grid"
190186
__gridTemplateColumns="1fr 3fr"
@@ -212,28 +208,21 @@ const SiteSettingsPage = (props: SiteSettingsPageProps) => {
212208
</DashboardCard.Content>
213209
</DashboardCard>
214210
</Box>
215-
216-
{isStagingSchema() && (
217-
<>
218-
<Divider />
219-
220-
<Box
221-
display="grid"
222-
__gridTemplateColumns="1fr 3fr"
223-
paddingLeft={6}
224-
paddingBottom={8}
225-
>
226-
<PageSectionHeader
227-
title={intl.formatMessage(messages.sectionPasswordLoginTitle)}
228-
description={intl.formatMessage(messages.sectionPasswordLoginDescription)}
229-
/>
230-
<SitePasswordLoginCard value={data.passwordLoginMode} onChange={change} />
231-
</Box>
232-
</>
233-
)}
234-
235211
<Divider />
236212

213+
<Box
214+
display="grid"
215+
__gridTemplateColumns="1fr 3fr"
216+
paddingLeft={6}
217+
paddingBottom={8}
218+
>
219+
<PageSectionHeader
220+
title={intl.formatMessage(messages.sectionPasswordLoginTitle)}
221+
description={intl.formatMessage(messages.sectionPasswordLoginDescription)}
222+
/>
223+
<SitePasswordLoginCard value={data.passwordLoginMode} onChange={change} />
224+
</Box>
225+
<Divider />
237226
<Box
238227
display="grid"
239228
__gridTemplateColumns="1fr 3fr"
@@ -261,9 +250,7 @@ const SiteSettingsPage = (props: SiteSettingsPageProps) => {
261250
</DashboardCard.Content>
262251
</DashboardCard>
263252
</Box>
264-
265253
<Divider />
266-
267254
<Box
268255
display="grid"
269256
__gridTemplateColumns="1fr 3fr"

0 commit comments

Comments
 (0)