Merge branch 'main' and fix availability doctor copy pass

Author: mirekm

locale/defaultMessages.json

@@ -2847,7 +2847,7 @@
   },
   "EURyYW": {
     "context": "Reassurance under verification badge when product is purchasable in direct mode",
-    "string": "Storefront API confirms the product is purchasable. Stock availability is taken directly from the warehouse-channel link, regardless of shipping zones."
+    "string": "The public API confirms the product is purchasable. Stock availability is taken directly from the warehouse-channel link, regardless of shipping zones."
   },
   "EXqb2l": {
     "string": "Go to Saleor Cloud"
@@ -5954,7 +5954,7 @@
   },
   "VNXfqA": {
     "context": "Reassurance under verification badge when product is purchasable in legacy mode",
-    "string": "Storefront API confirms the product is purchasable for customers covered by the channel's shipping zones."
+    "string": "The public API confirms the product is purchasable for customers covered by the channel's shipping zones."
   },
   "VOiUXQ": {
     "string": "Used to calculate rates for shipping for products of this product type, when specific weight is not given"
@@ -6739,7 +6739,7 @@
   },
   "ZemrGW": {
     "context": "Reassurance under verification badge when product is not visible to public API",
-    "string": "The storefront API cannot find this product. Confirm it is published and listed in this channel."
+    "string": "The public API cannot find this product. Confirm it is published and listed in this channel."
   },
   "ZepEWY": {
     "context": "Dry run item",
@@ -10690,6 +10690,10 @@
     "context": "default product variant indicator",
     "string": "Default"
   },
+  "vZN+nE": {
+    "context": "Public API verification: API says product has stock, but no shipping zones cover the channel (legacy mode)",
+    "string": "Reports stock, but no coverage"
+  },
   "vaFjs6": {
     "string": "No warehouses available to add"
   },
@@ -10881,7 +10885,7 @@
   },
   "wPODVm": {
     "context": "Reassurance under verification badge when product is not purchasable",
-    "string": "The storefront API does not return this product as purchasable. Review the issues listed above to resolve."
+    "string": "The public API does not return this product as purchasable. Review the issues listed above to resolve."
   },
   "wQdR8M": {
     "string": "Add search engine title and description to make this category easier to find"
@@ -10914,6 +10918,10 @@
     "context": "Tooltip line showing local timestamp of a problem event",
     "string": "Local: {time}"
   },
+  "wawnP4": {
+    "context": "Reassurance under verification badge when API reports stock but the channel has no shipping zones in legacy mode",
+    "string": "The public API reports the product as in stock, but no shipping zones are configured for this channel — no customer is currently covered, so checkout cannot complete."
+  },
   "wbsq7O": {
     "string": "Usage"
   },

src/products/components/ProductDoctor/AvailabilityCard.test.tsx

@@ -294,6 +294,75 @@ describe("PublicApiVerificationBadge reassurance", () => {
     expect(reassurance).toHaveTextContent(/regardless of shipping zones/i);
   });
 
+  it("overrides the purchasable verdict when in legacy mode and the channel has no shipping zones", () => {
+    // Arrange — API reports stock + isAvailable, but the channel's
+    // shippingZoneCount is 0. In legacy mode this means no customer is
+    // reachable, so the green "Purchasable" badge would be misleading.
+    const result = makeVerification({ isAvailable: true, variantsWithStock: 2 });
+
+    // Act
+    render(
+      <PublicApiVerificationBadge
+        result={result}
+        useLegacyShippingZoneStockAvailability={true}
+        shippingZoneCount={0}
+      />,
+      { wrapper: Wrapper },
+    );
+
+    // Assert — the badge is downgraded to a coverage-aware warning.
+    const reassurance = screen.getByTestId("verification-reassurance");
+
+    expect(reassurance).toHaveAttribute("data-test-reassurance", "not-reachable-legacy");
+    expect(reassurance).toHaveTextContent(/no shipping zones/i);
+    expect(reassurance).toHaveTextContent(/checkout cannot complete/i);
+    // The "Purchasable" headline must NOT be shown — that's the whole point
+    // of the override.
+    expect(screen.queryByText(/^Purchasable$/i)).toBeNull();
+    expect(screen.getByText(/reports stock, but no coverage/i)).toBeInTheDocument();
+  });
+
+  it("keeps the standard purchasable badge when the channel has shipping zones in legacy mode", () => {
+    // Arrange — same API result, but channel has at least one shipping zone.
+    const result = makeVerification({ isAvailable: true, variantsWithStock: 2 });
+
+    // Act
+    render(
+      <PublicApiVerificationBadge
+        result={result}
+        useLegacyShippingZoneStockAvailability={true}
+        shippingZoneCount={1}
+      />,
+      { wrapper: Wrapper },
+    );
+
+    // Assert — standard "Purchasable" reassurance is shown.
+    const reassurance = screen.getByTestId("verification-reassurance");
+
+    expect(reassurance).toHaveAttribute("data-test-reassurance", "purchasable-legacy");
+  });
+
+  it("does not downgrade the badge in direct mode even when there are no shipping zones", () => {
+    // Arrange — direct mode does not gate on shipping zones, so a missing
+    // shipping zone is only an info advisory, not a blocker.
+    const result = makeVerification({ isAvailable: true, variantsWithStock: 2 });
+
+    // Act
+    render(
+      <PublicApiVerificationBadge
+        result={result}
+        useLegacyShippingZoneStockAvailability={false}
+        shippingZoneCount={0}
+      />,
+      { wrapper: Wrapper },
+    );
+
+    // Assert — direct-mode reassurance is preserved.
+    const reassurance = screen.getByTestId("verification-reassurance");
+
+    expect(reassurance).toHaveAttribute("data-test-reassurance", "purchasable-direct");
+  });
+
   it("points to the issue list when verification reports not purchasable", () => {
     // Arrange
     const result = makeVerification({ isAvailable: false, variantsWithStock: 0 });

src/products/components/ProductDoctor/AvailabilityCard.tsx

@@ -479,11 +479,18 @@ interface PublicApiVerificationBadgeProps {
   /** Active stock-availability mode. Drives the reassurance line so users know
    *  what was just verified given the shop's mode. Defaults to legacy. */
   useLegacyShippingZoneStockAvailability?: boolean;
+  /** Number of shipping zones configured for the channel. In legacy mode, a
+   *  channel with zero shipping zones cannot deliver to any customer, so a
+   *  "purchasable" verdict from the public API is misleading — we override it
+   *  with a coverage-aware warning. Optional for backwards compatibility; when
+   *  undefined we fall back to the API-reported verdict. */
+  shippingZoneCount?: number;
 }
 
 export const PublicApiVerificationBadge = ({
   result,
   useLegacyShippingZoneStockAvailability = true,
+  shippingZoneCount,
 }: PublicApiVerificationBadgeProps) => {
   const intl = useIntl();
 
@@ -530,6 +537,26 @@ export const PublicApiVerificationBadge = ({
   }
 
   if (isAvailable && variantsWithStock > 0) {
+    // In legacy mode, "isAvailable" is computed from raw warehouse stock and
+    // does not gate on shipping zones — so the public API can report stock
+    // even when no shipping zone covers the channel and no customer can
+    // actually complete checkout. Surface that gap explicitly instead of
+    // showing a misleading green "Purchasable" badge.
+    if (useLegacyShippingZoneStockAvailability && shippingZoneCount === 0) {
+      return (
+        <PublicApiVerificationBadgeShell
+          icon={<XCircle size={14} color="var(--mu-colors-text-warning1)" />}
+          statusColor="warning1"
+          status={intl.formatMessage(messages.publicApiReportsStockNoCoverage)}
+          statusSuffix={intl.formatMessage(messages.publicApiVariantsInStock, {
+            count: variantsWithStock,
+          })}
+          reassurance={intl.formatMessage(messages.verificationReassurance_notReachableLegacy)}
+          reassuranceTestId="not-reachable-legacy"
+        />
+      );
+    }
+
     return (
       <PublicApiVerificationBadgeShell
         icon={<CheckCircle size={14} color="var(--mu-colors-text-success1)" />}

src/products/components/ProductDoctor/AvailabilityChannelItem.tsx

@@ -314,6 +314,7 @@ export const AvailabilityChannelItem = ({
             verificationResult={verificationResult}
             onVerify={onVerify}
             useLegacyShippingZoneStockAvailability={useLegacyShippingZoneStockAvailability}
+            shippingZoneCount={summary.shippingZoneCount}
           />
         </Box>
       </Accordion.Content>
@@ -361,6 +362,11 @@ interface PublicApiVerificationSectionProps {
   verificationResult?: ChannelVerificationResult;
   onVerify?: () => void;
   useLegacyShippingZoneStockAvailability: boolean;
+  /** Number of shipping zones for the channel — drives the coverage-aware
+   *  override of the "Purchasable" badge in legacy mode. May be "unknown"
+   *  when the dashboard user lacks the permission to read shipping zones,
+   *  in which case we do not downgrade the verdict. */
+  shippingZoneCount: number | "unknown";
 }
 
 const VERIFICATION_COOLDOWN_MS = 1500;
@@ -369,6 +375,7 @@ const PublicApiVerificationSection = ({
   verificationResult,
   onVerify,
   useLegacyShippingZoneStockAvailability,
+  shippingZoneCount,
 }: PublicApiVerificationSectionProps) => {
   const intl = useIntl();
   const isVerifying = verificationResult?.status === "loading";
@@ -431,6 +438,12 @@ const PublicApiVerificationSection = ({
         <PublicApiVerificationBadge
           result={verificationResult}
           useLegacyShippingZoneStockAvailability={useLegacyShippingZoneStockAvailability}
+          shippingZoneCount={
+            // Forward the count only when we actually know it. Passing
+            // undefined for "unknown" keeps the API-reported verdict
+            // intact rather than misleading users with limited permissions.
+            shippingZoneCount === "unknown" ? undefined : shippingZoneCount
+          }
         />
       )}
     </Box>

src/products/components/ProductDoctor/messages.ts

@@ -285,6 +285,12 @@ export const messages = defineMessages({
     defaultMessage: "Not visible",
     description: "Product is not visible via public API",
   },
+  publicApiReportsStockNoCoverage: {
+    id: "vZN+nE",
+    defaultMessage: "Reports stock, but no coverage",
+    description:
+      "Public API verification: API says product has stock, but no shipping zones cover the channel (legacy mode)",
+  },
   publicApiVariantsInStock: {
     id: "7G7tg3",
     defaultMessage: "{count, plural, one {# variant in stock} other {# variants in stock}}",
@@ -312,32 +318,39 @@ export const messages = defineMessages({
   },
 
   // Mode-aware reassurance shown beneath the verification badge after a run.
-  // Tells the user what the storefront-API result means for the shop's active
+  // Tells the user what the public-API result means for the shop's active
   // stock-availability mode (Saleor 3.23+).
   verificationReassurance_purchasableLegacy: {
-    id: "VNXfqA",
+    id: "QEXGYB",
     defaultMessage:
-      "Storefront API confirms the product is purchasable for customers covered by the channel's shipping zones.",
+      "The public API confirms the product is purchasable for customers covered by the channel's shipping zones.",
     description: "Reassurance under verification badge when product is purchasable in legacy mode",
   },
   verificationReassurance_purchasableDirect: {
-    id: "EURyYW",
+    id: "uL33aH",
     defaultMessage:
-      "Storefront API confirms the product is purchasable. Stock availability is taken directly from the warehouse-channel link, regardless of shipping zones.",
+      "The public API confirms the product is purchasable. Stock availability is taken directly from the warehouse-channel link, regardless of shipping zones.",
     description: "Reassurance under verification badge when product is purchasable in direct mode",
   },
   verificationReassurance_notPurchasable: {
-    id: "wPODVm",
+    id: "UuX9YV",
     defaultMessage:
-      "The storefront API does not return this product as purchasable. Review the issues listed above to resolve.",
+      "The public API does not return this product as purchasable. Review the issues listed above to resolve.",
     description: "Reassurance under verification badge when product is not purchasable",
   },
   verificationReassurance_notVisible: {
-    id: "ZemrGW",
+    id: "tFx7UX",
     defaultMessage:
-      "The storefront API cannot find this product. Confirm it is published and listed in this channel.",
+      "The public API cannot find this product. Confirm it is published and listed in this channel.",
     description: "Reassurance under verification badge when product is not visible to public API",
   },
+  verificationReassurance_notReachableLegacy: {
+    id: "AFZfCS",
+    defaultMessage:
+      "The public API reports the product as in stock, but no shipping zones are configured for this channel — no customer is currently covered, so checkout cannot complete.",
+    description:
+      "Reassurance under verification badge when API reports stock but the channel has no shipping zones in legacy mode",
+  },
   testButton: {
     defaultMessage: "Test",
     id: "YpnjMB",