Skip to content

Commit fc8bcbd

Browse files
authored
fix(build): missing environment variable
`ENVIRONMENT` env var was missing which caused to upload using s3 to `s3://bucket//<dist-files>` where the `//` should have been `/<env>/`
1 parent 3dd76e2 commit fc8bcbd

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

.github/workflows/deploy-cloud.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,10 @@ jobs:
134134
env:
135135
DEPLOYMENT_BUCKET: ${{ secrets.AWS_CLOUD_EU_DEPLOYMENT_BUCKET }}
136136
CDN_DISTRIBUTIONS: ${{ secrets.AWS_CLOUD_EU_CDN_DISTRIBUTIONS }}
137+
ENVIRONMENT: ${{ needs.build.outputs.ENVIRONMENT }}
137138
run: |
139+
set -eu
140+
138141
aws s3 sync build/dashboard "s3://${DEPLOYMENT_BUCKET}/${ENVIRONMENT}/static/"
139142
aws s3 cp build/dashboard/index.html "s3://${DEPLOYMENT_BUCKET}/${ENVIRONMENT}/"
140143
@@ -149,7 +152,10 @@ jobs:
149152
env:
150153
DEPLOYMENT_BUCKET: ${{ secrets.AWS_CLOUD_US_DEPLOYMENT_BUCKET }}
151154
CDN_DISTRIBUTIONS: ${{ secrets.AWS_CLOUD_US_CDN_DISTRIBUTIONS }}
155+
ENVIRONMENT: ${{ needs.build.outputs.ENVIRONMENT }}
152156
run: |
157+
set -eu
158+
153159
aws s3 sync build/dashboard "s3://${DEPLOYMENT_BUCKET}/${ENVIRONMENT}/static/"
154160
aws s3 cp build/dashboard/index.html "s3://${DEPLOYMENT_BUCKET}/${ENVIRONMENT}/"
155161

0 commit comments

Comments
 (0)