Skip to content

Add Listener for Configurable Alert Timeout #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cvillarongace
Copy link

@cvillarongace cvillarongace commented Nov 22, 2024

Description

This PR introduces a new feature to dynamically update the alert timeout based on configuration changes. The feature enhances the reactivity of the MessageService by subscribing to changes in the configuration observable stream, specifically monitoring the alert_timeout property in the UI configuration.

Motivation and Context

The motivation for this change stems from a timing issue where the configuration was being loaded before the user-defined settings were properly applied. This resulted in the alert_timeout value defaulting to 3 seconds, regardless of the value specified in extensions or user settings. By introducing a listener for configuration changes, this update ensures that the alert timeout dynamically reflects the correct value as configured by the user, improving alignment between the application behavior and user expectations.

Benefits:

  • Dynamic Updates: Alert timeout adjusts automatically based on configuration changes.
  • Improved UX: Allows for more flexible and responsive user interface customization.
  • Efficiency: Avoids unnecessary updates using distinctUntilChanged.

Notes:

-This change is backward-compatible. If no alert_timeout is specified, the default value remains intact.
-Documentation for this enhancement has been included in the method comments.

How To Test This

  • Verified that MessageService reacts to changes in SystemConfigStore.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • [ x] My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • [ x] I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented Nov 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@desarrollador20 desarrollador20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code works correctly

@shubham-pawar
Copy link

@cvillarongace , Please sign the CLA - Contributor License Agreement, so maintainer could merge your code.

@cvillarongace
Copy link
Author

It already appears signed, I don't know what else I should do...
Screenshot 2025-01-13 at 1 01 30 PM

@mattlorimer
Copy link
Member

Carlos Villaronga seems not to be a GitHub user.

It looks like the details used on the commit are not linked to your github profile, sometimes this can be solved by adding the email address used for the commit as an additional email address on your github profile

@shubham-pawar
Copy link

@cvillarongace Hello,

As Matt said, you'll need to use the email you use to commit this code. You can add it as an additional email address.

@cvillarongace
Copy link
Author

Ok, I've added both addresses to my Github profile, but it doesn't seem to change anything. Is there anything else I can try?

@shubham-pawar
Copy link

@cvillarongace Now try to sign CLA again and submit.

@shubham-pawar
Copy link

@cvillarongace If the commit was made with a different email (e.g., a different account or an email that was not linked to GitHub), the user can amend the commit with the correct email address

  • Rebase or amend the commit using the following commands:

git commit --amend --author="Your Name <[email protected]>"

git push --force


  • Check for Email Privacy Settings

If the user uses GitHub’s "Keep my email address private" option, they may have to ensure that the email address they committed with is a verified email under their GitHub profile. If it was a private email, the CLA bot might not be able to link the commit to the profile correctly.

@cvillarongace cvillarongace force-pushed the feature/configurable-alert-timeout branch from 93baa5b to d83d186 Compare January 14, 2025 17:57
@shubham-pawar
Copy link

@cvillarongace Thank you 💯 looks like CLA is signed 👍

@shubham-pawar
Copy link

@mattlorimer Contributor License Agreement(CLA) is signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants