-
-
Notifications
You must be signed in to change notification settings - Fork 154
Add Listener for Configurable Alert Timeout #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add Listener for Configurable Alert Timeout #573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code works correctly
@cvillarongace , Please sign the CLA - Contributor License Agreement, so maintainer could merge your code. |
It looks like the details used on the commit are not linked to your github profile, sometimes this can be solved by adding the email address used for the commit as an additional email address on your github profile |
@cvillarongace Hello, As Matt said, you'll need to use the email you use to commit this code. You can add it as an additional email address. |
Ok, I've added both addresses to my Github profile, but it doesn't seem to change anything. Is there anything else I can try? |
@cvillarongace Now try to sign CLA again and submit. |
@cvillarongace If the commit was made with a different email (e.g., a different account or an email that was not linked to GitHub), the user can amend the commit with the correct email address
|
93baa5b
to
d83d186
Compare
@cvillarongace Thank you 💯 looks like CLA is signed 👍 |
@mattlorimer Contributor License Agreement(CLA) is signed. |
Description
This PR introduces a new feature to dynamically update the alert timeout based on configuration changes. The feature enhances the reactivity of the MessageService by subscribing to changes in the configuration observable stream, specifically monitoring the alert_timeout property in the UI configuration.
Motivation and Context
The motivation for this change stems from a timing issue where the configuration was being loaded before the user-defined settings were properly applied. This resulted in the alert_timeout value defaulting to 3 seconds, regardless of the value specified in extensions or user settings. By introducing a listener for configuration changes, this update ensures that the alert timeout dynamically reflects the correct value as configured by the user, improving alignment between the application behavior and user expectations.
Benefits:
Notes:
-This change is backward-compatible. If no alert_timeout is specified, the default value remains intact.
-Documentation for this enhancement has been included in the method comments.
How To Test This
Types of changes
Final checklist