Fix #613 - Fixed Error Occurring If First Report Field Is a Custom Field

[MaxSprea]

Description

Lines 1245 to 1247 of AOR_Report.php were in the wrong order causing the first iteration of the loop to return an empty $data array which in turn caused the generated query to fail if a custom field was used as the first field:

$data = $field_module->field_defs[$field->field] ?? [];

$field_module = $module;

I simply inverted the lines and can confirm that reports work properly after applying the fix

$field_module = $module;

$data = $field_module->field_defs[$field->field] ?? [];

Motivation and Context

This fix is necessary to correctly manage custom fields when used as first field of a report

How To Test This

Create a report using a custom field as the first field of the report

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
• I have read the How to Contribute guidelines.

[SuiteBot]

All committers have signed the CLA.

[mattlorimer]

this should really be below the foreach statement on approx line 1268 as the field_module may change