Fix theme display issues

Header and footer clean up
Action menu dropdown
List view buttons

Author: mattlorimer

include/MVC/View/SugarView.php

@@ -1261,7 +1261,7 @@ private function _getStatistics()
             number_format(round($deltaTime, 2), 2) .
             ' ' .
             $GLOBALS['app_strings']['LBL_SERVER_RESPONSE_TIME_SECONDS'];
-        $return = $response_time_string;
+        $return = $response_time_string. '<br />';
 
         if (!empty($GLOBALS['sugar_config']['show_page_resources'])) {
             // Print out the resources used in constructing the page.

themes/SuiteP/css/suitep-base/editview.scss

@@ -297,13 +297,13 @@ a#powered_by:hover {
 #copyright_data {
   padding-left: 1%;
   display: inline-block;
+  vertical-align: top;
 }
 
 .footer_right {
   padding-right: 1%;
   float: right;
   text-align: right;
-  width: 47%;
   text-transform: uppercase;
 }
 
@@ -4010,7 +4010,6 @@ select#sales_stage_advanced {
   padding: 0;
   padding-left: 20px;
   margin: 0;
-  width: 250px;
   display: inline-block;
 }
 
@@ -4969,11 +4968,9 @@ object {
 
   }
 
-  .detail table
-  table.detail {
+  .detail table table.detail {
     font-size: 1em;
     background: none;
-
   }
 
   .edit h4 {
@@ -5061,12 +5058,8 @@ object {
 }
 
 @media (max-width: 750px) {
-  .footer_left {
-    text-align: center;
-    width: 100%;
-  }
-
-  .footer_right {
+  .footer_left, .footer_right, .serverstats {
+    padding: 0;
     text-align: center;
     width: 100%;
   }

themes/SuiteP/css/suitep-base/listview.scss

@@ -1965,6 +1965,11 @@ ul.clickMenu.selectmenu.SugarActionMenu.listViewLinkButton > li.desktopOnly > a.
     padding: 6px;
   }
 
+  ul.clickMenu.selectmenu.SugarActionMenu.listViewLinkButton > li > a.glyphicon-list-alt {
+    left: 2px;
+    height: 24px;
+  }
+
 }
 
 /* search form (and popup search form) */
@@ -2762,7 +2767,6 @@ listViewLinkButton {
 #actionLinkTop li.sugar_action_button,
 #actionLinkBottom li.sugar_action_button {
   min-width: 32px;
-  height: 31px;
 }
 
 .action-link-top li.sugar_action_button,

themes/SuiteP/css/suitep-base/navbar.scss

@@ -66,7 +66,7 @@
   }
 
   .with-home-icon .suitepicon-action-home {
-    line-height: $navbar-toolbar-height;
+    line-height: $navbar-toolbar-height - 5px;
   }
 
   .dropdown-menu > li > a {

themes/SuiteP/css/suitep-base/sidebar.scss

@@ -270,7 +270,6 @@ footer {
   bottom: 0;
   background-color: $footer-btn-bg;
   margin: 0 0 0 0;
-  border: 1px solid transparent;
   border-radius: $border-radius-base;
   line-height: 38px;
   width: 100%;

themes/SuiteP/css/suitep-base/tabs.scss

@@ -141,7 +141,6 @@
     color: $action-tab-color;
     cursor: pointer;
     border-color: $action-tab-bg;
-    border-bottom: $action-tab-separator;
   }
 
   #tab-actions > a .suitepicon-action-caret {

themes/SuiteP/tpls/footer.tpl

@@ -5,7 +5,7 @@
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
  *
  * SuiteCRM is an extension to SugarCRM Community Edition developed by SalesAgility Ltd.
- * Copyright (C) 2011 - 2018 SalesAgility Ltd.
+ * Copyright (C) 2011 - 2020 SalesAgility Ltd.
  *
  * This program is free software; you can redistribute it and/or modify it under
  * the terms of the GNU Affero General Public License version 3 as published by the
@@ -45,28 +45,28 @@
 {if $AUTHENTICATED}
     <!-- Start generic footer -->
     <footer>
-	{if $STATISTICS}
-		<div class="serverstats">
-            <span class="glyphicon glyphicon-globe"></span> {$STATISTICS}
-        </div>
-	{/if}
-        <div id="copyright_data">
-            <div id="dialog2" title="{$APP.LBL_SUITE_SUPERCHARGED}">
+        <div id="copyright_data" class="footer_left">
+            <div id="dialog2" title="{$APP.LBL_SUITE_SUPERCHARGED}" style="display: none">
                 <p>{$APP.LBL_SUITE_DESC1}</p>
                 <br>
                 <p>{$APP.LBL_SUITE_DESC2}</p>
                 <br>
                 <p>{$APP.LBL_SUITE_DESC3}</p>
                 <br>
             </div>
-            <div id="dialog" title="&copy; {$APP.LBL_SUITE_POWERED_BY}">
+            <div id="dialog" title="&copy; {$APP.LBL_SUITE_POWERED_BY}" style="display: none">
                 <p>{$COPYRIGHT}</p>
             </div>
-            <div id="copyrightbuttons" class="footer_left">
+            <div id="copyrightbuttons">
                 <a id="admin_options">&copy; {$APP.LBL_SUITE_SUPERCHARGED}</a>
                 <a id="powered_by">&copy; {$APP.LBL_SUITE_POWERED_BY}</a>
             </div>
         </div>
+        {if $STATISTICS}
+        <div class="serverstats">
+            <span class="glyphicon glyphicon-globe"></span> {$STATISTICS}
+        </div>
+        {/if}
     	<div class="footer_right">
 
     		<a onclick="SUGAR.util.top();" href="javascript:void(0)">{$APP.LBL_SUITE_TOP}<span class="suitepicon suitepicon-action-above"></span> </a>

themes/SuiteP/tpls/header.tpl

@@ -47,8 +47,6 @@
     </div>
 {/if}
 {literal}
-    <iframe id='ajaxUI-history-iframe' src='index.php?entryPoint=getImage&imageName=blank.png' title='empty'
-            style='display:none'></iframe>
 <input id='ajaxUI-history-field' type='hidden'>
 <script type='text/javascript'>
     if (SUGAR.ajaxUI && !SUGAR.ajaxUI.hist_loaded) {