Skip to content

FIX #9344 Error in Browsers console after adding tabs to Quickcreate: function selectTabOnError #9813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2022
Merged

FIX #9344 Error in Browsers console after adding tabs to Quickcreate: function selectTabOnError #9813

merged 1 commit into from
Dec 22, 2022

Conversation

lukio
Copy link
Contributor

@lukio lukio commented Nov 10, 2022 •
edited
Loading

FIX #9344

Found that the name of the function selectTabOnError has been declared twice at the theme SuiteP

If I change the definition of the function from let to var it does not throws the error on the javascript console.

Motivation and Context

When create a new record with quickcreate view form subpanel it throws an error console of javascript.

How To Test This

  1. Add a panel in the QuickCreate view of the Accounts module
  2. After saving the view, change the "Panel" to "Tab" configuration
  3. Go to the Quickcreateview of Accounts (Inside an Account, the Member Organization subpanel)
  4. Open the browser console and see the error

140304087-7036bd05-be6a-43aa-8532-1ed8caf11706

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@lukio
FIX salesagility#9344 Error in Browsers console after adding tabs to …
dc4799f 
…Quickcreate: selectTabOnError

Found that the name of the function selectTabOnError has been declared
twice at the theme SuiteP

If I change the definition of the function from let to var it does
not throws the error on the javascript console.
@lukio lukio added Status: Requires Code Review Needs the core team to code review Branch:Hotfix labels Nov 10, 2022
@lukio lukio mentioned this pull request Nov 10, 2022
Open
@lukio lukio added Status: Requires Code Review Needs the core team to code review and removed Status: Requires Code Review Needs the core team to code review labels Nov 10, 2022
@lukio
Copy link
Contributor Author

lukio commented Dec 16, 2022

Hi @mattlorimer ! Let me know if it needs something else to be merged! thanks!

mattlorimer
mattlorimer approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@mattlorimer mattlorimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

@mattlorimer mattlorimer merged commit ba20ee5 into salesagility:hotfix Dec 22, 2022
@mattlorimer mattlorimer removed the Status: Requires Code Review Needs the core team to code review label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlorimer mattlorimer mattlorimer approved these changes

Assignees
No one assigned
Labels
Branch:Hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in Browsers console after adding tabs to Quickcreate
2 participants
@lukio @mattlorimer