Skip to content

Fix duration displayed in edit view #9989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

QuickCRM
Copy link
Contributor

Fix #9986

Description

Create a call with a 15 mn duration
Save that call
Edit that call again
The duration is displayed as 0

This is due to get_select_options_with_id in SuiteCRM 7.12 being more strict when comparing keys to select current value.

Replaced
$html .= get_select_options_with_id($focus->minutes_values, $focus->duration_minutes);
by
$html .= get_select_options_with_id($focus->minutes_values, (int)$focus->duration_minutes);

Motivation and Context

Duration is lost when editing an existing call

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SuiteBot
Copy link

This pull request has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/call-duration-is-not-displayed-correctly-in-edit-view/88458/2

Copy link

@tstanczyk tstanczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved the issue for us.

@jack7anderson7 jack7anderson7 added the Area:Calls Issues & PRs related to all things regarding to the Accounts Module label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Calls Issues & PRs related to all things regarding to the Accounts Module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duration of call is not displayed correctly in edit view
4 participants