Fix duration displayed in edit view #9989
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9986
Description
Create a call with a 15 mn duration
Save that call
Edit that call again
The duration is displayed as 0
This is due to get_select_options_with_id in SuiteCRM 7.12 being more strict when comparing keys to select current value.
Replaced
$html .= get_select_options_with_id($focus->minutes_values, $focus->duration_minutes);
by
$html .= get_select_options_with_id($focus->minutes_values, (int)$focus->duration_minutes);
Motivation and Context
Duration is lost when editing an existing call
How To Test This
Types of changes
Final checklist