Skip to content

Fix #10113 - Contracts / List Items table for services has bogus width #10601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattlorimer merged 1 commit into from
May 29, 2025
Merged

Fix #10113 - Contracts / List Items table for services has bogus width #10601

mattlorimer merged 1 commit into from
May 29, 2025

Conversation

@abuzarfaris
Copy link
Contributor

@abuzarfaris abuzarfaris commented Dec 24, 2024 •
edited
Loading

Description

To recreate the issue create a contract with only service Items

Motivation and Context

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

mattlorimer
mattlorimer approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@mattlorimer mattlorimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@mattlorimer mattlorimer added Status: Passed Code Review Mark issue has passed code review reviewed PR 1-3 Complexity Score given to PRs once assessed labels Jan 24, 2025
johnM2401
johnM2401 approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Line Item group no longer cramped when using only Service line items.

@mattlorimer mattlorimer merged commit a38f1e1 into SuiteCRM:hotfix May 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattlorimer mattlorimer mattlorimer approved these changes

@johnM2401 johnM2401 johnM2401 approved these changes

Assignees

No one assigned

Labels

PR 1-3 Complexity Score given to PRs once assessed Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abuzarfaris @mattlorimer @johnM2401