Skip to content

Commit f030110

Browse files
authored
fix(tabs): display focus ring on tabs when slds-has-focus (#5347)
* fix(tabs): display focus ring on tabs when slds-has-focus * docs: add release notes
1 parent 903f22b commit f030110

File tree

5 files changed

+28
-3
lines changed

5 files changed

+28
-3
lines changed

RELEASENOTES.general.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
<!-- Release notes authoring guidelines: http://keepachangelog.com/ -->
22
<!-- On release, add general notes here. In time the legacy release notes will be add to this -->
33

4+
## 2.24.4 - Jun 13, 2024
5+
6+
## Updated
7+
8+
- Updated focus ring color for links to blue-40.
9+
10+
411
## 2.24.3 - Jun 6, 2024
512

613
## Updated

RELEASENOTES.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,16 @@
11
<!-- Release notes authoring guidelines: http://keepachangelog.com/ -->
22
<!-- !!! THIS FILE IS AUTO-GENERATED !!! DO NOT EDIT THIS FILE MANUALLY !!! -->
33

4+
## Release 2.24.4 - Jun 13, 2024
5+
6+
## Updated
7+
- Updated focus ring color for links to blue-40.
8+
9+
## Components
10+
### [Tabs](https://www.lightningdesignsystem.com/components/tabs)
11+
## Fixed
12+
- Added new focus style for tabs when `.slds-has-focus` class is getting added.
13+
414
## Release 2.24.3 - Jun 6, 2024
515

616
## Updated

ui/components/tabs/RELEASENOTES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.24.4
8+
9+
## Fixed
10+
11+
- Added new focus style for tabs when `.slds-has-focus` class is getting added.
12+
713
## 2.23.0
814

915
## Added

ui/components/tabs/base/_index.scss

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,14 +113,16 @@
113113
*/
114114
&:focus,
115115
&.slds-has-focus {
116-
outline: 0;
117-
118116
&:after {
119117
height: calc(var(--slds-c-tabs-list-sizing-border, var(--sds-c-tabs-list-sizing-border, #{$border-width-thick})) + 1px);
120118
background-color: var(--slds-c-tabs-item-color-border-active, var(--sds-c-tabs-item-color-border-active, $brand-primary));
121119
}
122120
}
123121

122+
&:focus {
123+
outline: 0;
124+
}
125+
124126
// Remove box-shadow when slds-button is used in conjunction with class
125127
.slds-tabs_default__link:focus,
126128
.slds-tabs--default__link:focus {

ui/dependencies/_core.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
}
9898

9999
&:focus-visible {
100-
outline-color: var(--slds-g-color-palette-blue-50, #{$palette-blue-50});
100+
outline-color: var(--slds-g-color-palette-blue-40, #{$palette-blue-40});
101101
}
102102
}
103103

0 commit comments

Comments
 (0)