add missing tests (#505)

Author: gruebel

examples/files/accounts.yaml

@@ -0,0 +1,4 @@
+accounts:
+  default_account: 123456789012
+  prod: 123456789013
+  test: 123456789014

pyproject.toml

@@ -49,6 +49,7 @@ Twitter = "https://twitter.com/kmcquade3"
 dev = [
     "boto3-stubs-lite[iam,s3,sts]>=1.40.0,<2.0.0",
     "coverage>=7.11.0,<8.0.0",
+    "moto[sts]>=5.1.0,<6.0.0",
     "mypy>=1.18.0,<2.0.0",
     "prek>=0.2.13,<0.3.0",
     "pytest>=8.4.0,<9.0.0",

test/command/test_scan_multi_account.py

@@ -0,0 +1,37 @@
+import shutil
+import tempfile
+import unittest
+from pathlib import Path
+
+from click.testing import CliRunner
+from moto import mock_aws
+
+from cloudsplaining.command.scan_multi_account import scan_multi_account
+
+
+class ScanClickUnitTests(unittest.TestCase):
+    def setUp(self):
+        self.runner = CliRunner()
+        self.temp_dir = tempfile.mkdtemp()
+
+    def tearDown(self):
+        shutil.rmtree(self.temp_dir)
+
+    @mock_aws
+    def test_scan_example_file_with_click(self):
+        # given
+        examples_directory = Path(__file__).parents[2] / "examples"
+        config_file = examples_directory / "files/accounts.yaml"
+
+        args = ["--config", config_file, "--role-name", "example-role", "--output-directory", self.temp_dir, "-v"]
+
+        # when
+        response = self.runner.invoke(cli=scan_multi_account, args=args)
+
+        # then
+        self.assertTrue(response.exit_code == 0)
+
+        # 3 accounts -> 3 reports
+        self.assertEqual(len(list(Path(self.temp_dir).glob("*.html"))), 3)
+        self.assertEqual(response.output.count("Scanning account"), 3)
+        self.assertEqual(response.output.count("Saved the HTML report to"), 3)

test/shared/test_aws_login.py

@@ -0,0 +1,79 @@
+import boto3
+from moto import mock_aws
+
+from cloudsplaining.shared.aws_login import (
+    get_current_account_id,
+    get_available_regions,
+    get_target_account_credentials,
+    get_boto3_client,
+    get_boto3_resource,
+)
+
+
+@mock_aws
+def test_get_boto3_client():
+    # given
+    service = "sts"
+    region = "eu-central-1"
+
+    # when
+    client = get_boto3_client(service=service, region=region)
+
+    # then
+    assert client  # just make sure it doesn't raise an exception
+
+
+@mock_aws
+def test_get_boto3_resource():
+    # given
+    service = "s3"
+    region = "eu-central-1"
+
+    # when
+    resource = get_boto3_resource(service=service, region=region)
+
+    # then
+    assert resource  # just make sure it doesn't raise an exception
+
+
+@mock_aws
+def test_get_current_account_id():
+    # given
+    client = boto3.client("sts")
+
+    # when
+    account_id = get_current_account_id(client)
+
+    # then
+    assert account_id  # make sure it is not empty
+
+
+@mock_aws
+def test_get_available_regions():
+    # given
+    service = "s3"
+
+    # when
+    regions = get_available_regions(service)
+
+    # then
+    assert len(regions) >= 30
+
+
+@mock_aws
+def test_get_target_account_credentialscredentials():
+    # given
+    role_name = "example-role"
+    account_id = "111111111111"
+
+    # when
+    creds = get_target_account_credentials(
+        target_account_role_name=role_name,
+        target_account_id=account_id,
+    )
+
+    # then
+    assert len(creds) == 3
+    assert creds[0]  # make sure it is not empty
+    assert creds[1]  # make sure it is not empty
+    assert creds[2]  # make sure it is not empty