Skip to content

Commit 880ef4a

Browse files
committed
updated readme and java docs
1 parent b83f53a commit 880ef4a

File tree

3 files changed

+13
-14
lines changed

3 files changed

+13
-14
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ Before you run the integration tests (locally):
309309
1. Run integration tests by running
310310

311311
```
312-
make itest-local-changes
312+
make integration-test
313313
```
314314

315315
### Release Process

dockerfile-image-update/src/main/java/com/salesforce/dockerfileimageupdate/utils/RateLimit.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,17 +44,17 @@ public RateLimit() {
4444
}
4545

4646
/**
47-
* This method will accept an input string in format <integer>-<ISO-8601_formatted_time> and
47+
* This method will accept an input string in format &lt;integer&gt;-&lt;ISO-8601_formatted_time&gt; and
4848
* will tokenize it to create a RateLimit object.
4949
* <pre>
5050
* Examples of tokenization
51-
* input : 500-PT1S -> {rate : 500, duration 1 second (PT1S), token adding rate: every .002 seconds (PT0.002S)}
52-
* 60-PT1M -> {rate : 60, duration 1 minute (PT1M), token adding rate: every 1 seconds (PT1S)}
51+
* input : 500-PT1S means {rate : 500, duration 1 second (PT1S), token adding rate: every .002 seconds (PT0.002S)}
52+
* 60-PT1M means {rate : 60, duration 1 minute (PT1M), token adding rate: every 1 seconds (PT1S)}
5353
* </pre>
5454
*
55-
* @param input string in format <integer>-<ISO-8601 formatted_time]> example 500-PT1S , 500-PT60S , 500-PT1H
55+
* @param input string in format &lt;integer&gt;-&lt;ISO-8601_formatted_time&gt; example 500-PT1S , 500-PT60S , 500-PT1H
5656
* @return RateLimit based on the input value
57-
* @throws UnknownFormatConversionException if input is not a string with expected format <integer>-<ISO-8601_formatted_time>
57+
* @throws UnknownFormatConversionException if input is not a string with expected format &lt;integer&gt;-&lt;ISO-8601_formatted_time&gt;
5858
*/
5959
public static RateLimit tokenizeAndGetRateLimit(String input) throws UnknownFormatConversionException {
6060
if (StringUtils.isEmpty(input) || !input.contains("-")) {

dockerfile-image-update/src/main/java/com/salesforce/dockerfileimageupdate/utils/RateLimiter.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
* time, the number of tokens in the bucket won't exceed the 'rateLimit', limiting the rate at
2222
* which PRs would be raised. To keep the refill rate uniform, one token will be added to the
2323
* bucket every 'tokenAddingRate'. If no tokens are left in the bucket, then PR won't be raised
24-
* and program will halt until next token is available.
25-
* <pre>
24+
* and program will halt until next token is available.</pre>
2625
*/
2726
public class RateLimiter {
2827

@@ -32,11 +31,11 @@ public class RateLimiter {
3231
/**
3332
* constructor to initialize RateLimiter with required values.
3433
* If time meter is not specified, the system default will be chosen.
35-
*
36-
* @param customTimeMeter Clock to be used for bucketing the tokens.
37-
* Defaults to TimeMeter.SYSTEM_MILLISECONDS
38-
* @param <T> Implementing class for customTimeMeter must be a class
39-
* extending TimeMeter
34+
* @param rateLimit RateLimit object
35+
* @param customTimeMeter custom time metere. should be of type TimeMeter
36+
* @param <T> Implementing class for customTimeMeter must be a class
37+
* extending TimeMeter
38+
* @see RateLimit
4039
* @see TimeMeter
4140
* @see TimeMeter#SYSTEM_MILLISECONDS
4241
*/
@@ -70,7 +69,7 @@ public RateLimiter() {
7069
* This method will create and return an object of type RateLimiter based on the
7170
* variable set in the Namespace.
7271
*
73-
* @param ns Namespace {@see net.sourceforge.argparse4j.inf.Namespace}
72+
* @param ns Namespace
7473
* @return RateLimiter object if required variable is set in Namespace
7574
* null otherwise.
7675
* @see net.sourceforge.argparse4j.inf.Namespace Namespace

0 commit comments

Comments
 (0)