simplify

Author: theswamis

app/controllers/application_controller.rb

@@ -91,4 +91,18 @@ def user_not_authorized
     flash[:alert] = 'You are not authorized to perform this action.'
     redirect_back(fallback_location: root_path)
   end
+
+  # Tracks a view for any viewable object (Document, Library, etc.)
+  # Updates the timestamp if the user has already viewed this item
+  # @param viewable [ActiveRecord::Base] the object being viewed (must have viewed_items association)
+  def track_view(viewable)
+    return unless current_user
+
+    viewed_item = ViewedItem.find_or_initialize_by(
+      user: current_user,
+      viewable: viewable
+    )
+    viewed_item.viewed_at = Time.current
+    viewed_item.save
+  end
 end

app/controllers/documents_controller.rb

@@ -16,7 +16,7 @@ def edit
   # GET /documents/1 or /documents/1.json
   def show
     # Track view for authenticated users
-    track_document_view if current_user
+    track_view(@document)
 
     # Handle flagging functionality (requires user to be logged in)
     if params[:flag] && current_user
@@ -42,17 +42,4 @@ def show
     @related_docs = related_documents(@document).first(5)
     @comments = @document.comments.includes(:user).ordered
   end
-
-  private
-
-  # Tracks a document view for the current user
-  # Updates the timestamp if the user has already viewed this document
-  def track_document_view
-    viewed_item = ViewedItem.find_or_initialize_by(
-      user: current_user,
-      viewable: @document
-    )
-    viewed_item.viewed_at = Time.current
-    viewed_item.save
-  end
 end

app/controllers/libraries_controller.rb

@@ -14,7 +14,7 @@ def edit
   # GET /libraries/1 or /libraries/1.json
   def show
     # Track view for authenticated users
-    track_library_view if current_user
+    track_view(@library)
   end
 
   def users
@@ -46,17 +46,4 @@ def download
 
     send_data final_contents, filename: "#{@library.name.parameterize}-documents.xml", type: 'application/xml' # Change filename and type
   end
-
-  private
-
-  # Tracks a library view for the current user
-  # Updates the timestamp if the user has already viewed this library
-  def track_library_view
-    viewed_item = ViewedItem.find_or_initialize_by(
-      user: current_user,
-      viewable: @library
-    )
-    viewed_item.viewed_at = Time.current
-    viewed_item.save
-  end
 end