add slack reply setting (#228)

Co-authored-by: Vijay Swamidass <[email protected]>

Author: vswamidass-sfdc

app/models/message.rb

@@ -14,46 +14,75 @@ class Message < ApplicationRecord
   private
 
   def create_slack_post
-    channel_id = chat.assistant.slack_channel_name.presence || chat.slack_channel_id
-
-    # Skip if there is already a thread linked or the assistant doesn't have a slack channel
-    return if channel_id.blank?
-
-    # If the assistant is generating, then it isn't ready and we don't post to slack
-    return unless ready?
-
-    # skip if this message already has a slack ts
-    return if slack_ts
+    return unless should_post_to_slack?
 
     begin
-      slack_service = SlackService.new
-
-      # if the chat.slack_thread is missing, we create a new thread
-      self.slack_ts = slack_service.post_message(channel_id, content, chat.slack_thread, assistant?)
-
-      # if the chat didn't have a thread, save it.
-      if chat.slack_thread.nil?
-        chat.slack_thread = slack_ts
-        chat.save
-      end
-
-      if slack_ts
-        slack_service.add_reaction(channel: chat.assistant.slack_channel_name, timestamp: slack_ts, emoji: 'pagerduty') if chat.webhook && (chat.webhook.hook_type == 'pagerduty')
-      else
-        Rails.logger.error("Failed to create Slack thread for chat ID: #{chat.id}")
-      end
+      post_message_to_slack
+      add_pagerduty_reaction_if_needed
     rescue StandardError => e
-      Rails.logger.error("Error in create_slack_post for message #{id}: #{e.message}")
-      Rails.logger.error(e.backtrace.join("\n"))
-      # Update the message content with the error information, bypassing callbacks
-      error_message = "⚠️ Slack Error: #{e.message}"
-
-      # There may be a better place to do this, but will look at that later
-      update_column(:content, "#{content}\n\n#{error_message}")
-      # Don't raise the error to prevent the message creation from failing
+      handle_slack_error(e)
     end
   end
 
+  def should_post_to_slack?
+    return false if slack_channel_id.blank?
+    return false unless ready?
+    return false if slack_ts.present?
+    return false if assistant_reply_only_mode_violated?
+
+    true
+  end
+
+  def slack_channel_id
+    @slack_channel_id ||= chat.assistant.slack_channel_name.presence || chat.slack_channel_id
+  end
+
+  def assistant_reply_only_mode_violated?
+    # If assistant is set to reply only and this is an assistant message without an existing thread,
+    # it means we're trying to start a new conversation which violates reply-only mode
+    chat.assistant.slack_reply_only? && assistant? && chat.slack_thread.blank?
+  end
+
+  def post_message_to_slack
+    slack_service = SlackService.new
+    self.slack_ts = slack_service.post_message(slack_channel_id, content, chat.slack_thread, assistant?)
+
+    update_chat_thread_if_needed
+    log_error_if_post_failed
+  end
+
+  def update_chat_thread_if_needed
+    return unless chat.slack_thread.nil? && slack_ts.present?
+
+    chat.update!(slack_thread: slack_ts)
+  end
+
+  def log_error_if_post_failed
+    return if slack_ts.present?
+
+    Rails.logger.error("Failed to create Slack thread for chat ID: #{chat.id}")
+  end
+
+  def add_pagerduty_reaction_if_needed
+    return unless slack_ts.present?
+    return unless chat.webhook&.hook_type == 'pagerduty'
+
+    SlackService.new.add_reaction(
+      channel: chat.assistant.slack_channel_name,
+      timestamp: slack_ts,
+      emoji: 'pagerduty'
+    )
+  end
+
+  def handle_slack_error(error)
+    Rails.logger.error("Error in create_slack_post for message #{id}: #{error.message}")
+    Rails.logger.error(error.backtrace.join("\n"))
+
+    # Consider using a separate error tracking field instead of modifying content
+    error_message = "⚠️ Slack Error: #{error.message}"
+    update_column(:content, "#{content}\n\n#{error_message}")
+  end
+
   def enqueue_generate_message_response_job
     return unless user?
 

app/views/assistants/_assistant.html.erb

@@ -63,6 +63,10 @@
     <strong class="block text-lg font-semibold text-gray-800 mb-2">Enable Channel Join Message</strong>
     <p class="text-gray-700"><%= assistant.enable_channel_join_message ? 'Yes' : 'No' %></p>
   </div>
+  <div class="my-5">
+    <strong class="block text-lg font-semibold text-gray-800 mb-2">Slack Reply Only</strong>
+    <p class="text-gray-700"><%= assistant.slack_reply_only ? 'Yes' : 'No' %></p>
+  </div>
   <!-- Document Creation -->
   <div class="my-5">
     <strong class="block text-lg font-semibold text-gray-800 mb-2">Create Document on Approval</strong>

app/views/assistants/_form.html.erb

@@ -88,6 +88,11 @@
       <p id="" class="text-gray-500 text-xs">Post an initial message when the bot is added to the channel.</p>
       <%= form.check_box :enable_channel_join_message, class: "block shadow rounded-md border border-gray-400 outline-none mt-2" %>
     </div>
+    <div class="my-5">
+      <%= form.label "Slack Reply Only" %>
+      <p id="" class="text-gray-500 text-xs">When enabled, the assistant will only respond to direct mentions in Slack threads.  It will not post new threads in the channel.</p>
+      <%= form.check_box :slack_reply_only, class: "block shadow rounded-md border border-gray-400 outline-none mt-2" %>
+    </div>
   <% end %>
   <%= render "shared/form_section", title: "Document Creation (Optional)" do %>
     <div class="my-5">

spec/factories/assistants.rb

@@ -5,6 +5,9 @@
     libraries { '1' }
     input { 'some input' }
     name { 'Test Assistant' }
+    instructions { 'Sample instructions' }
+    output { 'Sample output' }
+    slack_reply_only { false }
     association :user
   end
 end

spec/factories/messages.rb

@@ -1,7 +1,9 @@
 FactoryBot.define do
   factory :message do
-    chat { nil }
+    association :chat
+    association :user
     content { "MyText" }
-    from { 1 }
+    from { :user }
+    status { :ready }
   end
 end