chore: remove overkill shadow test

Author: jhefferman-sfdc

packages/@lwc/integration-karma/test-hydration/context/index.spec.js

@@ -61,35 +61,32 @@ function assertCorrectContext(snapshot) {
 }
 
 function assertContextShadowed(snapshot) {
-    // Change the parents context value and then check to make sure the grandparents value has been shadowed
-    snapshot.components.firstParent.context.value.value = 'shadow value';
+    const grandparentContext = snapshot.components.grandparent.context;
+    const firstParentContext = snapshot.components.firstParent.context;
+    const childOfFirstParentContext = snapshot.components.childOfFirstParent.context;
 
-    Object.entries(snapshot.components).forEach(([key, component]) => {
-        if (key === 'firstParent' || key === 'childOfFirstParent') {
-            expect(component.context.value.value)
-                .withContext(`${component.tagName} should have the correct context after shadowing`)
-                .toBe('shadow value');
-        } else {
-            expect(component.context.value.value)
-                .withContext(`${component.tagName} should have the initial context after shadowing`)
-                .toBe('grandparent provided value');
-        }
-    });
+    expect(childOfFirstParentContext.providedContextSignal)
+        .withContext(
+            `${snapshot.components.childOfFirstParent.tagName} should have been provided with the parent's context and not that of the grandparent`
+        )
+        .toBe(firstParentContext);
+
+    expect(firstParentContext.providedContextSignal)
+        .withContext(
+            `${snapshot.components.firstParent.tagName} should have been provided with the parent's context and not that of the grandparent`
+        )
+        .toBe(grandparentContext);
 }
 
 function assertContextDisconnected(target, snapshot) {
     Object.values(snapshot.components).forEach(
         (component) =>
             (component.disconnect = () => {
-                expect(component.context.disconnectContextCalled)
-                    .withContext(`${component.tagName} should have disconnected the context`)
-                    .toBeTrue();
-
-                expect(component.context.disconnectProvidedComponent)
+                expect(component.context.disconnectProvidedComponent.hostElement)
                     .withContext(
                         `The context of ${component.tagName} should have been disconnected with the correct component`
                     )
-                    .toBe(component.context.connectProvidedComponent);
+                    .toBe(component);
             })
     );
     target.showTree = false;

packages/@lwc/integration-karma/test-hydration/context/x/child/child.html

@@ -1,3 +1,3 @@
 <template>
-    <div>{context.value.value}, {anotherContext.value.value}</div>
+    <div>{context.value}, {anotherContext.value}</div>
 </template>

packages/@lwc/integration-karma/test-hydration/context/x/contextManager/contextManager.js

@@ -7,40 +7,13 @@ const trustedContext = new WeakSet();
 setTrustedContextSet(trustedContext);
 setContextKeys({ connectContext, disconnectContext });
 
-class MockSignal {
-    subscribers = new Set();
-
-    constructor(initialValue) {
-        this._value = initialValue;
-    }
-
-    set value(newValue) {
-        this._value = newValue;
-        this.notify();
-    }
-
-    get value() {
-        return this._value;
-    }
-
-    subscribe(onUpdate) {
-        this.subscribers.add(onUpdate);
-    }
-
-    notify() {
-        for (const subscriber of this.subscribers) {
-            subscriber(this.value);
-        }
-    }
-}
-
 class MockContextSignal {
-    disconnectContextCalled = false;
     connectProvidedComponent;
     disconnectProvidedComponent;
+    providedContextSignal;
 
     constructor(initialValue, contextDefinition, fromContext) {
-        this.value = new MockSignal(initialValue);
+        this.value = initialValue;
         this.contextDefinition = contextDefinition;
         this.fromContext = fromContext;
         trustedContext.add(this);
@@ -52,17 +25,13 @@ class MockContextSignal {
 
         if (this.fromContext) {
             runtimeAdapter.consumeContext(this.fromContext, (providedContextSignal) => {
-                this.value.value = providedContextSignal.value.value;
-                // Simple subscription is required to validate shadowed context
-                providedContextSignal.value.subscribe(
-                    (updatedValue) => (this.value.value = updatedValue)
-                );
+                this.providedContextSignal = providedContextSignal;
+                this.value = providedContextSignal.value;
             });
         }
     }
     [disconnectContext](component) {
         this.disconnectProvidedComponent = component;
-        this.disconnectContextCalled = true;
     }
 }
 

packages/@lwc/integration-karma/test-hydration/context/x/grandparent/grandparent.html

@@ -1,5 +1,5 @@
 <template>
-  <div>{context.value.value}, {anotherContext.value.value}</div>
+  <div>{context.value}, {anotherContext.value}</div>
   <x-parent></x-parent>
   <x-parent></x-parent>
 </template>

packages/@lwc/integration-karma/test-hydration/context/x/parent/parent.html

@@ -1,4 +1,4 @@
 <template>
-    <div>{context.value.value}, {anotherContext.value.value}</div>
+    <div>{context.value}, {anotherContext.value}</div>
     <x-child></x-child>
 </template>