Skip to content

Commit 1a8b40b

Browse files
committed
fix: fix test
1 parent c337695 commit 1a8b40b

File tree

1 file changed

+4
-27
lines changed
  • packages/@lwc/integration-not-karma/test/component/face-callbacks

1 file changed

+4
-27
lines changed

packages/@lwc/integration-not-karma/test/component/face-callbacks/index.spec.js

Lines changed: 4 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -180,33 +180,10 @@ describe.runIf(typeof ElementInternals !== 'undefined')('ElementInternals', () =
180180
);
181181

182182
describe.skipIf(scenario === 'lwc.createElement')(name, () => {
183-
const lightOrNativeShadow = name === 'light DOM' || process.env.NATIVE_SHADOW;
184-
185-
// Face throws error message when synthetic shadow is enabled
186-
it.runIf(lightOrNativeShadow)(
187-
`${name} calls face lifecycle methods when using CustomElementConstructor`,
188-
() => {
189-
// CustomElementConstructor is to be upgraded independently of LWC, it will always use native lifecycle
190-
testFaceLifecycleMethodsCallable(createFace);
191-
}
192-
);
193-
194-
// synthetic shadow mode
195-
it.skipIf(lightOrNativeShadow)(
196-
`${name} cannot call face lifecycle methods when using CustomElementConstructor`,
197-
() => {
198-
// this is always a callback reaction error, even in "synthetic lifecycle" mode,
199-
// because synthetic lifecycle mode only includes connected/disconnected callbacks,
200-
// not the FACE callbacks
201-
expect(() => {
202-
const face = createFace();
203-
const form = createFormElement();
204-
form.appendChild(face);
205-
}).toThrowCallbackReactionErrorEvenInSyntheticLifecycleMode(
206-
'Form associated lifecycle methods are not available in synthetic shadow. Please use native shadow or light DOM.'
207-
);
208-
}
209-
);
183+
it(`${name} calls face lifecycle methods when using CustomElementConstructor`, () => {
184+
// CustomElementConstructor is to be upgraded independently of LWC, it will always use native lifecycle
185+
testFaceLifecycleMethodsCallable(createFace);
186+
});
210187
});
211188
});
212189
});

0 commit comments

Comments
 (0)