test(wtr): use async/await instead of promise chains @W-19098252 (#5515)

* test(wtr): use async/await instead of promise chains

* Apply suggestion from @wjhsf

Author: wjhsf

packages/@lwc/integration-not-karma/test-hydration/component-lifecycle/disconnected-callback/index.spec.js

@@ -14,15 +14,14 @@ export default {
             xFoo: target.shadowRoot.querySelector('x-foo'),
         };
     },
-    test(target, snapshots) {
+    async test(target, snapshots) {
         const xFoo = target.shadowRoot.querySelector('x-foo');
         expect(xFoo).not.toBe(null);
         expect(xFoo).toBe(snapshots.xFoo);
 
         target.showFoo = false;
 
-        return Promise.resolve().then(() => {
-            expect(disconnectedCalled).toBe(true);
-        });
+        await Promise.resolve();
+        expect(disconnectedCalled).toBe(true);
     },
 };

packages/@lwc/integration-not-karma/test-hydration/component-lifecycle/render-method/index.spec.js

@@ -9,16 +9,15 @@ export default {
             text: p.firstChild,
         };
     },
-    test(target, snapshots) {
+    async test(target, snapshots) {
         const p = target.shadowRoot.querySelector('p');
         expect(p).toBe(snapshots.p);
         expect(p.firstChild).toBe(snapshots.text);
         expect(p.textContent).toBe('template A');
 
         target.useTplA = false;
 
-        return Promise.resolve().then(() => {
-            expect(target.shadowRoot.querySelector('p').textContent).toBe('template B');
-        });
+        await Promise.resolve();
+        expect(target.shadowRoot.querySelector('p').textContent).toBe('template B');
     },
 };

packages/@lwc/integration-not-karma/test-hydration/component-lifecycle/rendered-callback/index.spec.js

@@ -6,14 +6,13 @@ export default {
             text: p.firstChild,
         };
     },
-    test(target, snapshots) {
+    async test(target, snapshots) {
         const p = target.shadowRoot.querySelector('p');
         expect(p).toBe(snapshots.p);
         expect(p.firstChild).toBe(snapshots.text);
         expect(p.textContent).toBe('renderedCallback:false');
 
-        return Promise.resolve().then(() => {
-            expect(p.textContent).toBe('renderedCallback:true');
-        });
+        await Promise.resolve();
+        expect(p.textContent).toBe('renderedCallback:true');
     },
 };

packages/@lwc/integration-not-karma/test-hydration/directives/for-each/index.spec.js

@@ -8,7 +8,7 @@ export default {
             colors: target.shadowRoot.querySelectorAll('li'),
         };
     },
-    test(target, snapshots) {
+    async test(target, snapshots) {
         const ul = target.shadowRoot.querySelector('ul');
         let colors = ul.querySelectorAll('li');
         expect(ul).toBe(snapshots.ul);
@@ -21,11 +21,10 @@ export default {
 
         target.colors = ['orange', 'green', 'violet'];
 
-        return Promise.resolve().then(() => {
-            colors = ul.querySelectorAll('li');
-            expect(colors[0].textContent).toBe('orange');
-            expect(colors[1].textContent).toBe('green');
-            expect(colors[2].textContent).toBe('violet');
-        });
+        await Promise.resolve();
+        colors = ul.querySelectorAll('li');
+        expect(colors[0].textContent).toBe('orange');
+        expect(colors[1].textContent).toBe('green');
+        expect(colors[2].textContent).toBe('violet');
     },
 };

packages/@lwc/integration-not-karma/test-hydration/directives/if-false/index.spec.js

@@ -7,13 +7,12 @@ export default {
             p: target.shadowRoot.querySelector('p'),
         };
     },
-    test(target, snapshots) {
+    async test(target, snapshots) {
         expect(target.shadowRoot.querySelector('p')).toBe(snapshots.p);
 
         target.control = true;
 
-        return Promise.resolve().then(() => {
-            expect(target.shadowRoot.querySelector('p')).toBeNull();
-        });
+        await Promise.resolve();
+        expect(target.shadowRoot.querySelector('p')).toBeNull();
     },
 };

packages/@lwc/integration-not-karma/test-hydration/directives/if-true/index.spec.js

@@ -7,13 +7,12 @@ export default {
             p: target.shadowRoot.querySelector('p'),
         };
     },
-    test(target, snapshots) {
+    async test(target, snapshots) {
         expect(target.shadowRoot.querySelector('p')).toBe(snapshots.p);
 
         target.control = false;
 
-        return Promise.resolve().then(() => {
-            expect(target.shadowRoot.querySelector('p')).toBeNull();
-        });
+        await Promise.resolve();
+        expect(target.shadowRoot.querySelector('p')).toBeNull();
     },
 };

packages/@lwc/integration-not-karma/test-hydration/directives/iterator/index.spec.js

@@ -8,7 +8,7 @@ export default {
             colors: target.shadowRoot.querySelectorAll('li'),
         };
     },
-    test(target, snapshots) {
+    async test(target, snapshots) {
         const ul = target.shadowRoot.querySelector('ul');
         let colors = ul.querySelectorAll('li');
         expect(ul).toBe(snapshots.ul);
@@ -21,11 +21,10 @@ export default {
 
         target.colors = ['orange', 'green', 'violet'];
 
-        return Promise.resolve().then(() => {
-            colors = ul.querySelectorAll('li');
-            expect(colors[0].textContent).toBe('orange');
-            expect(colors[1].textContent).toBe('green');
-            expect(colors[2].textContent).toBe('violet');
-        });
+        await Promise.resolve();
+        colors = ul.querySelectorAll('li');
+        expect(colors[0].textContent).toBe('orange');
+        expect(colors[1].textContent).toBe('green');
+        expect(colors[2].textContent).toBe('violet');
     },
 };

packages/@lwc/integration-not-karma/test-hydration/light-dom/component-lifecycle/disconnected-callback/index.spec.js

@@ -14,15 +14,14 @@ export default {
             xFoo: target.querySelector('x-foo'),
         };
     },
-    test(target, snapshots) {
+    async test(target, snapshots) {
         const xFoo = target.querySelector('x-foo');
         expect(xFoo).not.toBe(null);
         expect(xFoo).toBe(snapshots.xFoo);
 
         target.showFoo = false;
 
-        return Promise.resolve().then(() => {
-            expect(disconnectedCalled).toBe(true);
-        });
+        await Promise.resolve();
+        expect(disconnectedCalled).toBe(true);
     },
 };

packages/@lwc/integration-not-karma/test-hydration/light-dom/component-lifecycle/render-method/index.spec.js

@@ -9,16 +9,15 @@ export default {
             text: p.firstChild,
         };
     },
-    test(target, snapshots) {
+    async test(target, snapshots) {
         const p = target.querySelector('p');
         expect(p).toBe(snapshots.p);
         expect(p.firstChild).toBe(snapshots.text);
         expect(p.textContent).toBe('template A');
 
         target.useTplA = false;
 
-        return Promise.resolve().then(() => {
-            expect(target.querySelector('p').textContent).toBe('template B');
-        });
+        await Promise.resolve();
+        expect(target.querySelector('p').textContent).toBe('template B');
     },
 };

packages/@lwc/integration-not-karma/test-hydration/light-dom/component-lifecycle/rendered-callback/index.spec.js

@@ -6,14 +6,13 @@ export default {
             text: p.firstChild,
         };
     },
-    test(target, snapshots) {
+    async test(target, snapshots) {
         const p = target.querySelector('p');
         expect(p).toBe(snapshots.p);
         expect(p.firstChild).toBe(snapshots.text);
         expect(p.textContent).toBe('renderedCallback:false');
 
-        return Promise.resolve().then(() => {
-            expect(p.textContent).toBe('renderedCallback:true');
-        });
+        await Promise.resolve();
+        expect(p.textContent).toBe('renderedCallback:true');
     },
 };