fix(ssr): throw compile-time error on @wire-decorated getter/setter/method (#5175)

* fix(ssr): throw compile-time error on @wire-decorated getter/setter/method

* fix(ssr): disallow @wire on computed props

Author: wjhsf

packages/@lwc/engine-server/src/__tests__/fixtures.spec.ts

@@ -11,6 +11,7 @@ import { rollup } from 'rollup';
 import lwcRollupPlugin from '@lwc/rollup-plugin';
 import { testFixtureDir, formatHTML } from '@lwc/test-utils-lwc-internals';
 import { setFeatureFlagForTest } from '../index';
+import type { FeatureFlagName } from '@lwc/features/dist/types';
 import type { RollupLwcOptions } from '@lwc/rollup-plugin';
 import type * as lwc from '../index';
 
@@ -128,16 +129,17 @@ function testFixtures(options?: RollupLwcOptions) {
             // the LightningElement. Therefor the compiled module should also be evaluated in the
             // same sandbox registry as the engine.
             const lwcEngineServer = await import('../index');
-            const module = (await import(compiledFixturePath)) as FixtureModule;
-
-            const features = module!.features ?? [];
-            features.forEach((flag) => {
-                lwcEngineServer!.setFeatureFlagForTest(flag, true);
-            });
 
             let result;
             let err;
+            let features: FeatureFlagName[] = [];
             try {
+                const module = (await import(compiledFixturePath)) as FixtureModule;
+
+                features = module!.features ?? [];
+                features.forEach((flag) => {
+                    lwcEngineServer!.setFeatureFlagForTest(flag, true);
+                });
                 result = formatHTML(
                     lwcEngineServer!.renderComponent(
                         module!.tagName,
@@ -146,10 +148,10 @@ function testFixtures(options?: RollupLwcOptions) {
                     )
                 );
             } catch (_err: any) {
-                if (_err.name === 'AssertionError') {
+                if (_err?.name === 'AssertionError') {
                     throw _err;
                 }
-                err = _err.message;
+                err = _err?.message || 'An empty error occurred?!';
             }
 
             features.forEach((flag) => {

packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/config.json

@@ -0,0 +1,6 @@
+{
+    "ssrFiles": {
+        "error": "error-ssr.txt",
+        "expected": "expected-ssr.html"
+    }
+}

packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/error-ssr.txt

@@ -0,0 +1 @@
+Unknown state: property definition has no key

…ors/throws-on-computed-key/expected.html …puted-prop-updates-incorrectly/error.txtpackages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/expected.html renamed to packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/error.txt packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/expected.html renamed to packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/error.txt

@@ -0,0 +1,10 @@
+<x-wire>
+  <template shadowrootmode="open">
+    <p>
+      Prop named symbol that should not be used: wire data
+    </p>
+    <p>
+      Prop with symbol key that should be used: unset
+    </p>
+  </template>
+</x-wire>

packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/expected-ssr.html

@@ -0,0 +1,13 @@
+export class adapter {
+    constructor(dataCallback) {
+        this.dc = dataCallback;
+    }
+
+    connect() {}
+
+    update(config) {
+        this.dc(config.value);
+    }
+
+    disconnect() {}
+}

packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/expected.html

@@ -0,0 +1,4 @@
+<template>
+    <p>Prop named symbol that should not be used: {symbol}</p>
+    <p>Prop with symbol key that should be used: {symbolValue}</p>
+</template>

…e/errors/throws-on-computed-key/index.js …mputed-prop-updates-incorrectly/index.jspackages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/index.js renamed to packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/index.js packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/index.js renamed to packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/index.js

@@ -0,0 +1,14 @@
+import { LightningElement, wire } from 'lwc';
+import { adapter } from './adapter';
+
+const symbol = Symbol("I'm a symbol!");
+export default class extends LightningElement {
+    symbol = 'accidentally overwritten';
+
+    @wire(adapter, { value: 'wire data' })
+    [symbol] = 'unset';
+
+    get symbolValue() {
+        return this[symbol] ?? 'unset';
+    }
+}