chore: rename ephemeral placeholder variable (#5210)

wjhsf · jhefferman-sfdc · commit 50516ed966bd · 2025-02-18T11:23:18.000-07:00
diff --git a/packages/@lwc/ssr-compiler/src/compile-js/index.ts b/packages/@lwc/ssr-compiler/src/compile-js/index.ts
@@ -244,7 +244,7 @@ const visitors: Visitors = {
     },
     Identifier(path, _state) {
         const { node } = path;
-        if (node?.name.startsWith('__lwc') && node.name.endsWith('__')) {
+        if (node?.name.startsWith('__lwc')) {
             // TODO [#5032]: Harmonize errors thrown in `@lwc/ssr-compiler`
             throw new Error(`LWCTODO: identifier name '${node.name}' cannot start with '__lwc'`);
         }
diff --git a/packages/@lwc/ssr-compiler/src/estemplate.ts b/packages/@lwc/ssr-compiler/src/estemplate.ts
@@ -20,6 +20,12 @@ import type { Checker } from 'estree-toolkit/dist/generated/is-type';
 /** Placeholder value to use to opt out of validation. */
 const NO_VALIDATION = false;
 
+/**
+ * `esTemplate` generates JS code with "holes" to be filled later. In order to have a valid AST,
+ * it uses identifiers with this prefix at the location of the holes.
+ */
+const PLACEHOLDER_PREFIX = '__lwc_ESTEMPLATE_PLACEHOLDER__';
+
 /** A function that accepts a node and checks that it is a particular type of node. */
 type Validator<T extends EsNode | null = EsNode | null> = (
     node: EsNode | null | undefined
@@ -65,8 +71,6 @@ type ToReplacementParameters<Arr extends unknown[]> = Arr extends [infer Head, .
           [ValidatedType<Head>, ...ToReplacementParameters<Rest>]
     : []; // `Arr` is an empty array -- nothing to transform
 
-const PLACEHOLDER_PREFIX = `__ESTEMPLATE_${Math.random().toString().slice(2)}_PLACEHOLDER__`;
-
 interface TraversalState {
     placeholderToValidator: Map<number, Validator>;
     replacementNodes: Array<EsNode | EsNode[] | null>;

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ const visitors: Visitors = {`
`244`	`244`	`},`
`245`	`245`	`Identifier(path, _state) {`
`246`	`246`	`const { node } = path;`
`247`		`- if (node?.name.startsWith('__lwc') && node.name.endsWith('__')) {`
	`247`	`+ if (node?.name.startsWith('__lwc')) {`
`248`	`248`	// TODO [#5032]: Harmonize errors thrown in `@lwc/ssr-compiler`
`249`	`249`	throw new Error(`LWCTODO: identifier name '${node.name}' cannot start with '__lwc'`);
`250`	`250`	`}`