Skip to content

Commit 523ac07

Browse files
committed
test(integration-karma): simplify value evaluation throws tests
1 parent e5a2cda commit 523ac07

File tree

2 files changed

+4
-22
lines changed

2 files changed

+4
-22
lines changed

packages/@lwc/integration-karma/test/lwc-on/index.spec.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ describe('lwc:on', () => {
423423

424424
describe('object passed to lwc:on has property whose value evaluation throws', () => {
425425
let element;
426-
let testFn;
426+
let button;
427427

428428
let caughtError;
429429

@@ -438,28 +438,24 @@ describe('lwc:on', () => {
438438
function setup(handlerType) {
439439
element = createElement('x-value-evaluation-throws', { is: ValueEvaluationThrows });
440440
element.handlerType = handlerType;
441+
document.body.appendChild(element);
442+
button = element.shadowRoot.querySelector('button');
441443
}
442444

443445
it('getter that throws passed as handler', () => {
444446
setup('getter that throws');
445-
document.body.appendChild(element);
446447

447448
expect(caughtError.message).toBe('Uncaught Error: some error');
448449

449-
const button = element.shadowRoot.querySelector('button');
450450
expect(button).toBeNull();
451451
});
452452

453453
it('LightningElement instance is passed as argument to lwc:on', () => {
454454
setup('LightningElement instance');
455-
testFn = jasmine.createSpy('test function');
456-
element.testFn = testFn;
457-
document.body.appendChild(element);
458455

459456
expect(caughtError.error instanceof TypeError).toBe(true);
460457
expect(caughtError.message).toBe('Uncaught TypeError: Illegal constructor');
461458

462-
const button = element.shadowRoot.querySelector('button');
463459
expect(button).toBeNull();
464460
});
465461
});

packages/@lwc/integration-karma/test/lwc-on/x/valueEvaluationThrows/valueEvaluationThrows.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,8 @@
11
import { LightningElement, api } from 'lwc';
22

3-
let testFn;
4-
53
export default class ValueNotFunction extends LightningElement {
64
@api handlerType;
75

8-
@api
9-
get testFn() {
10-
return testFn;
11-
}
12-
set testFn(val) {
13-
testFn = val;
14-
}
15-
166
get eventHandlers() {
177
switch (this.handlerType) {
188
case 'getter that throws':
@@ -22,11 +12,7 @@ export default class ValueNotFunction extends LightningElement {
2212
},
2313
};
2414
case 'LightningElement instance':
25-
return new (class extends LightningElement {
26-
render() {
27-
testFn();
28-
}
29-
})();
15+
return new (class extends LightningElement {})();
3016
default:
3117
return {};
3218
}

0 commit comments

Comments
 (0)