Skip to content

Commit 5656009

Browse files
authored
chore(ssr-compiler): remove fixed FIXMEs (#5311)
* chore: remove comment turns out it uses an empty object so no change is necessary * chore: restore validation * chore: todone * chore: remove fixed fixme seems to be covered by fixture packages/@lwc/engine-server/src/__tests__/fixtures/comments-slot/expected.html
1 parent 0716123 commit 5656009

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

packages/@lwc/ssr-compiler/src/compile-js/decorators/wire.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,6 @@ export function catalogWireAdapters(
171171
}
172172
});
173173
} else {
174-
// FIXME: for `@wire(Adapter), does engine-server use `undefined` or `{}` for config?
175174
reactiveConfig = b.objectExpression([]); // empty object
176175
}
177176

packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,7 @@ const bAddSlottedContent = esTemplate`
7979
addSlottedContent(${/* slot name */ is.expression} ?? "", async function* __lwcGenerateSlottedContent(contextfulParent, ${
8080
/* scoped slot data variable */ isNullableOf(is.identifier)
8181
}, slotAttributeValue) {
82-
// FIXME: make validation work again
83-
${/* slot content */ false}
82+
${/* slot content */ is.statement}
8483
}, ${/* content map */ is.identifier});
8584
`<EsCallExpression>;
8685

packages/@lwc/ssr-compiler/src/compile-template/transformers/slot.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ const bConditionalSlot = esTemplateWithYield`
6666
// If we're in this else block, then the generator _must_ have yielded
6767
// something. It's impossible for a slottedContent["foo"] to exist
6868
// without the generator yielding at least a text node / element.
69-
// FIXME: how does this work with comments and lwc:preserve-comments?
70-
// TODO: default/fallback slot content
7169
${/* slot fallback content */ is.statement}
7270
}
7371

0 commit comments

Comments
 (0)