Skip to content

Commit 621f8f9

Browse files
fix: attribute cte syntax in integration tests (#5498)
* fix: attribute cte syntax in integration tests * test(wtr): fix case in import mismatched case passes locally, but causes issues in CI * test(wtr): re-enable tests that used to fail in CI they should all work now --------- Co-authored-by: Will Harney <wharney@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
1 parent 40c8857 commit 621f8f9

File tree

8 files changed

+7
-13
lines changed

8 files changed

+7
-13
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
<template>
2-
<div foo={runRunAsFastAsYouCan()}></div>
2+
<div foo="{runRunAsFastAsYouCan()}"></div>
33
</template>
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
<template>
2-
<div foo={nonexistent.thing}></div>
2+
<div foo="{nonexistent.thing}"></div>
33
</template>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
<template>
2-
<div foo={bar()}></div>
2+
<div foo="{bar()}"></div>
33
</template>

packages/@lwc/integration-not-karma/configs/integration.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,6 @@ export default {
1717

1818
// Implement objectContaining / arrayWithExactContents
1919
'!test/profiler/mutation-logging/index.spec.js',
20-
21-
// Broken in CI?
22-
'!test/lwc-on/index.spec.js',
23-
'!test/api/sanitizeAttribute/index.spec.js',
24-
'!test/template-expressions/errors/index.spec.js',
25-
'!test/template-expressions/smoke-test/index.spec.js',
2620
],
2721
plugins: [
2822
...baseConfig.plugins,

packages/@lwc/integration-not-karma/test/lwc-on/index.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import Rerender from 'x/rerender';
1010
import RerenderLoop from 'x/rerenderLoop';
1111
import PublicProp from 'x/publicProp';
1212
import ComputedKey from 'x/computedKey';
13-
import ValueEvaluationThrows from 'x/ValueEvaluationThrows';
13+
import ValueEvaluationThrows from 'x/valueEvaluationThrows';
1414
import { jasmine } from '../../helpers/jasmine.js';
1515
import { spyConsole } from '../../helpers/console.js';
1616
import { catchUnhandledRejectionsAndErrors } from '../../helpers/utils.js';
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
<template>
2-
<div foo={runRunAsFastAsYouCan()}></div>
2+
<div foo="{runRunAsFastAsYouCan()}"></div>
33
</template>
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
<template>
2-
<div foo={nonexistent.thing}></div>
2+
<div foo="{nonexistent.thing}"></div>
33
</template>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
<template>
2-
<div foo={bar()}></div>
2+
<div foo="{bar()}"></div>
33
</template>

0 commit comments

Comments
 (0)