fix(ssr): disallow @wire on computed props

Author: wjhsf

packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/config.json

@@ -0,0 +1,6 @@
+{
+    "ssrFiles": {
+        "error": "error-ssr.txt",
+        "expected": "expected-ssr.html"
+    }
+}

packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/error-ssr.txt

@@ -0,0 +1 @@
+Unknown state: property definition has no key

packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/error.txt

@@ -0,0 +1,10 @@
+<x-wire>
+  <template shadowrootmode="open">
+    <p>
+      Prop named symbol that should not be used: wire data
+    </p>
+    <p>
+      Prop with symbol key that should be used: unset
+    </p>
+  </template>
+</x-wire>

packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/expected-ssr.html

@@ -0,0 +1,3 @@
+export const tagName = 'x-wire';
+export { default } from 'x/wire';
+export * from 'x/wire';

packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/expected.html

@@ -0,0 +1,13 @@
+export class adapter {
+    constructor(dataCallback) {
+        this.dc = dataCallback;
+    }
+
+    connect() {}
+
+    update(config) {
+        this.dc(config.value);
+    }
+
+    disconnect() {}
+}

packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/index.js

@@ -0,0 +1,4 @@
+<template>
+    <p>Prop named symbol that should not be used: {symbol}</p>
+    <p>Prop with symbol key that should be used: {symbolValue}</p>
+</template>

packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/modules/x/wire/adapter.js

@@ -0,0 +1,14 @@
+import { LightningElement, wire } from 'lwc';
+import { adapter } from './adapter';
+
+const symbol = Symbol("I'm a symbol!");
+export default class extends LightningElement {
+    symbol = 'accidentally overwritten';
+
+    @wire(adapter, { value: 'wire data' })
+    [symbol] = 'unset';
+
+    get symbolValue() {
+        return this[symbol] ?? 'unset';
+    }
+}

packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/computed-prop-updates-incorrectly/modules/x/wire/wire.html

@@ -93,7 +93,11 @@ const visitors: Visitors = {
     },
     PropertyDefinition(path, state) {
         const node = path.node;
-        if (!is.identifier(node?.key)) {
+        if (!node?.key) {
+            // Seems to occur for `@wire() [symbol];` -- not sure why
+            throw new Error('Unknown state: property definition has no key');
+        }
+        if (!is.identifier(node.key)) {
             return;
         }
 
@@ -107,6 +111,10 @@ const visitors: Visitors = {
             is.identifier(decoratedExpression.callee) &&
             decoratedExpression.callee.name === 'wire'
         ) {
+            if (node.computed) {
+                // TODO [#5032]: Harmonize errors thrown in `@lwc/ssr-compiler`
+                throw new Error('@wire cannot be used on computed properties in SSR context.');
+            }
             catalogWireAdapters(path, state);
             state.privateFields.push(node.key.name);
         } else {
@@ -149,6 +157,7 @@ const visitors: Visitors = {
             // not a getter/setter
             const isRealMethod = node.kind === 'method';
             if (node.computed) {
+                // TODO [#5032]: Harmonize errors thrown in `@lwc/ssr-compiler`
                 throw new Error(
                     `@wire cannot be used on computed ${isRealMethod ? 'method' : 'properties'} in SSR context.`
                 );