Merge branch 'master' into jhefferman/fix-cte-integration-tests

Author: wjhsf

.github/workflows/karma.yml

@@ -58,7 +58,9 @@ jobs:
             - run: LEGACY_BROWSERS=1 yarn sauce:ci
             - run: FORCE_NATIVE_SHADOW_MODE_FOR_TEST=1 yarn sauce:ci
             - run: DISABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE=1 yarn sauce:ci
+            - run: DISABLE_DETACHED_REHYDRATION=1 yarn sauce:ci
             - run: DISABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE=1 DISABLE_SYNTHETIC=1 yarn sauce:ci
+            - run: DISABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE=1 DISABLE_DETACHED_REHYDRATION=1 yarn sauce:ci
 
             - name: Upload coverage results
               uses: actions/upload-artifact@v4
@@ -187,6 +189,8 @@ jobs:
             - run: NODE_ENV_FOR_TEST=production yarn hydration:sauce:ci:engine-server
             - run: DISABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE=1 yarn hydration:sauce:ci:engine-server
             - run: DISABLE_STATIC_CONTENT_OPTIMIZATION=1 yarn hydration:sauce:ci:engine-server
+            - run: DISABLE_DETACHED_REHYDRATION=1 yarn hydration:sauce:ci:engine-server
+            - run: DISABLE_NATIVE_CUSTOM_ELEMENT_LIFECYCLE=1 DISABLE_DETACHED_REHYDRATION=1 yarn hydration:sauce:ci:engine-server
             - run: yarn hydration:sauce:ci
             - run: ENABLE_SYNTHETIC_SHADOW_IN_HYDRATION=1 yarn hydration:sauce:ci
             - run: NODE_ENV_FOR_TEST=production yarn hydration:sauce:ci

.nucleus.yaml

@@ -0,0 +1,64 @@
+core-deploy:
+    enabled: true
+    project-modules:
+        lwc: lwc.version
+branches:
+    ~DEFAULT~:
+        pull-request: &branch-definition
+            workflow: build-and-test
+            auto-start: true
+            auto-start-from-forks: false
+            merge-method: disabled # do not auto-merge; we'll do it ourselves
+            required-downstream-deps:
+                - BuilderFramework/builder-framework-salesforce
+                - MobilePlatform/lsdk-modules
+                - MobilePlatform/lwr-lightning-platform
+                - MobilePlatform/ui-fsm-components
+                - automation-platform/ui-externalservices-builder-components
+                - communities/microsite-template-marketing
+                - communities/shared-experience-components
+                - communities/ui-commerce-components
+                - communities/webruntime
+                - lds/lds-plugins
+                - salesforce-experience-platform-emu/komaci
+                - salesforce-experience-platform-emu/locker-pentest-app
+                - salesforce-experience-platform-emu/lwr
+                - salesforce-experience-platform-emu/lwr-everywhere
+                - salesforce-experience-platform-emu/lwr-recipes
+                - salesforce/lwc-test
+                # Using old major versions; tests in PRs will always fail
+                # - salesforce/o11y-sample-app
+                # - Skilling-and-Enablement/ui-external-enablement
+    release:
+        pull-request:
+            <<: *branch-definition
+    # Only active branches need to be included in this config
+    winter26:
+        pull-request:
+            <<: *branch-definition
+    spring25:
+        pull-request:
+            <<: *branch-definition
+    summer25:
+        pull-request:
+            <<: *branch-definition
+jobs:
+    build-and-test:
+        memory-limit: 16
+    create-canary-release:
+        memory-limit: 16
+    build-dependency:
+        memory-limit: 16
+    release:
+        memory-limit: 16
+steps:
+    node-conformance:
+        run:
+            command: yarn run lint
+        after: node-build
+    node-unit-tests:
+        run:
+            command: yarn test
+    # this project runs yarn build after yarn install so skip explicit build step
+    node-build: &node-build
+        skip: true

eslint.config.mjs

@@ -361,16 +361,9 @@ export default tseslint.config(
             globals: {
                 lwcRuntimeFlags: true,
                 process: true,
-                TestUtils: true,
                 ...globals.browser,
-                ...globals.jasmine,
             },
         },
-
-        rules: {
-            'no-var': 'off',
-            'prefer-rest-params': 'off',
-        },
     },
     {
         files: ['packages/@lwc/integration-karma/**'],
@@ -385,11 +378,6 @@ export default tseslint.config(
                 ...globals.jasmine,
             },
         },
-
-        rules: {
-            'no-var': 'off',
-            'prefer-rest-params': 'off',
-        },
     },
     {
         files: ['packages/@lwc/synthetic-shadow/**'],

package.json

@@ -1,6 +1,6 @@
 {
     "name": "lwc-monorepo",
-    "version": "8.22.1",
+    "version": "8.22.3",
     "private": true,
     "description": "Lightning Web Components",
     "repository": {
@@ -38,10 +38,10 @@
     },
     "devDependencies": {
         "@commitlint/cli": "^19.8.1",
-        "@eslint/js": "9.35.0",
+        "@eslint/js": "9.36.0",
         "@lwc/eslint-plugin-lwc-internal": "link:./scripts/eslint-plugin",
         "@lwc/test-utils-lwc-internals": "link:./scripts/test-utils",
-        "@nx/js": "21.4.1",
+        "@nx/js": "21.5.3",
         "@rollup/plugin-commonjs": "^28.0.6",
         "@rollup/plugin-inject": "^5.0.5",
         "@rollup/plugin-node-resolve": "^16.0.1",
@@ -51,30 +51,30 @@
         "@swc/core": "~1.13.5",
         "@swc/helpers": "~0.5.17",
         "@types/babel__core": "^7.20.5",
-        "@types/node": "^22.18.1",
+        "@types/node": "^22.18.4",
         "@vitest/coverage-v8": "^3.2.4",
-        "@vitest/eslint-plugin": "^1.3.9",
+        "@vitest/eslint-plugin": "^1.3.12",
         "@vitest/ui": "^3.2.4",
         "bytes": "^3.1.2",
         "es-module-lexer": "^1.7.0",
-        "eslint": "9.35.0",
+        "eslint": "9.36.0",
         "eslint-config-flat-gitignore": "^2.1.0",
         "eslint-plugin-header": "^3.1.1",
         "eslint-plugin-import": "^2.32.0",
         "glob": "^11.0.3",
-        "globals": "^16.3.0",
+        "globals": "^16.4.0",
         "husky": "^9.1.7",
         "isbinaryfile": "^5.0.6",
         "jsdom": "^26.1.0",
-        "lint-staged": "^16.1.6",
+        "lint-staged": "^16.2.0",
         "magic-string": "^0.30.19",
-        "nx": "21.4.1",
+        "nx": "21.5.3",
         "prettier": "^3.6.2",
-        "rollup": "^4.50.1",
+        "rollup": "^4.52.0",
         "terser": "^5.44.0",
         "tslib": "^2.8.1",
         "typescript": "5.8.2",
-        "typescript-eslint": "8.42.0",
+        "typescript-eslint": "8.44.0",
         "vitest": "^3.2.4"
     },
     "lint-staged": {

packages/@lwc/aria-reflection/package.json

@@ -4,7 +4,7 @@
         "You can safely modify dependencies, devDependencies, keywords, etc., but other props will be overwritten."
     ],
     "name": "@lwc/aria-reflection",
-    "version": "8.22.1",
+    "version": "8.22.3",
     "description": "ARIA element reflection polyfill for strings",
     "keywords": [
         "aom",

packages/@lwc/babel-plugin-component/package.json

@@ -4,7 +4,7 @@
         "You can safely modify dependencies, devDependencies, keywords, etc., but other props will be overwritten."
     ],
     "name": "@lwc/babel-plugin-component",
-    "version": "8.22.1",
+    "version": "8.22.3",
     "description": "Babel plugin to transform a LWC module",
     "keywords": [
         "lwc"
@@ -47,8 +47,8 @@
     },
     "dependencies": {
         "@babel/helper-module-imports": "7.27.1",
-        "@lwc/errors": "8.22.1",
-        "@lwc/shared": "8.22.1",
+        "@lwc/errors": "8.22.3",
+        "@lwc/shared": "8.22.3",
         "line-column": "~1.0.2"
     },
     "devDependencies": {

packages/@lwc/compiler/package.json

@@ -4,7 +4,7 @@
         "You can safely modify dependencies, devDependencies, keywords, etc., but other props will be overwritten."
     ],
     "name": "@lwc/compiler",
-    "version": "8.22.1",
+    "version": "8.22.3",
     "description": "LWC compiler",
     "keywords": [
         "lwc"
@@ -52,11 +52,11 @@
         "@babel/plugin-transform-class-properties": "7.27.1",
         "@babel/plugin-transform-object-rest-spread": "7.28.4",
         "@locker/babel-plugin-transform-unforgeables": "0.22.0",
-        "@lwc/babel-plugin-component": "8.22.1",
-        "@lwc/errors": "8.22.1",
-        "@lwc/shared": "8.22.1",
-        "@lwc/ssr-compiler": "8.22.1",
-        "@lwc/style-compiler": "8.22.1",
-        "@lwc/template-compiler": "8.22.1"
+        "@lwc/babel-plugin-component": "8.22.3",
+        "@lwc/errors": "8.22.3",
+        "@lwc/shared": "8.22.3",
+        "@lwc/ssr-compiler": "8.22.3",
+        "@lwc/style-compiler": "8.22.3",
+        "@lwc/template-compiler": "8.22.3"
     }
 }

packages/@lwc/engine-core/package.json

@@ -4,7 +4,7 @@
         "You can safely modify dependencies, devDependencies, keywords, etc., but other props will be overwritten."
     ],
     "name": "@lwc/engine-core",
-    "version": "8.22.1",
+    "version": "8.22.3",
     "description": "Core LWC engine APIs.",
     "keywords": [
         "lwc"
@@ -46,9 +46,9 @@
         }
     },
     "dependencies": {
-        "@lwc/features": "8.22.1",
-        "@lwc/shared": "8.22.1",
-        "@lwc/signals": "8.22.1"
+        "@lwc/features": "8.22.3",
+        "@lwc/shared": "8.22.3",
+        "@lwc/signals": "8.22.3"
     },
     "devDependencies": {
         "observable-membrane": "2.0.0"

packages/@lwc/engine-core/src/framework/mutation-tracker.ts

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: MIT
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
-import { isNull, isObject, isTrustedSignal } from '@lwc/shared';
+import { isNull, isObject, isTrustedSignal, legacyIsTrustedSignal } from '@lwc/shared';
 import { ReactiveObserver, valueMutated, valueObserved } from '../libs/mutation-tracker';
 import { subscribeToSignal } from '../libs/signal-tracker';
 import type { Signal } from '@lwc/signals';
@@ -41,13 +41,26 @@ export function componentValueObserved(vm: VM, key: PropertyKey, target: any = {
         lwcRuntimeFlags.ENABLE_EXPERIMENTAL_SIGNALS &&
         isObject(target) &&
         !isNull(target) &&
-        isTrustedSignal(target) &&
         process.env.IS_BROWSER &&
         // Only subscribe if a template is being rendered by the engine
         tro.isObserving()
     ) {
-        // Subscribe the template reactive observer's notify method, which will mark the vm as dirty and schedule hydration.
-        subscribeToSignal(component, target as Signal<unknown>, tro.notify.bind(tro));
+        /**
+         * The legacy validation behavior was that this check should only
+         * be performed for runtimes that have provided a trustedSignals set.
+         * However, this resulted in a bug as all object values were
+         * being considered signals in environments where the trustedSignals
+         * set had not been defined. The runtime flag has been added as a killswitch
+         * in case the fix needs to be reverted.
+         */
+        if (
+            lwcRuntimeFlags.ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION
+                ? legacyIsTrustedSignal(target)
+                : isTrustedSignal(target)
+        ) {
+            // Subscribe the template reactive observer's notify method, which will mark the vm as dirty and schedule hydration.
+            subscribeToSignal(component, target as Signal<unknown>, tro.notify.bind(tro));
+        }
     }
 }
 

packages/@lwc/engine-core/src/framework/vm.ts

@@ -673,7 +673,14 @@ function flushRehydrationQueue() {
     for (let i = 0, len = vms.length; i < len; i += 1) {
         const vm = vms[i];
         try {
-            rehydrate(vm);
+            // We want to prevent rehydration from occurring when nodes are detached from the DOM as this can trigger
+            // unintended side effects, like lifecycle methods being called multiple times.
+            // For backwards compatibility, we use a flag to control the check.
+            // 1. When flag is off, always rehydrate (legacy behavior)
+            // 2. When flag is on, only rehydrate when the VM state is connected (fixed behavior)
+            if (!lwcRuntimeFlags.DISABLE_DETACHED_REHYDRATION || vm.state === VMState.connected) {
+                rehydrate(vm);
+            }
         } catch (error) {
             if (i + 1 < len) {
                 // pieces of the queue are still pending to be rehydrated, those should have priority