-
Notifications
You must be signed in to change notification settings - Fork 407
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: v2 hydration test failures (#5227)
* fix: fixed class mutation, added test coverage, removed failure supression * fix: unnecessary fixture pathing
- Loading branch information
1 parent
34c7522
commit 7a761c4
Showing
65 changed files
with
287 additions
and
152 deletions.
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3
.../engine-server/src/__tests__/fixtures/attribute-and-class-modify/parent-child/config.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "entry": "x/parent" | ||
| } |
File renamed without changes.
8 changes: 8 additions & 0 deletions
8
...ngine-server/src/__tests__/fixtures/attribute-and-class-modify/parent-child/expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <fixture-test> | ||
| <template shadowrootmode="open"> | ||
| <x-child class="connected-callback-class connected-callback-class-2 initial" data-lwc-host-mutated="class"> | ||
| <template shadowrootmode="open"> | ||
| </template> | ||
| </x-child> | ||
| </template> | ||
| </fixture-test> |
File renamed without changes.
9 changes: 9 additions & 0 deletions
9
...r/src/__tests__/fixtures/attribute-and-class-modify/parent-child/modules/x/child/child.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { LightningElement } from 'lwc'; | ||
|
|
||
| export default class extends LightningElement { | ||
| connectedCallback() { | ||
| // Modify a class that has already been set by the parent | ||
| this.classList.add('connected-callback-class'); | ||
| this.classList.add('connected-callback-class-2'); | ||
| } | ||
| } |
3 changes: 3 additions & 0 deletions
3
...c/__tests__/fixtures/attribute-and-class-modify/parent-child/modules/x/parent/parent.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <template> | ||
| <x-child class="initial"></x-child> | ||
| </template> |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 2 additions & 0 deletions
2
...ne-server/src/__tests__/fixtures/attribute-and-class-modify/simple/modules/x/cmp/cmp.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| <template> | ||
| </template> |
File renamed without changes.
88 changes: 0 additions & 88 deletions
88
packages/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/expected.html
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Empty file.
19 changes: 19 additions & 0 deletions
19
packages/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/inner-div/expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <fixture-test> | ||
| <template shadowrootmode="open"> | ||
| <div data-expect-no-warning data-id="div-inner-static" inner-h-t-m-l="replaced"> | ||
| original | ||
| </div> | ||
| <div data-expect-no-warning data-id="div-inner-computed" inner-h-t-m-l="injected"> | ||
| original | ||
| </div> | ||
| <div data-id="div-inner-spread"> | ||
| original | ||
| </div> | ||
| <span> | ||
| lwc:inner-html | ||
| </span> | ||
| <p> | ||
| injected | ||
| </p> | ||
| </template> | ||
| </fixture-test> |
8 changes: 8 additions & 0 deletions
8
...ngine-server/src/__tests__/fixtures/inner-outer-html/inner-div/modules/x/inner/inner.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <template> | ||
| <div data-id="div-inner-static" data-expect-no-warning inner-h-t-m-l="replaced">original</div> | ||
| <div data-id="div-inner-computed" data-expect-no-warning inner-h-t-m-l={computed}>original</div> | ||
| <div data-id="div-inner-spread" lwc:spread={spread}>original</div> | ||
|
|
||
| <span lwc:inner-html="lwc:inner-html"></span> | ||
| <p lwc:inner-html={computed}></p> | ||
| </template> |
File renamed without changes.
7 changes: 7 additions & 0 deletions
7
...ges/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/inner-external/config.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "entry": "x/inner", | ||
| "ssrFiles": { | ||
| "error": "error-ssr.txt", | ||
| "expected": "expected-ssr.html" | ||
| } | ||
| } |
1 change: 1 addition & 0 deletions
1
...s/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/inner-external/error-ssr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Cannot set attribute "inner-h-t-m-l" on <omg-whatever>. |
Empty file.
Empty file.
13 changes: 13 additions & 0 deletions
13
...s/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/inner-external/expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <fixture-test> | ||
| <template shadowrootmode="open"> | ||
| <omg-whatever data-id="external-inner-static" inner-h-t-m-l="replaced"> | ||
| original | ||
| </omg-whatever> | ||
| <omg-whatever data-id="external-inner-computed" inner-h-t-m-l="injected"> | ||
| original | ||
| </omg-whatever> | ||
| <omg-whatever data-id="external-inner-spread"> | ||
| original | ||
| </omg-whatever> | ||
| </template> | ||
| </fixture-test> |
5 changes: 5 additions & 0 deletions
5
...-server/src/__tests__/fixtures/inner-outer-html/inner-external/modules/x/inner/inner.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <template> | ||
| <omg-whatever lwc:external data-id="external-inner-static" inner-h-t-m-l="replaced">original</omg-whatever> | ||
| <omg-whatever lwc:external data-id="external-inner-computed" inner-h-t-m-l={computed}>original</omg-whatever> | ||
| <omg-whatever lwc:external data-id="external-inner-spread" lwc:spread={spread}>original</omg-whatever> | ||
| </template> |
5 changes: 5 additions & 0 deletions
5
...ne-server/src/__tests__/fixtures/inner-outer-html/inner-external/modules/x/inner/inner.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { LightningElement } from 'lwc'; | ||
|
|
||
| export default class extends LightningElement { | ||
| computed = 'injected'; | ||
| } |
7 changes: 7 additions & 0 deletions
7
packages/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/inner-lwc/config.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "entry": "x/inner", | ||
| "ssrFiles": { | ||
| "error": "error-ssr.txt", | ||
| "expected": "expected-ssr.html" | ||
| } | ||
| } |
Empty file.
Empty file.
25 changes: 25 additions & 0 deletions
25
...es/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/inner-lwc/expected-ssr.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <fixture-test> | ||
| <template shadowrootmode="open"> | ||
| <x-component data-id="cmp-inner-static"> | ||
| <template shadowrootmode="open"> | ||
| <slot> | ||
| </slot> | ||
| </template> | ||
| original | ||
| </x-component> | ||
| <x-component data-id="cmp-inner-computed"> | ||
| <template shadowrootmode="open"> | ||
| <slot> | ||
| </slot> | ||
| </template> | ||
| original | ||
| </x-component> | ||
| <x-component data-id="cmp-inner-spread"> | ||
| <template shadowrootmode="open"> | ||
| <slot> | ||
| </slot> | ||
| </template> | ||
| original | ||
| </x-component> | ||
| </template> | ||
| </fixture-test> |
25 changes: 25 additions & 0 deletions
25
packages/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/inner-lwc/expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <fixture-test> | ||
| <template shadowrootmode="open"> | ||
| <x-component data-id="cmp-inner-static"> | ||
| <template shadowrootmode="open"> | ||
| <slot> | ||
| </slot> | ||
| </template> | ||
| original | ||
| </x-component> | ||
| <x-component data-id="cmp-inner-computed"> | ||
| <template shadowrootmode="open"> | ||
| <slot> | ||
| </slot> | ||
| </template> | ||
| original | ||
| </x-component> | ||
| <x-component data-id="cmp-inner-spread"> | ||
| <template shadowrootmode="open"> | ||
| <slot> | ||
| </slot> | ||
| </template> | ||
| original | ||
| </x-component> | ||
| </template> | ||
| </fixture-test> |
File renamed without changes.
3 changes: 3 additions & 0 deletions
3
...server/src/__tests__/fixtures/inner-outer-html/inner-lwc/modules/x/component/component.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import { LightningElement } from 'lwc'; | ||
|
|
||
| export default class extends LightningElement {} |
5 changes: 5 additions & 0 deletions
5
...ngine-server/src/__tests__/fixtures/inner-outer-html/inner-lwc/modules/x/inner/inner.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <template> | ||
| <x-component data-id="cmp-inner-static" inner-h-t-m-l="replaced">original</x-component> | ||
| <x-component data-id="cmp-inner-computed" inner-h-t-m-l={computed}>original</x-component> | ||
| <x-component data-id="cmp-inner-spread" lwc:spread={spread}>original</x-component> | ||
| </template> |
6 changes: 6 additions & 0 deletions
6
.../engine-server/src/__tests__/fixtures/inner-outer-html/inner-lwc/modules/x/inner/inner.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import { LightningElement } from 'lwc'; | ||
|
|
||
| export default class extends LightningElement { | ||
| computed = 'injected'; | ||
| spread = { innerHTML: 'wheeeeeeeeeeeeeeeeeeeeeeeeeee' }; | ||
| } |
28 changes: 0 additions & 28 deletions
28
...ges/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/modules/x/inner/inner.html
This file was deleted.
Oops, something went wrong.
7 changes: 7 additions & 0 deletions
7
packages/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/outer-div/config.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "entry": "x/outer", | ||
| "ssrFiles": { | ||
| "error": "error-ssr.txt", | ||
| "expected": "expected-ssr.html" | ||
| } | ||
| } |
1 change: 1 addition & 0 deletions
1
packages/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/outer-div/error-ssr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Cannot set attribute "outer-h-t-m-l" on <div>. |
Empty file.
Empty file.
19 changes: 19 additions & 0 deletions
19
packages/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/outer-div/expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <fixture-test> | ||
| <template shadowrootmode="open"> | ||
| <div data-expect-no-warning data-id="div-outer-static" outer-h-t-m-l="replaced"> | ||
| original | ||
| </div> | ||
| <div data-expect-no-warning data-id="div-outer-computed" outer-h-t-m-l="injected"> | ||
| original | ||
| </div> | ||
| <div data-id="div-outer-spread"> | ||
| original | ||
| </div> | ||
| <span> | ||
| lwc:inner-html | ||
| </span> | ||
| <p> | ||
| injected | ||
| </p> | ||
| </template> | ||
| </fixture-test> |
8 changes: 8 additions & 0 deletions
8
...ngine-server/src/__tests__/fixtures/inner-outer-html/outer-div/modules/x/outer/outer.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <template> | ||
| <div data-id="div-outer-static" data-expect-no-warning outer-h-t-m-l="replaced">original</div> | ||
| <div data-id="div-outer-computed" data-expect-no-warning outer-h-t-m-l={computed}>original</div> | ||
| <div data-id="div-outer-spread" lwc:spread={spread}>original</div> | ||
|
|
||
| <span lwc:inner-html="lwc:inner-html"></span> | ||
| <p lwc:inner-html={computed}></p> | ||
| </template> |
6 changes: 6 additions & 0 deletions
6
.../engine-server/src/__tests__/fixtures/inner-outer-html/outer-div/modules/x/outer/outer.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import { LightningElement } from 'lwc'; | ||
|
|
||
| export default class extends LightningElement { | ||
| computed = 'injected'; | ||
| spread = { innerHTML: 'wheeeeeeeeeeeeeeeeeeeeeeeeeee' }; | ||
| } |
7 changes: 7 additions & 0 deletions
7
...ges/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/outer-external/config.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "entry": "x/outer", | ||
| "ssrFiles": { | ||
| "error": "error-ssr.txt", | ||
| "expected": "expected-ssr.html" | ||
| } | ||
| } |
1 change: 1 addition & 0 deletions
1
...s/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/outer-external/error-ssr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Cannot set attribute "outer-h-t-m-l" on <omg-whatever>. |
Empty file.
Empty file.
13 changes: 13 additions & 0 deletions
13
...s/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/outer-external/expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <fixture-test> | ||
| <template shadowrootmode="open"> | ||
| <omg-whatever data-id="external-outer-static"> | ||
| original | ||
| </omg-whatever> | ||
| <omg-whatever data-id="external-outer-computed"> | ||
| original | ||
| </omg-whatever> | ||
| <omg-whatever data-id="external-outer-spread"> | ||
| original | ||
| </omg-whatever> | ||
| </template> | ||
| </fixture-test> |
5 changes: 5 additions & 0 deletions
5
...-server/src/__tests__/fixtures/inner-outer-html/outer-external/modules/x/outer/outer.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <template> | ||
| <omg-whatever lwc:external data-id="external-outer-static" outer-h-t-m-l="replaced">original</omg-whatever> | ||
| <omg-whatever lwc:external data-id="external-outer-computed" outer-h-t-m-l={computed}>original</omg-whatever> | ||
| <omg-whatever lwc:external data-id="external-outer-spread" lwc:spread={spread}>original</omg-whatever> | ||
| </template> |
6 changes: 6 additions & 0 deletions
6
...ne-server/src/__tests__/fixtures/inner-outer-html/outer-external/modules/x/outer/outer.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import { LightningElement } from 'lwc'; | ||
|
|
||
| export default class extends LightningElement { | ||
| computed = 'injected'; | ||
| spread = { innerHTML: 'wheeeeeeeeeeeeeeeeeeeeeeeeeee' }; | ||
| } |
3 changes: 3 additions & 0 deletions
3
packages/@lwc/engine-server/src/__tests__/fixtures/inner-outer-html/outer-lwc/config.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "entry": "x/outer" | ||
| } |
Empty file.
Oops, something went wrong.