fix: vitest prod mode compat

Author: jhefferman-sfdc

package.json

@@ -20,6 +20,7 @@
         "dev": "nx run-many --target=dev --all --parallel=999 --exclude=@lwc/perf-benchmarks,@lwc/perf-benchmarks-components,@lwc/integration-tests",
         "test": "vitest --workspace vitest.workspace.mjs",
         "test:production": "VITE_NODE_ENV=production vitest --workspace vitest.workspace.mjs",
+        "test:production:debug": "VITE_NODE_ENV=production vitest --workspace vitest.workspace.mjs  --no-file-parallelism --inspect-brk",
         "test:bespoke": "nx run-many --target=test",
         "test:debug": "vitest --workspace vitest.workspace.mjs --inspect-brk --no-file-parallelism",
         "test:ci": "vitest run --workspace vitest.workspace.mjs --coverage",

packages/@lwc/engine-core/src/framework/__tests__/context.spec.ts

@@ -4,13 +4,12 @@
  * SPDX-License-Identifier: MIT
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
-import { describe, it, expect, vi, beforeAll, afterEach } from 'vitest';
-import { setFeatureFlagForTest } from '@lwc/features';
+import { describe, it, expect, vi, beforeAll, afterEach, afterAll } from 'vitest';
 import { setTrustedContextSet, setContextKeys } from '@lwc/shared';
 import { logWarnOnce } from '../../shared/logger';
 import { connectContext, disconnectContext } from '../modules/context';
 
-// Mock the logger to avoid console output during tests
+// Mock the logger to inspect console output during tests
 vi.mock('../../shared/logger', () => ({
     logWarnOnce: vi.fn(),
 }));
@@ -33,6 +32,17 @@ const mockVM = {
     renderer: mockRenderer,
 } as any;
 
+if (!(globalThis as any).lwcRuntimeFlags) {
+    Object.defineProperty(globalThis, 'lwcRuntimeFlags', { value: {} });
+}
+
+/**
+ * Need to be able to set and reset the flags at will (lwc/features doesn't provide this)
+ */
+const setFeatureFlag = (name: string, value: boolean) => {
+    (globalThis as any).lwcRuntimeFlags[name] = value;
+};
+
 /**
  * These tests test that properties are correctly validated within the connectContext and disconnectContext
  * functions regardless of whether trusted context has been defined or not.
@@ -50,31 +60,35 @@ describe('context functions', () => {
         vi.clearAllMocks();
     });
 
+    afterAll(() => {
+        setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
+    });
+
     describe('without setting trusted context', () => {
         it('should log a warning when trustedContext is not defined and connectContext is called with legacy signal context validation', () => {
-            setFeatureFlagForTest('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', true);
+            setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', true);
             connectContext(mockVM);
             expect(logWarnOnce).toHaveBeenCalledWith(
                 'Attempted to connect to trusted context but received the following error: component[contextfulKeys[i]][connectContext2] is not a function'
             );
         });
 
         it('should not log a warning when trustedContext is not defined and connectContext is called with non-legacy context validation', () => {
-            setFeatureFlagForTest('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
+            setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
             connectContext(mockVM);
             expect(logWarnOnce).not.toHaveBeenCalled();
         });
 
         it('should log a warning when trustedContext is not defined and disconnectContext is called with legacy signal context validation', () => {
-            setFeatureFlagForTest('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', true);
+            setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', true);
             disconnectContext(mockVM);
             expect(logWarnOnce).toHaveBeenCalledWith(
                 'Attempted to disconnect from trusted context but received the following error: component[contextfulKeys[i]][disconnectContext2] is not a function'
             );
         });
 
         it('should not log a warning when trustedContext is not defined and disconnectContext is called with non-legacy context validation', () => {
-            setFeatureFlagForTest('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
+            setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
             disconnectContext(mockVM);
             expect(logWarnOnce).not.toHaveBeenCalled();
         });
@@ -83,10 +97,10 @@ describe('context functions', () => {
     describe('with trusted context set', () => {
         it('should not log warnings when trustedContext is defined', () => {
             setTrustedContextSet(new WeakSet());
-            setFeatureFlagForTest('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', true);
+            setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', true);
             connectContext(mockVM);
             disconnectContext(mockVM);
-            setFeatureFlagForTest('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
+            setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
             expect(logWarnOnce).not.toHaveBeenCalled();
         });
     });

packages/@lwc/engine-core/src/framework/__tests__/mutation-tracker.spec.ts

@@ -6,7 +6,6 @@
  */
 import { describe, it, expect, vi, afterEach, beforeEach, afterAll, beforeAll } from 'vitest';
 import { setTrustedSignalSet } from '@lwc/shared';
-import { setFeatureFlagForTest } from '@lwc/features';
 import { componentValueObserved } from '../../framework/mutation-tracker';
 
 // Create a mock VM object with required properties
@@ -17,6 +16,17 @@ const mockVM = {
     },
 } as any;
 
+if (!(globalThis as any).lwcRuntimeFlags) {
+    Object.defineProperty(globalThis, 'lwcRuntimeFlags', { value: {} });
+}
+
+/**
+ * Need to be able to set and reset the flags at will (lwc/features doesn't provide this)
+ */
+const setFeatureFlag = (name: string, value: boolean) => {
+    (globalThis as any).lwcRuntimeFlags[name] = value;
+};
+
 /**
  * These tests check that properties are correctly validated within the mutation-tracker
  * regardless of whether trusted context has been defined by a state manager or not.
@@ -25,40 +35,40 @@ const mockVM = {
  */
 describe('mutation-tracker', () => {
     it('should not throw when componentValueObserved is called using the new signals validation and no signal set is defined', () => {
-        setFeatureFlagForTest('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
+        setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
         expect(() => {
             componentValueObserved(mockVM, 'testKey', {});
         }).not.toThrow();
     });
 
     it('should throw when componentValueObserved is called using legacy signals validation and no signal set has been defined', () => {
-        setFeatureFlagForTest('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', true);
+        setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', true);
         expect(() => {
             componentValueObserved(mockVM, 'testKey', {});
         }).toThrow();
     });
 
     it('should not throw when a trusted signal set is defined abd componentValueObserved is called', () => {
         setTrustedSignalSet(new WeakSet());
-
-        setFeatureFlagForTest('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
+        setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
         expect(() => {
             componentValueObserved(mockVM, 'testKey', {});
         }).not.toThrow();
 
-        setFeatureFlagForTest('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', true);
+        setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', true);
         expect(() => {
             componentValueObserved(mockVM, 'testKey', {});
         }).not.toThrow();
     });
 
     beforeAll(() => {
-        setFeatureFlagForTest('ENABLE_EXPERIMENTAL_SIGNALS', true);
+        setFeatureFlag('ENABLE_EXPERIMENTAL_SIGNALS', true);
+        setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', true);
     });
 
     afterAll(() => {
-        setFeatureFlagForTest('ENABLE_EXPERIMENTAL_SIGNALS', false);
-        setFeatureFlagForTest('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
+        setFeatureFlag('ENABLE_EXPERIMENTAL_SIGNALS', false);
+        setFeatureFlag('ENABLE_LEGACY_SIGNAL_CONTEXT_VALIDATION', false);
     });
 
     beforeEach(() => {