fix: additional testing around ssr specific codepaths

jhefferman-sfdc · jhefferman-sfdc · commit aaffccf99da1 · 2025-09-24T14:02:19.000-06:00
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-dynamic-complex/expected-ssr.html b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-dynamic-complex/expected-ssr.html
@@ -0,0 +1,6 @@
+<fixture-test>
+  <template shadowrootmode="open">
+    <div class="foobar">
+    </div>
+  </template>
+</fixture-test>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/config.json b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/config.json
@@ -0,0 +1,8 @@
+{
+    "entry": "x/for-each-block",
+    "experimentalComplexExpressions": true,
+    "ssrFiles": {
+        "expected": "expected-ssr.html",
+        "error": "error-ssr.txt"
+    }
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/error-ssr.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/error-ssr.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/error.txt
@@ -0,0 +1 @@
+LWC1034: Ambiguous attribute value for:each="{list()}". If you want to make it a valid identifier you should remove the surrounding quotes for:each={list()}. If you want to make it a string you should escape it for:each="\{list()}".
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/expected-ssr.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/expected-ssr.html
@@ -0,0 +1,15 @@
+<fixture-test>
+  <template shadowrootmode="open">
+    <ul>
+      <li>
+        0 - paris
+      </li>
+      <li>
+        1 - london
+      </li>
+      <li>
+        2 - tokyo
+      </li>
+    </ul>
+  </template>
+</fixture-test>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/modules/x/for-each-block/for-each-block.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/modules/x/for-each-block/for-each-block.html
@@ -0,0 +1,7 @@
+<template>
+    <ul>
+        <template for:each="{list()}" for:item="item" for:index="index">
+            <li key={item}>{index} - {item}</li>
+        </template>
+    </ul>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/modules/x/for-each-block/for-each-block.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/complex/modules/x/for-each-block/for-each-block.js
@@ -0,0 +1,7 @@
+import { LightningElement } from 'lwc';
+
+export default class Component extends LightningElement {
+    list() {
+        return ['paris', 'london', 'tokyo'];
+    }
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/config.json b/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/config.json
@@ -0,0 +1,8 @@
+{
+    "entry": "x/component",
+    "experimentalComplexExpressions": true,
+    "ssrFiles": {
+        "expected": "expected-ssr.html",
+        "error": "error-ssr.txt"
+    }
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/error-ssr.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/error-ssr.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/error.txt
@@ -0,0 +1 @@
+LWC1034: Ambiguous attribute value lwc:if="{isTrue()}". If you want to make it a valid identifier you should remove the surrounding quotes lwc:if={isTrue()}. If you want to make it a string you should escape it lwc:if="\{isTrue()}".
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/expected-ssr.html b/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/expected-ssr.html
@@ -0,0 +1,10 @@
+<fixture-test>
+  <template shadowrootmode="open">
+    <!---->
+    I am true!
+    <!---->
+    <!---->
+    I am not false!
+    <!---->
+  </template>
+</fixture-test>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/modules/x/component/component.html b/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/modules/x/component/component.html
@@ -0,0 +1,15 @@
+<template>
+    <template lwc:if="{isTrue()}">
+        I am true!
+    </template>
+    <template lwc:else>
+        I am not true!
+    </template>
+
+    <template lwc:if="{isFalse()}">
+        I am false!
+    </template>
+    <template lwc:else>
+        I am not false!
+    </template>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/modules/x/component/component.js b/packages/@lwc/engine-server/src/__tests__/fixtures/lwc-if-else-complex/modules/x/component/component.js
@@ -0,0 +1,11 @@
+import { LightningElement } from 'lwc';
+
+export default class IfBlock extends LightningElement {
+    isTrue() {
+        return true;
+    }
+
+    isFalse() {
+        return this.false;
+    }
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/config.json b/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/config.json
@@ -0,0 +1,8 @@
+{
+    "entry": "x/complexParent",
+    "experimentalComplexExpressions": true,
+    "ssrFiles": {
+        "expected": "expected-ssr.html",
+        "error": "error-ssr.txt"
+    }
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/error-ssr.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/error-ssr.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/error.txt
@@ -0,0 +1 @@
+LWC1060: Template expression doesn't allow CallExpression
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/expected-ssr.html b/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/expected-ssr.html
@@ -0,0 +1,15 @@
+<fixture-test>
+  <template shadowrootmode="open">
+    <x-complex-child>
+      <div>
+        <!---->
+        <!---->
+        <span>
+          99 - ssr
+        </span>
+        <!---->
+        <!---->
+      </div>
+    </x-complex-child>
+  </template>
+</fixture-test>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/modules/x/complexChild/complexChild.html b/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/modules/x/complexChild/complexChild.html
@@ -0,0 +1,5 @@
+<template lwc:render-mode="light">
+    <div>
+        <slot lwc:slot-bind="{itemFn()}">Default slot content</slot>
+    </div>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/modules/x/complexChild/complexChild.js b/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/modules/x/complexChild/complexChild.js
@@ -0,0 +1,8 @@
+import { LightningElement } from 'lwc';
+
+export default class Child extends LightningElement {
+    static renderMode = 'light';
+    itemFn() {
+        return () => ({ id: 99, name: 'ssr' });
+    }
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/modules/x/complexParent/complexParent.html b/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/modules/x/complexParent/complexParent.html
@@ -0,0 +1,7 @@
+<template>
+    <x-complex-child>
+        <template lwc:slot-data="itemFn">
+            <span>{itemFn().id} - {itemFn().name}</span>
+        </template>
+    </x-complex-child>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/modules/x/complexParent/complexParent.js b/packages/@lwc/engine-server/src/__tests__/fixtures/scoped-slots/complex/modules/x/complexParent/complexParent.js
@@ -0,0 +1,3 @@
+import { LightningElement } from 'lwc';
+
+export default class Parent extends LightningElement {}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/text-interpolation-complex/expected-ssr.html b/packages/@lwc/engine-server/src/__tests__/fixtures/text-interpolation-complex/expected-ssr.html
@@ -0,0 +1,7 @@
+<fixture-test>
+  <template shadowrootmode="open">
+    <p>
+      foo bar bar foo
+    </p>
+  </template>
+</fixture-test>
diff --git a/packages/@lwc/template-compiler/src/__tests__/fixtures/expression-complex/valid/object-expr/actual.html b/packages/@lwc/template-compiler/src/__tests__/fixtures/expression-complex/valid/object-expr/actual.html
@@ -1,7 +1,5 @@
 <template>
-    <ul>
-        <template for:each="{list()}" for:item="item" for:index="index">
-            <li key={item}>{index} - {item}</li>
-        </template>
-    </ul>
-</template>
+    <section>
+        <x-pert attr="{({ obj: 'literal' })}">{({ obj: 'literal'}).toString()}</x-pert>
+    </section>
+</template>
diff --git a/packages/@lwc/template-compiler/src/__tests__/fixtures/expression-complex/valid/object-expr/ast.json b/packages/@lwc/template-compiler/src/__tests__/fixtures/expression-complex/valid/object-expr/ast.json
diff --git a/packages/@lwc/template-compiler/src/__tests__/fixtures/expression-complex/valid/object-expr/expected.js b/packages/@lwc/template-compiler/src/__tests__/fixtures/expression-complex/valid/object-expr/expected.js

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+LWC1034: Ambiguous attribute value for:each="{list()}". If you want to make it a valid identifier you should remove the surrounding quotes for:each={list()}. If you want to make it a string you should escape it for:each="\{list()}".`