Merge branch 'master' into dependabot/npm_and_yarn/theoretically-non-breaking-bf07d3febe

Author: wjhsf

.nucleus.yaml

@@ -0,0 +1,64 @@
+core-deploy:
+    enabled: true
+    project-modules:
+        lwc: lwc.version
+branches:
+    ~DEFAULT~:
+        pull-request: &branch-definition
+            workflow: build-and-test
+            auto-start: true
+            auto-start-from-forks: false
+            merge-method: disabled # do not auto-merge; we'll do it ourselves
+            required-downstream-deps:
+                - BuilderFramework/builder-framework-salesforce
+                - MobilePlatform/lsdk-modules
+                - MobilePlatform/lwr-lightning-platform
+                - MobilePlatform/ui-fsm-components
+                - automation-platform/ui-externalservices-builder-components
+                - communities/microsite-template-marketing
+                - communities/shared-experience-components
+                - communities/ui-commerce-components
+                - communities/webruntime
+                - lds/lds-plugins
+                - salesforce-experience-platform-emu/komaci
+                - salesforce-experience-platform-emu/locker-pentest-app
+                - salesforce-experience-platform-emu/lwr
+                - salesforce-experience-platform-emu/lwr-everywhere
+                - salesforce-experience-platform-emu/lwr-recipes
+                - salesforce/lwc-test
+                # Using old major versions; tests in PRs will always fail
+                # - salesforce/o11y-sample-app
+                # - Skilling-and-Enablement/ui-external-enablement
+    release:
+        pull-request:
+            <<: *branch-definition
+    # Only active branches need to be included in this config
+    winter26:
+        pull-request:
+            <<: *branch-definition
+    spring25:
+        pull-request:
+            <<: *branch-definition
+    summer25:
+        pull-request:
+            <<: *branch-definition
+jobs:
+    build-and-test:
+        memory-limit: 16
+    create-canary-release:
+        memory-limit: 16
+    build-dependency:
+        memory-limit: 16
+    release:
+        memory-limit: 16
+steps:
+    node-conformance:
+        run:
+            command: yarn run lint
+        after: node-build
+    node-unit-tests:
+        run:
+            command: yarn test
+    # this project runs yarn build after yarn install so skip explicit build step
+    node-build: &node-build
+        skip: true

eslint.config.mjs

@@ -361,16 +361,9 @@ export default tseslint.config(
             globals: {
                 lwcRuntimeFlags: true,
                 process: true,
-                TestUtils: true,
                 ...globals.browser,
-                ...globals.jasmine,
             },
         },
-
-        rules: {
-            'no-var': 'off',
-            'prefer-rest-params': 'off',
-        },
     },
     {
         files: ['packages/@lwc/integration-karma/**'],
@@ -385,11 +378,6 @@ export default tseslint.config(
                 ...globals.jasmine,
             },
         },
-
-        rules: {
-            'no-var': 'off',
-            'prefer-rest-params': 'off',
-        },
     },
     {
         files: ['packages/@lwc/synthetic-shadow/**'],

packages/@lwc/integration-not-karma/configs/plugins/serve-hydration.js

@@ -50,7 +50,7 @@ async function compileModule(input, targetSSR, format) {
             }),
         ],
 
-        external: ['lwc', '@lwc/ssr-runtime', 'test-utils', '@test/loader'], // @todo: add ssr modules for test-utils and @test/loader
+        external: ['lwc', '@lwc/ssr-runtime'],
 
         onwarn(warning, warn) {
             // Ignore warnings from our own Rollup plugin

packages/@lwc/integration-not-karma/configs/plugins/serve-integration.js

@@ -84,12 +84,9 @@ const transform = async (ctx) => {
         cache,
         plugins: [customLwcRollupPlugin],
 
-        // Rollup should not attempt to resolve the engine and the test utils, Karma takes care of injecting it
-        // globally in the page before running the tests.
         external: [
             'lwc',
             'wire-service',
-            '@test/loader',
             // Some helper files export functions that mutate a global state. The setup file calls
             // some of those functions and does not get bundled. Including the helper files in the
             // bundle would create a separate global state, causing tests to fail. We don't need to

packages/@lwc/integration-not-karma/helpers/jasmine.js

@@ -0,0 +1,37 @@
+import { spyOn, fn } from '@vitest/spy';
+
+/**
+ * Adds the jasmine interfaces we use in the Karma tests to a Vitest spy.
+ * Should ultimately be removed and tests updated to use Vitest spies.
+ * @param {import('@vitest/spy').MockInstance}
+ */
+function jasmineSpyAdapter(spy) {
+    Object.defineProperties(spy, {
+        and: { get: () => spy },
+        calls: { get: () => spy.mock.calls },
+        returnValue: { value: () => spy.mockReturnValue() },
+        // calling mockImplementation() with nothing restores the original
+        callThrough: { value: () => spy.mockImplementation() },
+        callFake: { value: (impl) => spy.mockImplementation(impl) },
+    });
+
+    Object.defineProperties(spy.mock.calls, {
+        // Must be non-enumerable for equality checks to work on array literal expected values
+        allArgs: { value: () => spy.mock.calls },
+        count: { value: () => spy.mock.calls.length },
+        reset: { value: () => spy.mockReset() },
+        argsFor: { value: (index) => spy.mock.calls.at(index) },
+    });
+
+    return spy;
+}
+
+export const jasmineSpyOn = (object, prop) => jasmineSpyAdapter(spyOn(object, prop));
+export const jasmine = {
+    any: expect.any,
+    arrayWithExactContents: () => {
+        throw new Error('TODO: jasmine.arrayWithExactContents');
+    },
+    createSpy: (name, impl) => jasmineSpyAdapter(fn(impl)),
+    objectContaining: expect.objectContaining,
+};

packages/@lwc/integration-not-karma/helpers/reporting-control.js

@@ -0,0 +1,18 @@
+import { __unstable__ReportingControl } from 'lwc';
+
+/**
+ *
+ * @param dispatcher
+ * @param runtimeEvents List of runtime events to filter by. If no list is provided, all events will be dispatched.
+ */
+export function attachReportingControlDispatcher(dispatcher, runtimeEvents) {
+    __unstable__ReportingControl.attachDispatcher((eventName, payload) => {
+        if (!runtimeEvents || runtimeEvents.includes(eventName)) {
+            dispatcher(eventName, payload);
+        }
+    });
+}
+
+export function detachReportingControlDispatcher() {
+    __unstable__ReportingControl.detachDispatcher();
+}

packages/@lwc/integration-not-karma/helpers/setup.js

@@ -1,17 +1,11 @@
 // This import ensures that the global `Mocha` object is present for mutation.
 import { JestAsymmetricMatchers, JestChaiExpect, JestExtend } from '@vitest/expect';
 import * as chai from 'chai';
-import { spyOn, fn } from '@vitest/spy';
 import { registerCustomMatchers } from './matchers/index.js';
-import * as TestUtils from './utils.js';
 import { initSignals } from './signals.js';
 
 initSignals();
 
-// FIXME: As a relic of the Karma tests, some test files rely on the global object,
-// rather than importing from `test-utils`.
-window.TestUtils = TestUtils;
-
 // allows using expect.extend instead of chai.use to extend plugins
 chai.use(JestExtend);
 // adds all jest matchers to expect
@@ -20,44 +14,8 @@ chai.use(JestChaiExpect);
 chai.use(JestAsymmetricMatchers);
 // add our custom matchers
 chai.use(registerCustomMatchers);
-
-/**
- * Adds the jasmine interfaces we use in the Karma tests to a Vitest spy.
- * Should ultimately be removed and tests updated to use Vitest spies.
- * @param {import('@vitest/spy').MockInstance}
- */
-function jasmineSpyAdapter(spy) {
-    Object.defineProperties(spy, {
-        and: { get: () => spy },
-        calls: { get: () => spy.mock.calls },
-        returnValue: { value: () => spy.mockReturnValue() },
-        // calling mockImplementation() with nothing restores the original
-        callThrough: { value: () => spy.mockImplementation() },
-        callFake: { value: (impl) => spy.mockImplementation(impl) },
-    });
-
-    Object.defineProperties(spy.mock.calls, {
-        // Must be non-enumerable for equality checks to work on array literal expected values
-        allArgs: { value: () => spy.mock.calls },
-        count: { value: () => spy.mock.calls.length },
-        reset: { value: () => spy.mockReset() },
-        argsFor: { value: (index) => spy.mock.calls.at(index) },
-    });
-
-    return spy;
-}
-
 // expose so we don't need to import `expect` in every test file
 globalThis.expect = chai.expect;
-globalThis.spyOn = (object, prop) => jasmineSpyAdapter(spyOn(object, prop));
-globalThis.jasmine = {
-    any: expect.any,
-    arrayWithExactContents: () => {
-        throw new Error('TODO: jasmine.arrayWithExactContents');
-    },
-    createSpy: (name, impl) => jasmineSpyAdapter(fn(impl)),
-    objectContaining: expect.objectContaining,
-};
 
 /**
  * `@web/test-runner-mocha`'s autorun.js file inlines its own copy of mocha, and there's no direct

packages/@lwc/integration-not-karma/helpers/utils.js

@@ -1,7 +1,6 @@
 /*
  * An as yet uncategorized mishmash of helpers, relics of Karma
  */
-import { __unstable__ReportingControl } from 'lwc';
 
 // Listen for errors thrown directly by the callback
 function directErrorListener(callback) {
@@ -47,23 +46,6 @@ export function customElementCallbackReactionErrorListener(callback) {
         : windowErrorListener(callback);
 }
 
-/**
- *
- * @param dispatcher
- * @param runtimeEvents List of runtime events to filter by. If no list is provided, all events will be dispatched.
- */
-export function attachReportingControlDispatcher(dispatcher, runtimeEvents) {
-    __unstable__ReportingControl.attachDispatcher((eventName, payload) => {
-        if (!runtimeEvents || runtimeEvents.includes(eventName)) {
-            dispatcher(eventName, payload);
-        }
-    });
-}
-
-export function detachReportingControlDispatcher() {
-    __unstable__ReportingControl.detachDispatcher();
-}
-
 export function extractDataIds(root) {
     const nodes = {};
 

packages/@lwc/integration-not-karma/test-hydration/attributes/falsy-mismatch/index.spec.js

@@ -1,3 +1,5 @@
+import { expectConsoleCallsDev } from '../../../helpers/utils.js';
+
 export default {
     props: {
         isFalse: false,
@@ -28,7 +30,7 @@ export default {
             expect(divs[i].getAttribute('data-foo')).toEqual(expectedAttrValues[i]);
         }
 
-        TestUtils.expectConsoleCallsDev(consoleCalls, {
+        expectConsoleCallsDev(consoleCalls, {
             error: [],
             warn: [
                 'Hydration attribute mismatch on: <div> - rendered on server: data-foo=null - expected on client: data-foo="undefined"',

packages/@lwc/integration-not-karma/test-hydration/context/index.spec.js

@@ -1,3 +1,5 @@
+import { expectConsoleCalls } from '../../helpers/utils.js';
+
 export default {
     // server is expected to generate the same console error as the client
     expectedSSRConsoleCalls: {
@@ -40,7 +42,7 @@ export default {
         // Expect an error as one context was generated twice.
         // Expect an error as one context was malformed (did not define connectContext or disconnectContext methods).
         // Expect server/client context output parity (no hydration warnings)
-        TestUtils.expectConsoleCalls(consoleCalls, {
+        expectConsoleCalls(consoleCalls, {
             error: [],
             warn: [
                 'Attempted to connect to trusted context but received the following error',