Skip to content

Commit b0a3dae

Browse files
authored
Revert "chore: bump node version to v24.11.1 (#5603)" (#5606)
This reverts commit a9afc1e.
1 parent 9cc7921 commit b0a3dae

File tree

8 files changed

+8
-19
lines changed

8 files changed

+8
-19
lines changed

.github/workflows/benchmark-release.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ on:
1818
type: string
1919
required: false
2020

21-
env:
22-
NODE_VERSION: '24.11.1'
23-
2421
jobs:
2522
run-performance-tests:
2623
# It is important to use this image so that we have a consistent IP address
@@ -67,7 +64,7 @@ jobs:
6764
- name: Setup Node
6865
uses: actions/setup-node@v4
6966
with:
70-
node-version: ${{ env.NODE_VERSION }}
67+
node-version: '20.19.4'
7168
cache: 'yarn'
7269

7370
- name: Install dependencies

.github/workflows/benchmark.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ env:
1212
BEST_HUB_CLIENT_TOKEN: ${{secrets.BEST_HUB_CLIENT_TOKEN}}
1313
BEST_HUB_HOSTNAME: ${{secrets.BEST_HUB_HOSTNAME}}
1414
PUPPETEER_SKIP_DOWNLOAD: 'true' # only needed for @best/runner-local, unused here
15-
NODE_VERSION: '24.11.1'
1615

1716
jobs:
1817
run-best-performance-tests:
@@ -25,7 +24,7 @@ jobs:
2524
- name: Setup Node
2625
uses: actions/setup-node@v4
2726
with:
28-
node-version: ${{ env.NODE_VERSION }}
27+
node-version: '20.19.4'
2928
cache: 'yarn'
3029

3130
- name: Install dependencies

.github/workflows/release.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ on:
1616
description: 'OR Explicit version number (must be greater than current root version)'
1717
required: false
1818

19-
env:
20-
NODE_VERSION: '24.11.1'
21-
2219
permissions:
2320
contents: write
2421
pull-requests: write
@@ -57,7 +54,7 @@ jobs:
5754
- name: Setup Node
5855
uses: actions/setup-node@v6
5956
with:
60-
node-version: ${{ env.NODE_VERSION }}
57+
node-version: '20'
6158
registry-url: 'https://registry.npmjs.org'
6259
cache: 'yarn'
6360

.github/workflows/unit.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ on:
1919
env:
2020
PUPPETEER_SKIP_DOWNLOAD: 'true' # only needed for @best/runner-local, unused here
2121
CHROME_VERSION: 130
22-
NODE_VERSION: '24.11.1'
2322

2423
jobs:
2524
run-unit-tests:
@@ -30,7 +29,7 @@ jobs:
3029
- name: Setup Node
3130
uses: actions/setup-node@v4
3231
with:
33-
node-version: ${{ env.NODE_VERSION }}
32+
node-version: '20.19.4'
3433
cache: 'yarn'
3534
- name: Install dependencies
3635
run: yarn install --frozen-lockfile

.github/workflows/web-test-runner.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ on:
1212

1313
env:
1414
COVERAGE: '1'
15-
NODE_VERSION: '24.11.1'
15+
NODE_VERSION: '20.19.4'
1616

1717
jobs:
1818
# We run tests in parallel to speed up CI, with an arbitrary goal of ~20 minutes per job.

.github/workflows/webdriver.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ on:
1919
env:
2020
PUPPETEER_SKIP_DOWNLOAD: 'true' # only needed for @best/runner-local, unused here
2121
CHROMEDRIVER_BINARY: '../../../node_modules/chromedriver/lib/chromedriver/chromedriver' # pin wdio to local chromedriver
22-
NODE_VERSION: '24.11.1'
2322

2423
jobs:
2524
run-integration-tests:
@@ -34,7 +33,7 @@ jobs:
3433
- name: Setup Node
3534
uses: actions/setup-node@v4
3635
with:
37-
node-version: ${{ env.NODE_VERSION }}
36+
node-version: '20.19.4'
3837
cache: 'yarn'
3938

4039
# Needed for local browser integration tests

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494
"node": ">=10"
9595
},
9696
"volta": {
97-
"node": "24.11.1",
97+
"node": "20.19.4",
9898
"yarn": "1.22.22"
9999
},
100100
"resolutions": {

vitest.shared.mjs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ export default defineConfig({
1313
testTimeout: inspector.url()
1414
? // Largest allowed delay, see https://developer.mozilla.org/en-US/docs/Web/API/Window/setTimeout#maximum_delay_value
1515
2147483647
16-
: process.env.CI // Looks like we have some tests frequently timing out when code coverage is enabled
17-
? 10000
18-
: undefined,
16+
: undefined,
1917
include: ['**/*.{test,spec}.{mjs,js,ts}'],
2018
snapshotFormat: {
2119
printBasicPrototype: true,

0 commit comments

Comments
 (0)