feat: add parsing of lwc:on directive

salesforce · Feb 27, 2025 · d6a0a6a · d6a0a6a
1 parent 69bb3c2
commit d6a0a6a
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 1 deletion.
diff --git a/packages/@lwc/errors/src/compiler/error-info/index.ts b/packages/@lwc/errors/src/compiler/error-info/index.ts
@@ -5,7 +5,7 @@
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
 /**
- * Next error code: 1203
+ * Next error code: 1204
  */
 
 export * from './compiler';

diff --git a/packages/@lwc/errors/src/compiler/error-info/template-transform.ts b/packages/@lwc/errors/src/compiler/error-info/template-transform.ts
@@ -955,4 +955,12 @@ export const ParserDiagnostics = {
         level: DiagnosticLevel.Error,
         url: '',
     },
+
+    INVALID_LWC_ON_LITERAL_PROP: {
+        code: 1203,
+        message:
+            'Invalid lwc:on usage on element "{0}". The directive binding must be an expression.',
+        level: DiagnosticLevel.Error,
+        url: '',
+    },
 };
diff --git a/packages/@lwc/template-compiler/src/parser/index.ts b/packages/@lwc/template-compiler/src/parser/index.ts
@@ -884,6 +884,7 @@ const LWC_DIRECTIVE_PROCESSORS = [
     applyLwcInnerHtmlDirective,
     applyRefDirective,
     applyLwcSpreadDirective,
+    applyLwcOnDirective,
     applyLwcSlotBindDirective,
 ];
 
@@ -972,6 +973,26 @@ function applyLwcSpreadDirective(
     element.directives.push(ast.spreadDirective(lwcSpreadAttr, lwcSpread.location));
 }
 
+function applyLwcOnDirective(
+    ctx: ParserCtx,
+    parsedAttr: ParsedAttribute,
+    element: BaseElement
+): void {
+    const { name: tag } = element;
+
+    const lwcOn = parsedAttr.pick(ElementDirectiveName.On);
+    if (!lwcOn) {
+        return;
+    }
+
+    const { value: lwcOnValue } = lwcOn;
+    if (!ast.isExpression(lwcOnValue)) {
+        ctx.throwOnNode(ParserDiagnostics.INVALID_LWC_ON_LITERAL_PROP, element, [`<${tag}>`]);
+    }
+
+    element.directives.push(ast.OnDirective(lwcOnValue, lwcOn.location));
+}
+
 function applyLwcExternalDirective(
     ctx: ParserCtx,
     parsedAttr: ParsedAttribute,