Skip to content

Commit e1c8085

Browse files
nolanlawsonjmsjtu
andauthored
fix(engine-server): use standard shadowrootmode attribute (#3903)
* fix(engine-server): use standard shadowrootmode attribute * test: fix polyfill in test * test: fix test in safari --------- Co-authored-by: James Tu <[email protected]>
1 parent b1ac0aa commit e1c8085

File tree

79 files changed

+163
-153
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+163
-153
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<x-cmp aria-busy="true" aria-activedescendant="foo">
2-
<template shadowroot="open">
2+
<template shadowrootmode="open">
33
</template>
44
</x-cmp>

packages/@lwc/engine-server/src/__tests__/fixtures/attribute-aria/expected.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<x-parent>
2-
<template shadowroot="open">
2+
<template shadowrootmode="open">
33
<x-child aria-activedescendant="foo" aria-atomic="foo" aria-autocomplete="foo" aria-busy="foo" aria-checked="foo" aria-colcount="foo" aria-colindex="foo" aria-colindextext="foo" aria-colspan="foo" aria-controls="foo" aria-current="foo" aria-describedby="foo" aria-description="foo" aria-details="foo" aria-disabled="foo" aria-errormessage="foo" aria-expanded="foo" aria-flowto="foo" aria-haspopup="foo" aria-hidden="foo" aria-invalid="foo" aria-keyshortcuts="foo" aria-label="foo" aria-labelledby="foo" aria-level="foo" aria-live="foo" aria-modal="foo" aria-multiline="foo" aria-multiselectable="foo" aria-orientation="foo" aria-owns="foo" aria-placeholder="foo" aria-posinset="foo" aria-pressed="foo" aria-readonly="foo" aria-relevant="foo" aria-required="foo" aria-roledescription="foo" aria-rowcount="foo" aria-rowindex="foo" aria-rowindextext="foo" aria-rowspan="foo" aria-selected="foo" aria-setsize="foo" aria-sort="foo" aria-valuemax="foo" aria-valuemin="foo" aria-valuenow="foo" aria-valuetext="foo" aria-braillelabel="foo" aria-brailleroledescription="foo" role="foo">
4-
<template shadowroot="open">
4+
<template shadowrootmode="open">
55
</template>
66
</x-child>
77
<div aria-activedescendant="foo" aria-atomic="foo" aria-autocomplete="foo" aria-busy="foo" aria-checked="foo" aria-colcount="foo" aria-colindex="foo" aria-colindextext="foo" aria-colspan="foo" aria-controls="foo" aria-current="foo" aria-describedby="foo" aria-description="foo" aria-details="foo" aria-disabled="foo" aria-errormessage="foo" aria-expanded="foo" aria-flowto="foo" aria-haspopup="foo" aria-hidden="foo" aria-invalid="foo" aria-keyshortcuts="foo" aria-label="foo" aria-labelledby="foo" aria-level="foo" aria-live="foo" aria-modal="foo" aria-multiline="foo" aria-multiselectable="foo" aria-orientation="foo" aria-owns="foo" aria-placeholder="foo" aria-posinset="foo" aria-pressed="foo" aria-readonly="foo" aria-relevant="foo" aria-required="foo" aria-roledescription="foo" aria-rowcount="foo" aria-rowindex="foo" aria-rowindextext="foo" aria-rowspan="foo" aria-selected="foo" aria-setsize="foo" aria-sort="foo" aria-valuemax="foo" aria-valuemin="foo" aria-valuenow="foo" aria-valuetext="foo" aria-braillelabel="foo" aria-brailleroledescription="foo" role="foo">
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attribute-boolean>
2-
<template shadowroot="open">
2+
<template shadowrootmode="open">
33
<input type="checkbox" required readonly checked>
44
</template>
55
</x-attribute-boolean>

packages/@lwc/engine-server/src/__tests__/fixtures/attribute-component-aria/expected.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<x-attribute-component-aria>
2-
<template shadowroot="open">
2+
<template shadowrootmode="open">
33
<x-child role="progressbar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="20">
4-
<template shadowroot="open">
4+
<template shadowrootmode="open">
55
</template>
66
</x-child>
77
</template>

packages/@lwc/engine-server/src/__tests__/fixtures/attribute-component-global-html/expected.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<x-attribute-component-global-html>
2-
<template shadowroot="open">
2+
<template shadowrootmode="open">
33
<x-child class="foo bar" style="color: red; background: blue" data-test="test" accesskey="A" contenteditable="true" draggable="true" hidden id="foo" itemprop="foo" spellcheck="true" tabindex="-1">
4-
<template shadowroot="open">
4+
<template shadowrootmode="open">
55
Passthrough properties:
66
<ul>
77
<li>

packages/@lwc/engine-server/src/__tests__/fixtures/attribute-dynamic-escape/expected.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attribute-dynamic-escape>
2-
<template shadowroot="open">
2+
<template shadowrootmode="open">
33
<div data-attr="&quot;>
44
</div>
55
This 'should' be escaped

packages/@lwc/engine-server/src/__tests__/fixtures/attribute-dynamic-with-scoped-css/expected.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attribute-dynamic-with-scoped-css class="lwc-47oqt8q93b2-host">
2-
<template shadowroot="open">
2+
<template shadowrootmode="open">
33
<style class="lwc-47oqt8q93b2" type="text/css">
44
div.lwc-47oqt8q93b2 {color: black;}div.kree.lwc-47oqt8q93b2 {color: blue;}
55
</style>

packages/@lwc/engine-server/src/__tests__/fixtures/attribute-dynamic/expected.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attribute-dynamic>
2-
<template shadowroot="open">
2+
<template shadowrootmode="open">
33
<div class="foo" style="color: red;" data-foo="foo">
44
</div>
55
</template>

packages/@lwc/engine-server/src/__tests__/fixtures/attribute-global-html/expected.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attribute-global-html>
2-
<template shadowroot="open">
2+
<template shadowrootmode="open">
33
<div class="foo bar" style="color: red; background: blue" accesskey="A" contenteditable="true" data-test="test" draggable="true" hidden id="foo" itemprop="foo" lang="fr" spellcheck="true" tabindex="-1" title="foo">
44
</div>
55
</template>

packages/@lwc/engine-server/src/__tests__/fixtures/attribute-live-bindings/expected.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attribute-live-bindings>
2-
<template shadowroot="open">
2+
<template shadowrootmode="open">
33
<p>
44
Checked:
55
<input type="checkbox" checked>

0 commit comments

Comments
 (0)