isTrustedSignalshould return false when no trusted set has been defined#5500
Merged
jhefferman-sfdc merged 3 commits intomasterfrom Sep 17, 2025
Merged
isTrustedSignalshould return false when no trusted set has been defined#5500jhefferman-sfdc merged 3 commits intomasterfrom
jhefferman-sfdc merged 3 commits intomasterfrom
Conversation
wjhsf
approved these changes
Sep 17, 2025
| { | ||
| "path": "packages/@lwc/engine-dom/dist/index.js", | ||
| "maxSize": "25.0KB" | ||
| "maxSize": "24.73KB" |
Contributor
There was a problem hiding this comment.
That's 0.01KB more than your last PR! 📉
Contributor
Author
There was a problem hiding this comment.
sigh, "corrected"
|
|
||
| import Test from 'x/test'; | ||
| import { Signal } from 'x/signal'; | ||
| import { spyConsole } from '../../../helpers/console.js'; |
Contributor
There was a problem hiding this comment.
IMO spyConsole doesn't add any value over just using vitest's spyOn. I want to remove spyConsole eventually, but that's a problem for later.
Contributor
Author
There was a problem hiding this comment.
tech debt ftw
jmsjtu
approved these changes
Sep 17, 2025
ekashida
reviewed
Sep 18, 2025
Member
ekashida
left a comment
ekashida
left a comment
There was a problem hiding this comment.
LGTM! The bug being fixed looked obviously wrong so that was throwing me off, but it's actually the result of multiple changes made over time. Thanks for this explanation @wjhsf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
An internal Signals API is not being called in this context, as state managers are not in use. When the internal API is not called, all objects are considered signals and a warning is logged for properties that do not meet the criteria.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-19640386