Skip to content

test(wtr): remove console spy util#5512

Merged
wjhsf merged 81 commits intomasterfrom
wjh/no-spy-console
Sep 25, 2025
Merged

test(wtr): remove console spy util#5512
wjhsf merged 81 commits intomasterfrom
wjh/no-spy-console

Conversation

@wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Sep 24, 2025

Details

We don't need a util when spyOn(console, 'error') works just fine. I didn't remove it entirely from the hydration tests because it's used more indirectly (and a lot more extensively) in those, so it's more tedious to swap everything out.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

wjhsf and others added 30 commits September 2, 2025 18:01
@wjhsf
test(wtr): update tests to use relative path to utils
8c7ed79 
instead of weird fake module
@wjhsf
test(wtr): revert removing TestUtils
e2f88d5
@wjhsf
test(wtr): remove useless describe
81275d0 
There's no setup/teardown needed, it's a single test, and WTR provides per-file encapsulation
@wjhsf
test(wtr): replace IIFE script with module import
39533d3
@wjhsf
test(wtr): clean up SSR execution script
33e58c8 
working toward just importing and executing things, but not quite there yet
@wjhsf
test(wtr): always use DISABLE_SYNTHETIC
d0b8003 
two env vars for the same goal is unnecessary
@wjhsf
test(wtr): enable all hydration tests
976c002 
I think the last one was a concurrency related timeout,
which was previously addressed.
@wjhsf
Merge branch 'master' into wjh/wtr-hyd
8d39505
@wjhsf
test(wtr): remove side effect from signals helper
c66afad 
helper files shouldn't have side effects; all setup should be in the setup file
@wjhsf
test(wtr): import directly from file, not from barrel exporter
f1c50b0
@wjhsf
test(wtr): change bulk export statement to individual exports
7a73bf0
@wjhsf
test(wtr): remove unnecessary aria re-export
9b7b21b
@wjhsf
test(wtr): fix a few more ARIA util imports
9deaca2
@wjhsf
chore: move comment for nicer aesthetic
1cf1275
@wjhsf
test(wtr): remove unused option
7fc137c
@wjhsf
test(wtr): fix another ARIA util import
ae937cc
@wjhsf
test(wtr): import directly from hooks file rather than utils
9250dd5
@wjhsf
test(wtr): import directly from signals file rather than utils
d4280e8
@wjhsf
test(wtr): import directly from console helper rather than utils
bbffbf3
@wjhsf
test(wtr): import directly from constants helper rather than utils
1ef88ed
@wjhsf
test(wtr): only import what is needed from LWC
02f8ed1
@wjhsf
test(wtr): split lwc:dynamic load helpers into separate file
7a5260a
@wjhsf
test(wtr): avoid relying on global LWC
1a08a62
@wjhsf
Merge branch 'master' into wjh/wtr-smaller-utils
f14c829
@wjhsf
Merge branch 'master' into wjh/wtr-smaller-utils
289deeb
@wjhsf
test(wtr): remove unnecessary wrapping of hydration test config
b97f783
@wjhsf
test(wtr): remove test-utils logic from resolveImport
3cdb65c 
no longer necessary
@wjhsf
test(wtr): move plugin from shared config to only config that uses it
7009a26
@wjhsf
test(wtr): remove useless guid
19c1090 
all tests are run in isolation
@wjhsf
test(wtr): remove unnecessary test-utils global
5e75329
wjhsf added 24 commits September 16, 2025 16:44
@wjhsf
test(wtr): load code from known url, rather than sniffing script tag
c494abe
@wjhsf
test(wtr): convert LWC from iife to fake cjs
02ca871
@wjhsf
test(wtr): remove unnecessary wrapping
85610ff
@wjhsf
Merge branch 'master' into wjh/wtr-spam
96fa673
@wjhsf
test(wtr): data can be data, not a function
bcba665
@wjhsf
test(wtr): replace evaluate with functions that require less wrapping
b79d66b
@wjhsf
test(wtr): only fetch scripts once
3437c71
@wjhsf
test(wtr): john was here
23491ec
@wjhsf
test(wtr): add line breaks and vars for clarity
947612f
@wjhsf
test(wtr): rename variable
9fa8504 
it's just one code blob now, not multiple scripts
@wjhsf
test(wtr): fix param pass through
97ee6e9
@wjhsf
test(wtr): more cleanup
159d046
@wjhsf
test(wtr): remove outdated comment
2e8abcf
@wjhsf
test(wtr): avoid shadowing global var
d9eda1d 
ensures we never accidentally use the wrong one
@wjhsf
test(wtr): enable custom element registry tests
43818d5
@wjhsf
Merge branch 'master' into wjh/wtr-spam
ec5293d
@wjhsf
test(wtr): hoist function definition
225da98
@wjhsf
chore: use vitest spy instead of custom hack
e967569
@wjhsf
test(wtr): use vitest spy instead of custom
7112bc7
@wjhsf
test(wtr): convert test to async/await
bd7ee75
@wjhsf
Merge branch 'wjh/wtr-async-await' into wjh/no-spy-console
6764ad9
@wjhsf
test(wtr): use vitest spy instead of custom
f729461
@wjhsf
test(wtr): move util into only file that uses it
8eece7c
@wjhsf
Merge branch 'master' into wjh/no-spy-console
fe48d42
@wjhsf wjhsf requested a review from a team as a code owner September 24, 2025 20:13
@wjhsf wjhsf enabled auto-merge (squash) September 25, 2025 03:07
@wjhsf wjhsf merged commit 9e4d8af into master Sep 25, 2025
7 checks passed
@wjhsf wjhsf deleted the wjh/no-spy-console branch September 25, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhefferman-sfdc jhefferman-sfdc jhefferman-sfdc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wjhsf @jhefferman-sfdc