diff --git a/packages/@lwc/integration-not-karma/configs/plugins/serve-integration.js b/packages/@lwc/integration-not-karma/configs/plugins/serve-integration.js index 6774e54d7d..491b2fe688 100644 --- a/packages/@lwc/integration-not-karma/configs/plugins/serve-integration.js +++ b/packages/@lwc/integration-not-karma/configs/plugins/serve-integration.js @@ -118,6 +118,11 @@ export default { async serve(ctx) { if (ctx.path.endsWith('.spec.js')) { return await transform(ctx); + } else if (ctx.path === '/test_api_sanitizeAttribute') { + // The test in /test/api/sanitizeAttribute makes network requests + // The returned value doesn't matter; this is just to avoid + // unnecessary logging output + return ''; } }, }; diff --git a/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/index.spec.js b/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/index.spec.js index 7062413c7f..2a1c4ae9db 100644 --- a/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/index.spec.js +++ b/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/index.spec.js @@ -1,3 +1,7 @@ +/** + * The URLs used in test are handled by the `serve` method defined in `serve-integration.js`. + * What they serve doesn't matter, it's just to avoid a 404 warning logged to console + */ import { createElement, // Spy is created in a mock file and injected with the import map plugin @@ -49,7 +53,7 @@ scenarios.forEach(({ type, attrName, tagName, Ctor }) => { document.body.appendChild(elm); const use = elm.shadowRoot.querySelector('use'); - expect(use.getAttribute(attrName)).toBe('/foo'); + expect(use.getAttribute(attrName)).toBe('/test_api_sanitizeAttribute?foo'); }); it('receives the right parameters', () => { @@ -60,18 +64,18 @@ scenarios.forEach(({ type, attrName, tagName, Ctor }) => { 'use', 'http://www.w3.org/2000/svg', attrName, - '/foo' + '/test_api_sanitizeAttribute?foo' ); }); it('replace the original attribute value with a string', () => { - sanitizeAttributeSpy.mockReturnValue('/bar'); + sanitizeAttributeSpy.mockReturnValue('/test_api_sanitizeAttribute?bar'); const elm = createElement(tagName, { is: Ctor }); document.body.appendChild(elm); const use = elm.shadowRoot.querySelector('use'); - expect(use.getAttribute(attrName)).toBe('/bar'); + expect(use.getAttribute(attrName)).toBe('/test_api_sanitizeAttribute?bar'); }); it('replace the original attribute value with undefined', () => { diff --git a/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/hrefDynamic/hrefDynamic.js b/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/hrefDynamic/hrefDynamic.js index 04a97edd92..99a03f5d47 100644 --- a/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/hrefDynamic/hrefDynamic.js +++ b/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/hrefDynamic/hrefDynamic.js @@ -1,5 +1,5 @@ import { LightningElement } from 'lwc'; export default class extends LightningElement { - href = '/foo'; + href = '/test_api_sanitizeAttribute?foo'; } diff --git a/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/hrefStatic/hrefStatic.html b/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/hrefStatic/hrefStatic.html index 8434f1f799..3262f0704c 100644 --- a/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/hrefStatic/hrefStatic.html +++ b/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/hrefStatic/hrefStatic.html @@ -1,5 +1,5 @@ diff --git a/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/xlinkDynamic/xlinkDynamic.js b/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/xlinkDynamic/xlinkDynamic.js index 04a97edd92..99a03f5d47 100644 --- a/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/xlinkDynamic/xlinkDynamic.js +++ b/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/xlinkDynamic/xlinkDynamic.js @@ -1,5 +1,5 @@ import { LightningElement } from 'lwc'; export default class extends LightningElement { - href = '/foo'; + href = '/test_api_sanitizeAttribute?foo'; } diff --git a/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/xlinkStatic/xlinkStatic.html b/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/xlinkStatic/xlinkStatic.html index 5774b665c3..514618b6a4 100644 --- a/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/xlinkStatic/xlinkStatic.html +++ b/packages/@lwc/integration-not-karma/test/api/sanitizeAttribute/x/xlinkStatic/xlinkStatic.html @@ -1,5 +1,5 @@