Skip to content

test(wtr): handle endpoint to make logs quieter @W-19098252#5518

Merged
wjhsf merged 1 commit intomasterfrom
wjh/wtr-sanitize-attribute-shh
Sep 26, 2025
Merged

test(wtr): handle endpoint to make logs quieter @W-19098252#5518
wjhsf merged 1 commit intomasterfrom
wjh/wtr-sanitize-attribute-shh

Conversation

@wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Sep 26, 2025

Details

Without this change, every test run includes this log output:

 test/api/sanitizeAttribute/index.spec.js:

 🚧 404 network requests:
    - foo
    - bar

We don't care about the network requests, so that's just noise. This PR adds handling to make that noise go away. The extra logic can't be encapsulated within the single test, and it's kind of indirect "magic", so I changed the name of the endpoint to try to make the connection between the two a bit more obvious.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf changed the title test(wtr): handle endpoint to make logs quieter test(wtr): handle endpoint to make logs quieter @W-19098252 Sep 26, 2025
@wjhsf wjhsf marked this pull request as ready for review September 26, 2025 15:05
@wjhsf wjhsf requested a review from a team as a code owner September 26, 2025 15:05
@wjhsf wjhsf merged commit e0e0879 into master Sep 26, 2025
7 checks passed
@wjhsf wjhsf deleted the wjh/wtr-sanitize-attribute-shh branch September 26, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants