blobstore: Support objectLock in GCP and AWS (#242)

Author: LihaoLiuXs

blob/blob-ali/src/main/java/com/salesforce/multicloudj/blob/ali/AliBlobStore.java

@@ -44,9 +44,11 @@
 import com.salesforce.multicloudj.blob.driver.UploadPartResponse;
 import com.salesforce.multicloudj.blob.driver.UploadRequest;
 import com.salesforce.multicloudj.blob.driver.UploadResponse;
+import com.salesforce.multicloudj.blob.driver.ObjectLockInfo;
 import com.salesforce.multicloudj.common.ali.AliConstants;
 import com.salesforce.multicloudj.common.exceptions.InvalidArgumentException;
 import com.salesforce.multicloudj.common.exceptions.SubstrateSdkException;
+import com.salesforce.multicloudj.common.exceptions.UnSupportedOperationException;
 import com.salesforce.multicloudj.common.exceptions.UnknownException;
 import com.salesforce.multicloudj.common.provider.Provider;
 import lombok.Getter;
@@ -448,6 +450,30 @@ protected void doSetTags(String key, Map<String, String> tags) {
         ossClient.setObjectTagging(bucket, key, new TagSet(tags));
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    @Override
+    public ObjectLockInfo getObjectLock(String key, String versionId) {
+        throw new UnSupportedOperationException("Alibaba OSS does not support object lock");
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    @Override
+    public void updateObjectRetention(String key, String versionId, java.time.Instant retainUntilDate) {
+        throw new UnSupportedOperationException("Alibaba OSS does not support object lock/retention");
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    @Override
+    public void updateLegalHold(String key, String versionId, boolean legalHold) {
+        throw new UnSupportedOperationException("Alibaba OSS does not support object lock/legal hold");
+    }
+
     /**
      * Generates a presigned URL for uploading/downloading blobs
      * @param request The PresignedUrlRequest
@@ -465,10 +491,7 @@ protected URL doGeneratePresignedUrl(PresignedUrlRequest request) {
     }
 
     /**
-     * Determines if an object exists for a given key/versionId
-     * @param key Name of the blob to check
-     * @param versionId The version of the blob to check
-     * @return Returns true if the object exists. Returns false if it doesn't exist.
+     * {@inheritdoc}
      */
     @Override
     protected boolean doDoesObjectExist(String key, String versionId) {

blob/blob-ali/src/test/java/com/salesforce/multicloudj/blob/ali/AliBlobStoreTest.java

@@ -54,6 +54,7 @@
 import com.salesforce.multicloudj.common.ali.AliConstants;
 import com.salesforce.multicloudj.common.exceptions.InvalidArgumentException;
 import com.salesforce.multicloudj.common.exceptions.UnAuthorizedException;
+import com.salesforce.multicloudj.common.exceptions.UnSupportedOperationException;
 import com.salesforce.multicloudj.common.exceptions.UnknownException;
 import com.salesforce.multicloudj.sts.model.CredentialsOverrider;
 import com.salesforce.multicloudj.sts.model.CredentialsType;
@@ -874,4 +875,41 @@ private OSSObject buildTestGetObjectResult(Instant now) {
         doReturn(inputStream).when(ossObject).getObjectContent();
         return ossObject;
     }
+
+    @Test
+    void testGetObjectLock_ThrowsUnsupportedException() {
+        // Given
+        String key = "test-key";
+        String versionId = "version-1";
+
+        // When/Then
+        assertThrows(UnSupportedOperationException.class, () -> {
+            ali.getObjectLock(key, versionId);
+        });
+    }
+
+    @Test
+    void testUpdateObjectRetention_ThrowsUnsupportedException() {
+        // Given
+        String key = "test-key";
+        String versionId = "version-1";
+        Instant retainUntil = Instant.now().plusSeconds(3600);
+
+        // When/Then
+        assertThrows(UnSupportedOperationException.class, () -> {
+            ali.updateObjectRetention(key, versionId, retainUntil);
+        });
+    }
+
+    @Test
+    void testUpdateLegalHold_ThrowsUnsupportedException() {
+        // Given
+        String key = "test-key";
+        String versionId = "version-1";
+
+        // When/Then
+        assertThrows(UnSupportedOperationException.class, () -> {
+            ali.updateLegalHold(key, versionId, true);
+        });
+    }
 }

blob/blob-aws/src/main/java/com/salesforce/multicloudj/blob/aws/AwsBlobClient.java

@@ -61,17 +61,17 @@ protected void doCreateBucket(String bucketName) {
     }
 
     /**
-     * Constructs an instance of {@link AwsBlobClient} using the provided builder and S3 client.
-     *
+     * Constructs an instance of {@link AwsBlobClient} using the provided builder and S3 client.     
+     * 
      * @param builder  the builder used to configure this client.
      */
     public AwsBlobClient(Builder builder) {
         this(builder, buildS3Client(builder));
     }
 
     /**
-     * Constructs an instance of {@link AwsBlobClient} using the provided builder and S3 client.
-     *
+     * Constructs an instance of {@link AwsBlobClient} using the provided builder and S3 client.      
+     * 
      * @param builder  the builder used to configure this client.
      * @param s3Client the S3 client used to communicate with the S3 service.
      */

blob/blob-aws/src/main/java/com/salesforce/multicloudj/blob/aws/AwsBlobStore.java

@@ -21,12 +21,16 @@
 import com.salesforce.multicloudj.blob.driver.PresignedUrlRequest;
 import com.salesforce.multicloudj.blob.driver.UploadPartResponse;
 import com.salesforce.multicloudj.blob.driver.UploadRequest;
+import com.salesforce.multicloudj.blob.driver.ObjectLockInfo;
 import com.salesforce.multicloudj.blob.driver.UploadResponse;
 import com.salesforce.multicloudj.common.aws.AwsConstants;
 import com.salesforce.multicloudj.common.aws.CredentialsProvider;
+import com.salesforce.multicloudj.common.exceptions.FailedPreconditionException;
 import com.salesforce.multicloudj.common.exceptions.InvalidArgumentException;
+import com.salesforce.multicloudj.common.exceptions.ResourceNotFoundException;
 import com.salesforce.multicloudj.common.exceptions.SubstrateSdkException;
 import com.salesforce.multicloudj.common.exceptions.UnknownException;
+import com.salesforce.multicloudj.common.exceptions.UnSupportedOperationException;
 import lombok.Getter;
 import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;
 import software.amazon.awssdk.awscore.exception.AwsServiceException;
@@ -60,6 +64,9 @@
 import software.amazon.awssdk.services.s3.model.ListPartsResponse;
 import software.amazon.awssdk.services.s3.model.Part;
 import software.amazon.awssdk.services.s3.model.PutObjectRequest;
+import software.amazon.awssdk.services.s3.model.GetObjectLegalHoldResponse;
+import software.amazon.awssdk.services.s3.model.GetObjectRetentionResponse;
+import software.amazon.awssdk.services.s3.model.ObjectLockRetentionMode;
 import software.amazon.awssdk.services.s3.model.PutObjectResponse;
 import software.amazon.awssdk.services.s3.model.S3Exception;
 import software.amazon.awssdk.services.s3.model.Tag;
@@ -72,6 +79,7 @@
 import java.net.URL;
 import java.nio.file.Path;
 import java.time.Duration;
+import java.time.Instant;
 import java.util.Collection;
 import java.util.Comparator;
 import java.util.Iterator;
@@ -503,6 +511,53 @@ protected boolean doDoesBucketExist() {
         }
     }
 
+    /**
+     * Gets object lock configuration for a blob.
+     */
+    @Override
+    public ObjectLockInfo getObjectLock(String key, String versionId) {
+        GetObjectRetentionResponse retentionResponse = s3Client.getObjectRetention(
+                transformer.toGetObjectRetentionRequest(key, versionId));
+        GetObjectLegalHoldResponse legalHoldResponse = s3Client.getObjectLegalHold(
+                transformer.toGetObjectLegalHoldRequest(key, versionId));
+        return transformer.toObjectLockInfo(retentionResponse, legalHoldResponse);
+    }
+
+    /**
+     * Updates object retention date.
+     * Only works if object is in GOVERNANCE mode. COMPLIANCE mode objects cannot be updated.
+     */
+    @Override
+    public void updateObjectRetention(String key, String versionId, Instant retainUntilDate) {
+        // First get current retention to check mode
+        GetObjectRetentionResponse currentRetention = s3Client.getObjectRetention(
+                transformer.toGetObjectRetentionRequest(key, versionId));
+
+        if (currentRetention == null || currentRetention.retention() == null) {
+            throw new FailedPreconditionException(
+                    "Object does not have retention configured. Cannot update retention.");
+        }
+
+        ObjectLockRetentionMode currentMode = currentRetention.retention().mode();
+
+        if (currentMode == ObjectLockRetentionMode.COMPLIANCE) {
+            throw new FailedPreconditionException(
+                    "Cannot update retention for objects in COMPLIANCE mode. " +
+                    "Only GOVERNANCE mode objects can have their retention updated.");
+        }
+
+        s3Client.putObjectRetention(transformer.toPutObjectRetentionRequest(
+                key, versionId, currentMode, retainUntilDate));
+    }
+
+    /**
+     * Updates legal hold status on an object.
+     */
+    @Override
+    public void updateLegalHold(String key, String versionId, boolean legalHold) {
+        s3Client.putObjectLegalHold(transformer.toPutObjectLegalHoldRequest(key, versionId, legalHold));
+    }
+    
     /**
      * Closes the underlying S3 client and releases any resources.
      */