blobstore: Objectlock conformance#336
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
=========================================
Coverage 82.37% 82.38%
Complexity 625 625
=========================================
Files 191 191
Lines 11506 11506
Branches 1526 1526
=========================================
+ Hits 9478 9479 +1
Misses 1357 1357
+ Partials 671 670 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * Whether this provider supports object lock (WORM). When false, object lock conformance | ||
| * tests are skipped. | ||
| */ | ||
| default boolean isObjectLockSupported() { |
There was a problem hiding this comment.
which substrate doesn't support locking, the default should be always yes since no is introducing disparity.
There was a problem hiding this comment.
We don't have the locking support in Ali yet.
There was a problem hiding this comment.
I updated the default value to true, and set the value to false for inMemoryBlobstore.
| try { | ||
| Map<String, String> tags3 = Map.of("tag5", "value5"); | ||
| bucketClient.setTags(key + "-fake", tags3); | ||
| } catch (Throwable t) { | ||
| failed = true; | ||
| } |
There was a problem hiding this comment.
What are we doing here?
There was a problem hiding this comment.
This was the same logic copied from testTagging, just with the object lock enabled. We expect it goes to the catch block because we are calling setTag on a fake key which is non-exist.
…ockSupported to false for inMemoryBlobstore
3 participants
Summary
< Provide a brief description of the changes in this PR >
Some conventions to follow
docstore:for document store module,blobstorefor Blob Store moduletest:perf: